External/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(desktop): use struct literal init to satisfy clippy::field_reassign_with_default

Browse Source 
Four test-setup sites created GlobalAgentConfig::default() then immediately
assigned permission_policy. Clippy 1.95 flags this as field-reassign-with-default.
Rewrite each site to use a struct literal with ..Default::default().

Files: agents_deploy.rs (1 site), permission_policy.rs (3 sites).
Zero semantic change — test-only correction.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This commit is contained in:
Duncan
2026-08-07 18:00:34 -04:00
co-authored by Will Pfleger
parent 2dd0706d8f
commit e87f265d25
2 changed files with 18 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
desktop/src-tauri/src/commands/agents_deploy.rs
+6 -3
View File
@@ -553,9 +553,12 @@ mod tests {
args: vec![],
env: BTreeMap::new(),
};
let mut global = crate::managed_agents::global_config::GlobalAgentConfig::default();
global.permission_policy =
Some(crate::managed_agents::permission_policy::PermissionPolicy::Allow);
let global = crate::managed_agents::global_config::GlobalAgentConfig {
permission_policy: Some(
crate::managed_agents::permission_policy::PermissionPolicy::Allow,
),
..Default::default()
};
let (effective_policy, _) =
crate::managed_agents::permission_policy::resolve_effective_permission_policy(
&record, &global,
desktop/src-tauri/src/managed_agents/permission_policy.rs
+12 -6
View File
@@ -131,8 +131,10 @@ mod tests {
fn test_per_agent_policy_beats_global_and_built_in() {
let mut record = empty_record();
record.permission_policy = Some(PermissionPolicy::Allow);
let mut global = GlobalAgentConfig::default();
global.permission_policy = Some(PermissionPolicy::Reject);
let global = GlobalAgentConfig {
permission_policy: Some(PermissionPolicy::Reject),
..Default::default()
};
let (policy, source) = resolve_effective_permission_policy(&record, &global);
assert_eq!(policy, PermissionPolicy::Allow);
@@ -143,8 +145,10 @@ mod tests {
fn test_global_policy_beats_built_in_when_no_per_agent() {
let mut record = empty_record();
record.permission_policy = None;
let mut global = GlobalAgentConfig::default();
global.permission_policy = Some(PermissionPolicy::Allow);
let global = GlobalAgentConfig {
permission_policy: Some(PermissionPolicy::Allow),
..Default::default()
};
let (policy, source) = resolve_effective_permission_policy(&record, &global);
assert_eq!(policy, PermissionPolicy::Allow);
@@ -166,8 +170,10 @@ mod tests {
fn test_per_agent_reject_beats_global_allow() {
let mut record = empty_record();
record.permission_policy = Some(PermissionPolicy::Reject);
let mut global = GlobalAgentConfig::default();
global.permission_policy = Some(PermissionPolicy::Allow);
let global = GlobalAgentConfig {
permission_policy: Some(PermissionPolicy::Allow),
..Default::default()
};
let (policy, source) = resolve_effective_permission_policy(&record, &global);
assert_eq!(policy, PermissionPolicy::Reject);