From e87f265d258a1816995f743e4fee85d4a2ee6c02 Mon Sep 17 00:00:00 2001 From: Duncan Date: Fri, 7 Aug 2026 18:00:34 -0400 Subject: [PATCH] fix(desktop): use struct literal init to satisfy clippy::field_reassign_with_default MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Four test-setup sites created GlobalAgentConfig::default() then immediately assigned permission_policy. Clippy 1.95 flags this as field-reassign-with-default. Rewrite each site to use a struct literal with ..Default::default(). Files: agents_deploy.rs (1 site), permission_policy.rs (3 sites). Zero semantic change — test-only correction. Co-authored-by: Will Pfleger Signed-off-by: Will Pfleger --- .../src-tauri/src/commands/agents_deploy.rs | 9 ++++++--- .../src/managed_agents/permission_policy.rs | 18 ++++++++++++------ 2 files changed, 18 insertions(+), 9 deletions(-) diff --git a/desktop/src-tauri/src/commands/agents_deploy.rs b/desktop/src-tauri/src/commands/agents_deploy.rs index 8e425dd07..d1a495db9 100644 --- a/desktop/src-tauri/src/commands/agents_deploy.rs +++ b/desktop/src-tauri/src/commands/agents_deploy.rs @@ -553,9 +553,12 @@ mod tests { args: vec![], env: BTreeMap::new(), }; - let mut global = crate::managed_agents::global_config::GlobalAgentConfig::default(); - global.permission_policy = - Some(crate::managed_agents::permission_policy::PermissionPolicy::Allow); + let global = crate::managed_agents::global_config::GlobalAgentConfig { + permission_policy: Some( + crate::managed_agents::permission_policy::PermissionPolicy::Allow, + ), + ..Default::default() + }; let (effective_policy, _) = crate::managed_agents::permission_policy::resolve_effective_permission_policy( &record, &global, diff --git a/desktop/src-tauri/src/managed_agents/permission_policy.rs b/desktop/src-tauri/src/managed_agents/permission_policy.rs index 8864cc9d9..33224e324 100644 --- a/desktop/src-tauri/src/managed_agents/permission_policy.rs +++ b/desktop/src-tauri/src/managed_agents/permission_policy.rs @@ -131,8 +131,10 @@ mod tests { fn test_per_agent_policy_beats_global_and_built_in() { let mut record = empty_record(); record.permission_policy = Some(PermissionPolicy::Allow); - let mut global = GlobalAgentConfig::default(); - global.permission_policy = Some(PermissionPolicy::Reject); + let global = GlobalAgentConfig { + permission_policy: Some(PermissionPolicy::Reject), + ..Default::default() + }; let (policy, source) = resolve_effective_permission_policy(&record, &global); assert_eq!(policy, PermissionPolicy::Allow); @@ -143,8 +145,10 @@ mod tests { fn test_global_policy_beats_built_in_when_no_per_agent() { let mut record = empty_record(); record.permission_policy = None; - let mut global = GlobalAgentConfig::default(); - global.permission_policy = Some(PermissionPolicy::Allow); + let global = GlobalAgentConfig { + permission_policy: Some(PermissionPolicy::Allow), + ..Default::default() + }; let (policy, source) = resolve_effective_permission_policy(&record, &global); assert_eq!(policy, PermissionPolicy::Allow); @@ -166,8 +170,10 @@ mod tests { fn test_per_agent_reject_beats_global_allow() { let mut record = empty_record(); record.permission_policy = Some(PermissionPolicy::Reject); - let mut global = GlobalAgentConfig::default(); - global.permission_policy = Some(PermissionPolicy::Allow); + let global = GlobalAgentConfig { + permission_policy: Some(PermissionPolicy::Allow), + ..Default::default() + }; let (policy, source) = resolve_effective_permission_policy(&record, &global); assert_eq!(policy, PermissionPolicy::Reject);