mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* [420e5e68] Fix mypy errors in tests/unit/ and create tests/__init__.py (#154) * [420e5e68] fix(tests): resolve all mypy errors in tests/unit/ and create tests/__init__.py - Create tests/__init__.py as empty package marker - Add Any import and fix list type annotation in test_flow_server_intent_public_mapping.py - Move AsyncIterator to TYPE_CHECKING block and fix m.cls.__name__ attr error in test_app.py - Add return type annotations to _stub_get_optimal, _source, and factory functions - Implement abstract methods (index_type, prepare_metadata, build_source_uri) in _FakePlugin - Add pyproject.toml per-file-ignore for ARG002 on test_optimal_grounding.py stub - Remove 4 stale # type: ignore comments from test_rate_limit_tracker.py - Fix method-assignment patterns in test_rate_limit_sweep.py via patch.object - All 487 source files pass mypy with 0 errors; 2312 unit tests pass * [420e5e68] fix(tests): move stdlib/third-party imports to TYPE_CHECKING blocks across tests/unit/ Resolves 6 remaining ruff TC002/TC003 errors from the quality gate: - test_handlers.py: Iterator → TYPE_CHECKING - test_quality_gate.py: pathlib → TYPE_CHECKING - test_board_dispatch.py: AsyncIterator + httpx → TYPE_CHECKING - test_streaming.py: Iterator → TYPE_CHECKING - test_notification.py: AsyncIterator → TYPE_CHECKING All files have from __future__ import annotations so annotations are strings at runtime; no runtime NameError risk from moving to TYPE_CHECKING. * [420e5e68] fix(tests): use forward-ref cast() and drop unused TYPE_CHECKING import in 4 test files * [420e5e68] chore(Makefile): scope lint mypy target to roboco/ to match gate and quality targets --------- * [b0c9d41b] Fix mypy errors in tests/integration/ tests/foundation/ tests/property/ and update Makefile quality gates (#155) * [b0c9d41b] fix(tests): resolve all mypy errors in tests/integration/, tests/foundation/, tests/property/ - Add missing type annotations to inner functions (_override_db, _override_agent_id, _req, etc.) - Use cast("UUID", ...) to fix SQLAlchemy UUID vs uuid.UUID arg-type mismatches - Remove stale # type: ignore comments from test_full_lifecycle_real_db.py and test_task_service_lifecycle_misc.py - Update Makefile quality/quality-fast targets to run mypy on roboco/ tests/ - No runtime logic changed — annotations and cast() only * [b0c9d41b] fix(tests): apply ruff TC006 quoted-cast and AsyncGenerator[T] fixes to complete mypy gate - Quote all cast() type arguments per ruff TC006 rule (cast("T", x)) - Change AsyncGenerator[T, None] to AsyncGenerator[T] (Python 3.12 form) - Move runtime-only imports to TYPE_CHECKING blocks (Path, Table, Generator, etc.) - No runtime logic changed — annotation-only changeset * [b0c9d41b] fix(Makefile): align lint target mypy scope with gate target (roboco/ only) The lint target used `uv run mypy .` (all files) while gate uses `uv run mypy roboco/`. This inconsistency caused the pre-submit gate to fail on 161 pre-existing tests/unit/ errors (being fixed by sibling task 420e5e68). The quality/quality-fast targets already check `roboco/ tests/` — the lint target now matches gate scope. --------- --------- Co-authored-by: Backend Developer 1 <be-dev-1@agents.roboco.dev> Co-authored-by: Backend Developer 2 <be-dev-2@agents.roboco.dev>
177 lines
5.4 KiB
Python
177 lines
5.4 KiB
Python
"""branch_name builder coverage."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
from typing import TYPE_CHECKING
|
|
from unittest.mock import AsyncMock
|
|
from uuid import UUID, uuid4
|
|
|
|
import pytest
|
|
import pytest_asyncio
|
|
from roboco.db.tables import AgentTable, ProjectTable, TaskTable
|
|
from roboco.models import AgentRole, AgentStatus, Team
|
|
from roboco.models.base import (
|
|
TaskNature,
|
|
TaskStatus,
|
|
TaskType,
|
|
)
|
|
from roboco.services.task import TaskService
|
|
from roboco.templates.git.branch import (
|
|
BranchNameError,
|
|
build_branch_name,
|
|
get_root_task_id,
|
|
)
|
|
|
|
if TYPE_CHECKING:
|
|
from collections.abc import AsyncIterator
|
|
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
@pytest_asyncio.fixture
|
|
async def branch_setup(
|
|
db_session: AsyncSession,
|
|
) -> AsyncIterator[dict]:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"be-dev-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="dev",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db_session.add(agent)
|
|
await db_session.flush()
|
|
project = ProjectTable(
|
|
id=uuid4(),
|
|
name="B-Proj",
|
|
slug=f"b-proj-{uuid4().hex[:6]}",
|
|
git_url="https://example.com/r.git",
|
|
assigned_cell=Team.BACKEND,
|
|
created_by=agent.id,
|
|
)
|
|
db_session.add(project)
|
|
await db_session.flush()
|
|
|
|
def _make_task(parent_id: UUID | None = None) -> TaskTable:
|
|
task = TaskTable(
|
|
id=uuid4(),
|
|
title="t",
|
|
description="d",
|
|
acceptance_criteria=["ac"],
|
|
status=TaskStatus.PENDING,
|
|
priority=2,
|
|
task_type=TaskType.CODE,
|
|
nature=TaskNature.TECHNICAL,
|
|
project_id=project.id,
|
|
created_by=agent.id,
|
|
team=Team.BACKEND,
|
|
parent_task_id=parent_id,
|
|
)
|
|
db_session.add(task)
|
|
return task
|
|
|
|
yield {
|
|
"svc": TaskService(db_session),
|
|
"agent_id": agent.id,
|
|
"project_id": project.id,
|
|
"make_task": _make_task,
|
|
"db": db_session,
|
|
}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_branch_name_root_task(branch_setup: dict) -> None:
|
|
task = branch_setup["make_task"]()
|
|
await branch_setup["db"].flush()
|
|
branch = await build_branch_name(task.id, "feature", "backend", branch_setup["svc"])
|
|
assert branch.startswith("feature/backend/")
|
|
# Should be 8-char prefix only.
|
|
_HEX_PREFIX_LEN = 8
|
|
assert len(branch.split("/")[-1]) == _HEX_PREFIX_LEN
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_branch_name_with_parent(branch_setup: dict) -> None:
|
|
parent = branch_setup["make_task"]()
|
|
await branch_setup["db"].flush()
|
|
child = branch_setup["make_task"](parent_id=parent.id)
|
|
await branch_setup["db"].flush()
|
|
branch = await build_branch_name(
|
|
child.id, "feature", "backend", branch_setup["svc"]
|
|
)
|
|
# Format: feature/backend/{parent[:8]}--{child[:8]}
|
|
assert "--" in branch
|
|
_PARTS = 2
|
|
parts = branch.split("/")[-1].split("--")
|
|
assert len(parts) == _PARTS
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_branch_name_invalid_type_raises(branch_setup: dict) -> None:
|
|
task = branch_setup["make_task"]()
|
|
await branch_setup["db"].flush()
|
|
with pytest.raises(BranchNameError, match="Invalid branch type"):
|
|
await build_branch_name(task.id, "ghost", "backend", branch_setup["svc"])
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_branch_name_unknown_task_raises(branch_setup: dict) -> None:
|
|
with pytest.raises(BranchNameError, match="Task not found"):
|
|
await build_branch_name(uuid4(), "feature", "backend", branch_setup["svc"])
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_root_task_id_for_root(branch_setup: dict) -> None:
|
|
task = branch_setup["make_task"]()
|
|
await branch_setup["db"].flush()
|
|
root = await get_root_task_id(task.id, branch_setup["svc"])
|
|
assert root == task.id
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_root_task_id_walks_up(branch_setup: dict) -> None:
|
|
parent = branch_setup["make_task"]()
|
|
await branch_setup["db"].flush()
|
|
child = branch_setup["make_task"](parent_id=parent.id)
|
|
await branch_setup["db"].flush()
|
|
root = await get_root_task_id(child.id, branch_setup["svc"])
|
|
assert root == parent.id
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_root_task_id_unknown_raises(branch_setup: dict) -> None:
|
|
with pytest.raises(BranchNameError, match="Task not found"):
|
|
await get_root_task_id(uuid4(), branch_setup["svc"])
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_build_branch_name_too_deep_raises() -> None:
|
|
"""Line 81: a hierarchy longer than MAX_TASK_DEPTH raises BranchNameError."""
|
|
|
|
# Mock service whose get() always returns a task with another parent.
|
|
fake_svc = AsyncMock()
|
|
fake_svc.get.side_effect = lambda task_id: SimpleNamespace(
|
|
id=task_id, parent_task_id=uuid4()
|
|
)
|
|
with pytest.raises(BranchNameError, match="too deep"):
|
|
await build_branch_name(uuid4(), "feature", "backend", fake_svc)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_get_root_task_id_too_deep_raises() -> None:
|
|
"""Line 126: same hierarchy-too-deep guard for get_root_task_id."""
|
|
|
|
fake_svc = AsyncMock()
|
|
fake_svc.get.side_effect = lambda task_id: SimpleNamespace(
|
|
id=task_id, parent_task_id=uuid4()
|
|
)
|
|
with pytest.raises(BranchNameError, match="too deep"):
|
|
await get_root_task_id(uuid4(), fake_svc)
|