mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
68 lines
2.4 KiB
Python
68 lines
2.4 KiB
Python
"""Hygiene checks: inline comments + lint/type suppressions."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from roboco.conventions.hygiene import check_hygiene
|
|
from roboco.foundation.policy.conventions.models import ConventionsStandard, Rule
|
|
|
|
_STD = ConventionsStandard()
|
|
|
|
|
|
def _rules(findings: list, rule: str) -> list:
|
|
return [f for f in findings if f.rule == rule]
|
|
|
|
|
|
def test_trailing_comment_is_flagged_inline() -> None:
|
|
findings = check_hygiene("a.py", b"x = 1 # set x\n", "python", _STD)
|
|
inline = _rules(findings, "no_inline_comments")
|
|
assert inline and inline[0].level == "warn"
|
|
assert inline[0].line == 1
|
|
|
|
|
|
def test_full_line_comment_is_not_inline() -> None:
|
|
findings = check_hygiene("a.py", b"# a heading\nx = 1\n", "python", _STD)
|
|
assert _rules(findings, "no_inline_comments") == []
|
|
|
|
|
|
def test_indented_full_line_comment_is_not_inline() -> None:
|
|
src = b"def f():\n # explain\n return 1\n"
|
|
findings = check_hygiene("a.py", src, "python", _STD)
|
|
assert _rules(findings, "no_inline_comments") == []
|
|
|
|
|
|
def test_python_type_ignore_flags_suppression_block() -> None:
|
|
findings = check_hygiene("a.py", b"y = bad() # type: ignore\n", "python", _STD)
|
|
sup = _rules(findings, "no_lint_suppressions")
|
|
assert sup and sup[0].level == "block"
|
|
|
|
|
|
def test_python_noqa_flags_suppression() -> None:
|
|
findings = check_hygiene("a.py", b"import os # noqa: F401\n", "python", _STD)
|
|
assert _rules(findings, "no_lint_suppressions")
|
|
|
|
|
|
def test_ts_eslint_disable_flags_suppression() -> None:
|
|
src = b"// eslint-disable-next-line\nconst x = 1;\n"
|
|
findings = check_hygiene("a.ts", src, "typescript", _STD)
|
|
assert _rules(findings, "no_lint_suppressions")
|
|
|
|
|
|
def test_ts_ignore_flags_suppression() -> None:
|
|
src = b"// @ts-ignore\nconst x: number = 'no';\n"
|
|
findings = check_hygiene("a.ts", src, "typescript", _STD)
|
|
assert _rules(findings, "no_lint_suppressions")
|
|
|
|
|
|
def test_python_marker_not_applied_to_typescript() -> None:
|
|
src = b"// noqa is a python thing\nconst x = 1;\n"
|
|
findings = check_hygiene("a.ts", src, "typescript", _STD)
|
|
assert _rules(findings, "no_lint_suppressions") == []
|
|
|
|
|
|
def test_rule_level_override_from_standard() -> None:
|
|
std = ConventionsStandard(
|
|
rules={"no_inline_comments": Rule(name="no_inline_comments", level="block")}
|
|
)
|
|
findings = check_hygiene("a.py", b"x = 1 # c\n", "python", std)
|
|
assert _rules(findings, "no_inline_comments")[0].level == "block"
|