mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
Renn F
3441e37120
Post-audit sweep over the 135 audit-fix commits since19a474d3: 1. Stripped every # Fxxx: audit-ID token from comments AND every Fxxx token from docstring openings across 211 blocks / ~626 lines. The CEO flagged these twice: audit-issue IDs in code confuse future devs/agents. The descriptive text is preserved; only the Fxxx token is removed (and bloated narrative blocks trimmed to 1-3 lines keeping the one non-obvious invariant). 2. Trimmed bloated comments/docstrings to the concise standard (1-3 lines). 3. Added missing behavior-change docs for the audit-fix batch: prompts/roles (documenter, pr_reviewer, qa), user-facing docs (api auth, websockets, agent-gateway, megatask, merge-model, task-lifecycle, grok, resilience, conventions, panel, security, troubleshooting), and the RAG corpus (cell-pm, main-pm, pr-reviewer, qa roles; conventions; messaging-tools; escalation; megatask; task-claiming workflows). Comment/docstring/prose ONLY — zero code-line edits (verified: the diff contains no def/class/return/if/for/await/assignment/call lines). Gates green: ruff format + ruff check clean, mypy clean on roboco/. The only pytest failures are the pre-existing sync_branch tracing-decision gap (B1,250be5c2) — not sweep-caused and tracked separately.
96 lines
3.3 KiB
Python
96 lines
3.3 KiB
Python
"""Startup re-adoption of still-running agent containers into ``_instances``.
|
|
|
|
An orchestrator restart loses the in-memory ``_instances`` registry while the
|
|
agent containers keep running. The reaper has a Docker-liveness fallback for
|
|
that (``_assignee_container_running``), but the spawn gate's ``_is_agent_active``
|
|
does not — so after a restart it sees a live agent as inactive and can
|
|
double-spawn it onto work its forgotten-but-running container is already doing.
|
|
``_readopt_running_agents`` probes each known agent slug's container and
|
|
re-registers a minimal ACTIVE instance for any that is running, so both the
|
|
reaper's live-skip and the spawn gate see the live agent immediately.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
from roboco.runtime.orchestrator import AgentOrchestrator, AgentState
|
|
|
|
_EXPECTED_READOPTED = 2
|
|
|
|
|
|
def _orch() -> Any:
|
|
orch = AgentOrchestrator.__new__(AgentOrchestrator) # bypass __init__
|
|
orch._instances = {}
|
|
return orch
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopts_running_containers_as_active() -> None:
|
|
orch = _orch()
|
|
running = {"be-dev-1", "fe-pm"}
|
|
|
|
async def inspect(name: str) -> tuple[bool, int | None]:
|
|
slug = name.removeprefix("roboco-agent-")
|
|
return (slug in running, 0)
|
|
|
|
orch._inspect_container_state = AsyncMock(side_effect=inspect)
|
|
|
|
n = await orch._readopt_running_agents()
|
|
|
|
assert n == _EXPECTED_READOPTED
|
|
assert orch._instances["be-dev-1"].state == AgentState.ACTIVE
|
|
assert orch._instances["be-dev-1"].agent_id == "be-dev-1"
|
|
assert orch._instances["fe-pm"].state == AgentState.ACTIVE
|
|
assert "be-dev-2" not in orch._instances # probed, not running → untracked
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_leaves_already_tracked_instance_untouched() -> None:
|
|
orch = _orch()
|
|
sentinel = MagicMock()
|
|
orch._instances = {"be-dev-1": sentinel}
|
|
orch._inspect_container_state = AsyncMock(return_value=(True, 0))
|
|
|
|
await orch._readopt_running_agents()
|
|
|
|
assert orch._instances["be-dev-1"] is sentinel # not re-adopted over
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_inert_when_nothing_running() -> None:
|
|
orch = _orch()
|
|
orch._inspect_container_state = AsyncMock(return_value=(False, None))
|
|
|
|
n = await orch._readopt_running_agents()
|
|
|
|
assert n == 0
|
|
assert orch._instances == {}
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_swallows_probe_errors() -> None:
|
|
orch = _orch()
|
|
orch._inspect_container_state = AsyncMock(side_effect=RuntimeError("no docker"))
|
|
|
|
n = await orch._readopt_running_agents()
|
|
|
|
assert n == 0 # best-effort: a probe failure never raises into startup
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_readopt_records_container_id_so_health_check_can_see_exit() -> None:
|
|
# Re-adopt must capture the real container id; a None container_id is skipped
|
|
# by _check_health, stranding the task under a phantom ACTIVE instance.
|
|
orch = _orch()
|
|
orch._inspect_container_state = AsyncMock(return_value=(True, 0))
|
|
orch._resolve_container_id = AsyncMock(return_value="deadbeef1234")
|
|
|
|
await orch._readopt_running_agents()
|
|
|
|
inst = orch._instances[next(iter(orch._instances))]
|
|
assert inst.container_id == "deadbeef1234"
|
|
assert inst.state == AgentState.ACTIVE
|