mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
The Main-PM-code-impossibility guard (commit e202ce39, Thread 4 of this
audit) made team=MAIN_PM + task_type=CODE impossible — a Main PM coordinates,
it does not write code. But the ci_watch and dep_update engines still
originated their fix tasks as task_type=TaskType.CODE assigned to main-pm,
so task_svc.create raised MAIN_PM_NO_CODE and NO fix task was ever opened
— a regression introduced by the earlier audit fix (confirmed: the engine
tests pass at e202ce39~1 and fail at HEAD).
Mirror the hardened self_heal_engine precedent (self_heal_engine.py:197)
which already uses task_type=TaskType.PLANNING for its Main-PM coordination
root with an explicit 'decompose the fix and delegate the code work to a
cell dev — the Main PM does not write the fix itself' description. Both
engines now originate PLANNING coordination roots with matching delegation
guidance in the description + acceptance criteria. confirmed_by_human
stays True for both (they ride the normal delivery flow without the CEO
gate, unlike self-heal — intentional per the architecture).
The dedupe/open-cap queries (list_open_ci_watch_tasks /
list_open_dep_update_tasks) key on source + non-terminal status + git_url,
NOT task_type, so the type change does not break dedup (still one open fix
task per repo).
The two source-test fixtures (test_ci_watch_source / test_dep_update_source)
created CODE+MAIN_PM tasks directly to exercise the listing queries — same
guard violation; switched to PLANNING (the queries assert on source/status,
not task_type, so the fixture type matches the engines' corrected type).
137 lines
4.3 KiB
Python
137 lines
4.3 KiB
Python
"""CI_WATCH_SOURCE + list_open_ci_watch_tasks — the dedupe / open-cap basis.
|
|
|
|
Open ci_watch tasks count toward the cap and block a duplicate; terminal ones
|
|
and other-source tasks do not. The git_url scoping keys dedupe on the repo (a
|
|
monorepo registers several cell-projects on one git_url), so a watched repo
|
|
gets at most one open fix task even across its cell-projects.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING, cast
|
|
from uuid import UUID, uuid4
|
|
|
|
import pytest
|
|
from roboco.db.tables import AgentTable, ProjectTable
|
|
from roboco.foundation import identity as _foundation
|
|
from roboco.models.base import (
|
|
AgentRole,
|
|
AgentStatus,
|
|
Complexity,
|
|
TaskNature,
|
|
TaskStatus,
|
|
TaskType,
|
|
Team,
|
|
)
|
|
from roboco.models.task import TaskCreateRequest
|
|
from roboco.services.task import CI_WATCH_SOURCE, get_task_service
|
|
|
|
if TYPE_CHECKING:
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
SYSTEM_UUID = _foundation.AGENTS["system"].uuid
|
|
MAIN_PM_UUID = _foundation.AGENTS["main-pm"].uuid
|
|
_TWO = 2
|
|
|
|
|
|
async def _get_or_create_agent(
|
|
db: AsyncSession, agent_id: object, role: AgentRole, slug: str
|
|
) -> None:
|
|
if await db.get(AgentTable, agent_id) is None:
|
|
db.add(
|
|
AgentTable(
|
|
id=agent_id,
|
|
name=slug,
|
|
slug=f"{slug}-{uuid4().hex[:8]}",
|
|
role=role,
|
|
team=None,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="x",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
)
|
|
await db.flush()
|
|
|
|
|
|
async def _seed_project(db: AsyncSession, git_url: str) -> ProjectTable:
|
|
project = ProjectTable(
|
|
id=uuid4(),
|
|
name="P",
|
|
slug=f"p-{uuid4().hex[:8]}",
|
|
git_url=git_url,
|
|
assigned_cell=Team.BACKEND,
|
|
created_by=SYSTEM_UUID,
|
|
)
|
|
db.add(project)
|
|
await db.flush()
|
|
return project
|
|
|
|
|
|
async def _make_ci_watch_task(
|
|
db: AsyncSession,
|
|
project: ProjectTable,
|
|
*,
|
|
source: str = CI_WATCH_SOURCE,
|
|
terminal: bool = False,
|
|
) -> None:
|
|
svc = get_task_service(db)
|
|
task = await svc.create(
|
|
TaskCreateRequest(
|
|
title="CI-watch fix",
|
|
description="Fix the CI regression on this project's default branch.",
|
|
acceptance_criteria=["CI is green again"],
|
|
team=Team.MAIN_PM,
|
|
assigned_to=MAIN_PM_UUID,
|
|
created_by=SYSTEM_UUID,
|
|
task_type=TaskType.PLANNING,
|
|
nature=TaskNature.TECHNICAL,
|
|
estimated_complexity=Complexity.MEDIUM,
|
|
project_id=cast("UUID", project.id),
|
|
status=TaskStatus.PENDING,
|
|
source=source,
|
|
confirmed_by_human=True,
|
|
)
|
|
)
|
|
if terminal:
|
|
task.status = TaskStatus.COMPLETED
|
|
await db.flush()
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
async def _agents(db_session: AsyncSession) -> None:
|
|
await _get_or_create_agent(db_session, SYSTEM_UUID, AgentRole.SYSTEM, "system")
|
|
await _get_or_create_agent(db_session, MAIN_PM_UUID, AgentRole.MAIN_PM, "main-pm")
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_lists_only_open_ci_watch_tasks(db_session: AsyncSession) -> None:
|
|
proj = await _seed_project(db_session, "https://github.com/x/a.git")
|
|
await _make_ci_watch_task(db_session, proj) # open ci_watch
|
|
await _make_ci_watch_task(db_session, proj, terminal=True) # terminal ci_watch
|
|
await _make_ci_watch_task(db_session, proj, source="manual") # other source
|
|
|
|
open_tasks = await get_task_service(db_session).list_open_ci_watch_tasks()
|
|
|
|
assert len(open_tasks) == 1
|
|
assert open_tasks[0].source == CI_WATCH_SOURCE
|
|
assert open_tasks[0].status != TaskStatus.COMPLETED
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_git_url_scoping_returns_only_that_repo(
|
|
db_session: AsyncSession,
|
|
) -> None:
|
|
proj_a = await _seed_project(db_session, "https://github.com/x/a.git")
|
|
proj_b = await _seed_project(db_session, "https://github.com/x/b.git")
|
|
await _make_ci_watch_task(db_session, proj_a)
|
|
await _make_ci_watch_task(db_session, proj_b)
|
|
|
|
svc = get_task_service(db_session)
|
|
assert len(await svc.list_open_ci_watch_tasks()) == _TWO
|
|
scoped = await svc.list_open_ci_watch_tasks(git_url="https://github.com/x/a.git")
|
|
assert len(scoped) == 1
|
|
assert scoped[0].project_id == proj_a.id
|