roboco/tests/unit/services/test_vault_intake_engine.py

"""Vault intake watcher: #roboco-tagged notes become board-review drafts.

Mirrors the X-engine / roadmap-engine test shape. The engine opens a PENDING,
Product-Owner-assigned, team=board draft (source=vault_note) — the intake
"Board review & Start" shape. Nothing enters delivery until the CEO's
approve_and_start: the dispatch tests prove the draft routes ONLY to the
board review, and the cap tests prove approval/cancellation free the cap.
Asserted against a real Postgres DB.
"""

from __future__ import annotations

from typing import TYPE_CHECKING, Any, cast
from unittest.mock import AsyncMock, MagicMock

import pytest
from roboco.config import settings as cfg
from roboco.db.tables import AgentTable, ProjectTable, VaultSeenNoteTable
from roboco.foundation import identity as _foundation
from roboco.models.base import (
    AgentRole,
    AgentStatus,
    TaskType,
    Team,
)
from roboco.models.base import TaskStatus as TS
from roboco.runtime.orchestrator import AgentOrchestrator, _is_held_ceo_source
from roboco.services import vault_intake_engine as vie_module
from roboco.services.task import VAULT_NOTE_SOURCE, get_task_service
from roboco.services.vault_intake_engine import VaultIntakeEngine
from sqlalchemy import select

if TYPE_CHECKING:
    from pathlib import Path

    from sqlalchemy.ext.asyncio import AsyncSession

SYSTEM_UUID = _foundation.AGENTS["system"].uuid
PO_UUID = _foundation.AGENTS["product-owner"].uuid
MAIN_PM_UUID = _foundation.AGENTS["main-pm"].uuid
SLUG = "roboco"
ONE = 1
TWO = 2


async def _seed(session: AsyncSession) -> None:
    for uuid, slug, role, team in (
        (SYSTEM_UUID, "system", AgentRole.SYSTEM, None),
        (PO_UUID, "product-owner", AgentRole.PRODUCT_OWNER, Team.BOARD),
        (MAIN_PM_UUID, "main-pm", AgentRole.MAIN_PM, Team.MAIN_PM),
    ):
        if await session.get(AgentTable, uuid) is None:
            session.add(
                AgentTable(
                    id=uuid,
                    name=slug,
                    slug=slug,
                    role=role,
                    team=team,
                    status=AgentStatus.ACTIVE,
                    model_config={},
                    system_prompt="x",
                    capabilities=[],
                    permissions={},
                    metrics={},
                )
            )
    await session.flush()
    session.add(
        ProjectTable(
            name="RoboCo",
            slug=SLUG,
            git_url="https://github.com/x/roboco.git",
            default_branch="master",
            protected_branches=["master"],
            assigned_cell=Team.BACKEND,
            created_by=SYSTEM_UUID,
            is_active=True,
        )
    )
    await session.flush()


def _enable(
    monkeypatch: pytest.MonkeyPatch, tmp_path: Path, **overrides: object
) -> Path:
    monkeypatch.setattr(cfg, "obsidian_vault_enabled", True)
    monkeypatch.setattr(cfg, "vault_intake_enabled", True)
    monkeypatch.setattr(cfg, "self_heal_project_slug", SLUG)
    monkeypatch.setattr(cfg, "vault_path", str(tmp_path))
    monkeypatch.setattr(cfg, "vault_intake_dir", "RoboCo/Inbox")
    monkeypatch.setattr(cfg, "vault_intake_max_per_cycle", 3)
    monkeypatch.setattr(cfg, "vault_intake_max_open_drafts", 10)
    for key, value in overrides.items():
        monkeypatch.setattr(cfg, key, value)
    inbox = tmp_path / "RoboCo" / "Inbox"
    inbox.mkdir(parents=True)
    return inbox


def _mock_local_model(monkeypatch: pytest.MonkeyPatch, reply: str | None) -> AsyncMock:
    mock = AsyncMock(return_value=reply)
    monkeypatch.setattr(vie_module, "_chat", mock)
    return mock


def _write(inbox: Path, name: str, content: str) -> Path:
    path = inbox / name
    path.write_text(content, encoding="utf-8")
    return path


_FRONTMATTER_TAGGED = "---\ntags: [roboco]\n---\n\n# Buy milk\n\nGet 2% milk.\n"
_INLINE_TAGGED = "# Fix the fence\n\n#roboco the fence is leaning.\n"
_UNTAGGED = "# Just a note\n\nNothing to see here.\n"
_WITH_CHECKBOXES = (
    "---\ntags: [roboco]\n---\n\n# Weekend chores\n\n"
    "- [ ] Mow the lawn\n- [ ] Wash the car\n"
)


# --------------------------------------------------------------------------- #
# Tag detection
# --------------------------------------------------------------------------- #


@pytest.mark.asyncio
async def test_frontmatter_tag_is_processed(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "a.md", _FRONTMATTER_TAGGED)
    _mock_local_model(monkeypatch, None)
    drafts = await VaultIntakeEngine(db_session).run_cycle()
    assert len(drafts) == ONE


@pytest.mark.asyncio
async def test_inline_tag_is_processed(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "b.md", _INLINE_TAGGED)
    _mock_local_model(monkeypatch, None)
    drafts = await VaultIntakeEngine(db_session).run_cycle()
    assert len(drafts) == ONE


@pytest.mark.asyncio
async def test_untagged_note_is_ignored(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "c.md", _UNTAGGED)
    _mock_local_model(monkeypatch, None)
    drafts = await VaultIntakeEngine(db_session).run_cycle()
    assert drafts == []
    ledger = (await db_session.execute(select(VaultSeenNoteTable))).scalars().all()
    assert ledger == []


# --------------------------------------------------------------------------- #
# Ledger dedup
# --------------------------------------------------------------------------- #


@pytest.mark.asyncio
async def test_unchanged_note_is_never_reprocessed(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "d.md", _FRONTMATTER_TAGGED)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    first = await engine.run_cycle()
    assert len(first) == ONE
    second = await engine.run_cycle()
    assert second == []


@pytest.mark.asyncio
async def test_edited_note_is_eligible_again(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    path = _write(inbox, "e.md", _FRONTMATTER_TAGGED)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    first = await engine.run_cycle()
    assert len(first) == ONE
    # Edit the note's real content (not just appending the callout) — a new
    # ledger key, so it's eligible again.
    path.write_text(
        path.read_text(encoding="utf-8") + "\nAlso get some bread.\n",
        encoding="utf-8",
    )
    second = await engine.run_cycle()
    assert len(second) == ONE


# --------------------------------------------------------------------------- #
# Caps
# --------------------------------------------------------------------------- #


@pytest.mark.asyncio
async def test_max_per_cycle_cap(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path, vault_intake_max_per_cycle=2)
    for i in range(4):
        _write(inbox, f"note{i}.md", _FRONTMATTER_TAGGED)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    first = await engine.run_cycle()
    assert len(first) == TWO
    second = await engine.run_cycle()
    assert len(second) == TWO
    third = await engine.run_cycle()
    assert third == []


@pytest.mark.asyncio
async def test_open_drafts_cap_skips_cycle(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path, vault_intake_max_open_drafts=1)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    _write(inbox, "first.md", _FRONTMATTER_TAGGED)
    assert len(await engine.run_cycle()) == ONE  # fills the cap
    _write(inbox, "second.md", _INLINE_TAGGED)
    drafts = await engine.run_cycle()
    assert drafts == []
    # The unprocessed note is NOT marked seen — eligible once the cap frees.
    ledger = (await db_session.execute(select(VaultSeenNoteTable))).scalars().all()
    assert len(ledger) == ONE


@pytest.mark.asyncio
async def test_cap_frees_after_approve_and_start(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    """approve_and_start flips team to MAIN_PM — the draft leaves the cap AND
    only then enters delivery (assigned to the Main PM)."""
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path, vault_intake_max_open_drafts=1)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    _write(inbox, "a.md", _FRONTMATTER_TAGGED)
    task = (await engine.run_cycle())[0]
    task_svc = get_task_service(db_session)
    assert len(await task_svc.list_open_vault_note_drafts()) == ONE

    task.board_review_complete = True  # both reviewers done (server-side gate)
    approved = await task_svc.approve_and_start(cast("Any", task.id))
    assert approved is not None
    assert approved.team == Team.MAIN_PM
    assert approved.assigned_to == MAIN_PM_UUID  # delivery starts HERE, not before
    assert await task_svc.list_open_vault_note_drafts() == []

    _write(inbox, "b.md", _INLINE_TAGGED)
    assert len(await engine.run_cycle()) == ONE  # cap freed


@pytest.mark.asyncio
async def test_cap_frees_after_cancellation(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path, vault_intake_max_open_drafts=1)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    _write(inbox, "a.md", _FRONTMATTER_TAGGED)
    task = (await engine.run_cycle())[0]
    task_svc = get_task_service(db_session)
    assert len(await task_svc.list_open_vault_note_drafts()) == ONE

    task.status = TS.CANCELLED
    await db_session.flush()
    assert await task_svc.list_open_vault_note_drafts() == []

    _write(inbox, "b.md", _INLINE_TAGGED)
    assert len(await engine.run_cycle()) == ONE  # cap freed


# --------------------------------------------------------------------------- #
# Board-draft shape + dispatch routing (never auto-starts)
# --------------------------------------------------------------------------- #


@pytest.mark.asyncio
async def test_board_draft_shape(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "g.md", _FRONTMATTER_TAGGED)
    _mock_local_model(monkeypatch, None)
    drafts = await VaultIntakeEngine(db_session).run_cycle()
    task = drafts[0]
    assert task.status == TS.PENDING
    assert task.source == VAULT_NOTE_SOURCE
    assert task.assigned_to == PO_UUID
    assert task.team == Team.BOARD
    assert task.task_type == TaskType.PLANNING  # Main PM never owns code
    # Board-routed intake shape: confirmed like a chat-confirmed draft — the
    # board assignment + approve_and_start are the start gate, not this flag.
    assert task.confirmed_by_human is True


def _vault_task_dict(**overrides: Any) -> dict[str, Any]:
    task: dict[str, Any] = {
        "id": "11111111-2222-3333-4444-555555555555",
        "status": "pending",
        "team": "board",
        "title": "Vault note: buy milk",
        "assigned_to": str(PO_UUID),
        "source": VAULT_NOTE_SOURCE,
        "orchestration_markers": None,
    }
    task.update(overrides)
    return task


def test_vault_note_is_not_a_held_ceo_source() -> None:
    """The draft must DISPATCH (to board review) — a held-source skip would
    strand it forever (no role can pull it, no review route exists)."""
    assert _is_held_ceo_source(_vault_task_dict()) is False


@pytest.mark.asyncio
async def test_dispatch_pm_work_routes_vault_draft_to_board_review_only() -> None:
    """The PM dispatcher must hand a vault draft to the two-reviewer board
    review and NOTHING else — no PM spawn, no delivery routing."""
    stub = MagicMock()
    stub._fetch_tasks = AsyncMock(return_value=[_vault_task_dict()])
    stub._is_task_handled_this_tick = MagicMock(return_value=False)
    stub._resolve_agent_slug = MagicMock(return_value="product-owner")
    stub._BOARD_AGENTS = frozenset({"product-owner", "head-marketing"})
    stub._handle_board_assigned_task = AsyncMock()
    stub._handle_pm_assigned_task = AsyncMock()
    stub._route_unassigned_pm_task = AsyncMock()

    client: Any = MagicMock()
    await AgentOrchestrator._dispatch_pm_work(cast("AgentOrchestrator", stub), client)

    stub._handle_board_assigned_task.assert_awaited_once()
    stub._handle_pm_assigned_task.assert_not_awaited()
    stub._route_unassigned_pm_task.assert_not_awaited()


@pytest.mark.asyncio
async def test_vault_draft_never_dev_dispatched() -> None:
    """team=board fails _dev_dispatch_one's cell-team gate — a vault draft can
    never spawn a developer, with or without any source-based skip."""
    stub = MagicMock()
    stub._spawn_pending_dev = AsyncMock()
    stub._handle_dev_existing_owner = AsyncMock()

    client: Any = MagicMock()
    await AgentOrchestrator._dev_dispatch_one(
        cast("AgentOrchestrator", stub), client, _vault_task_dict()
    )

    stub._spawn_pending_dev.assert_not_awaited()
    stub._handle_dev_existing_owner.assert_not_awaited()


# --------------------------------------------------------------------------- #
# Local-model fallback
# --------------------------------------------------------------------------- #


@pytest.mark.asyncio
async def test_local_model_failure_falls_back_to_deterministic(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "h.md", _WITH_CHECKBOXES)
    monkeypatch.setattr(
        vie_module, "_chat", AsyncMock(side_effect=RuntimeError("local model down"))
    )
    drafts = await VaultIntakeEngine(db_session).run_cycle()
    task = drafts[0]
    assert "Weekend chores" in task.title
    assert "Mow the lawn" in task.acceptance_criteria
    assert "Wash the car" in task.acceptance_criteria


@pytest.mark.asyncio
async def test_local_model_success_is_used(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    _write(inbox, "i.md", _FRONTMATTER_TAGGED)
    _mock_local_model(
        monkeypatch,
        '{"title": "Milk run", "description": "Pick up milk on the way home.", '
        '"action_items": ["Buy 2% milk"]}',
    )
    drafts = await VaultIntakeEngine(db_session).run_cycle()
    task = drafts[0]
    assert "Milk run" in task.title
    assert task.description == "Pick up milk on the way home."
    assert task.acceptance_criteria == ["Buy 2% milk"]


# --------------------------------------------------------------------------- #
# Feedback callout
# --------------------------------------------------------------------------- #


@pytest.mark.asyncio
async def test_feedback_callout_appended_once(
    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch, tmp_path: Path
) -> None:
    await _seed(db_session)
    inbox = _enable(monkeypatch, tmp_path)
    path = _write(inbox, "j.md", _FRONTMATTER_TAGGED)
    _mock_local_model(monkeypatch, None)
    engine = VaultIntakeEngine(db_session)
    await engine.run_cycle()
    text = path.read_text(encoding="utf-8")
    assert text.count("RoboCo: drafted") == ONE
    # A second cycle over the now-callout-bearing (but otherwise unchanged)
    # note must not reprocess it or double the callout.
    second = await engine.run_cycle()
    assert second == []
    assert path.read_text(encoding="utf-8").count("RoboCo: drafted") == ONE