mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* fix(gateway): gate review diffs against the task's real parent branch (#444) The in-path PR-review gate's evidence diff (claim_gate_review) and the pr_pass conventions guard derived their diff base via parent_branch_for string surgery, which reuses the child branch's own team segment — wrong for every cross-team hop (a frontend child of a main_pm root derives a ref that never existed) and silently falls back to the repo default branch, so the reviewer judged the entire inherited base-branch content as the task's own work and failed acceptance criteria the task never touched. Bounced a live goals-tab fix three times, unfixable by branch surgery. The gate now resolves the base via resolve_parent_branch (the parent task's recorded branch_name, cross-team correct) and threads it as a new preferred_parent override through git.diff / list_changed_files / conventions_check_for_task — consulted only when no explicit base is given, so the pinned literal-base contract (base="HEAD~1") and every other diff caller (QA, doc, content) are byte-identical. Parent lookup fails open (derived-base fallback) like the other resolve_parent_branch call sites, and is skipped entirely while the conventions flag is off. Also excludes .uv-cache/ and .claude/ (agent worktrees, private uv cache) from the markdown prose scanner — both are repo-local tool dirs whose vendored/generated files tripped make reflow-check. Co-authored-by: Renn F <rennf93@users.noreply.github.com> * feat(vault): Obsidian vault V1 — projection core + input loop The vault is a rebuildable projection of the DB (never a source of truth), default-off behind ROBOCO_OBSIDIAN_VAULT_ENABLED + ROBOCO_VAULT_PATH. Projection core: VaultWriter materializes tasks/journals/A2A/agents as wikilinked markdown (id-suffixed stable filenames, alias-based links so renames never break, is_private journals excluded like the RAG corpus); event seams materialize on journal write and A2A send and touch task-note frontmatter at the status-transition chokepoint — all best-effort, a vault failure never blocks a verb. Shipped .obsidian config (Dataview, Kanban, team/status graph groups) + _meta dashboards; python -m roboco.vault rebuild/relocate (rebuild preserves the narrative section). Auditor narrative duty: curate_vault content verb (auditor-only, playbook-curation pattern) spawned by a dedicated root-completion hook with its own cooldown — fully separate from _dispatch_audit_work, whose scheduled-sweep/alert-producer revival belongs to the queued fleet task. Input loop: VaultIntakeEngine (ROBOCO_VAULT_INTAKE_*) watches the intake folder for #roboco-tagged notes and materializes each as ONE held draft (confirmed_by_human=False, Secretary-owned, source=vault_note, excluded by the dispatchers via _is_held_ceo_source) with local-model extraction and a deterministic fallback; vault_seen_notes ledger (migration 070) keyed on path+content-hash (the CEO-feedback callout is stripped before hashing so the engine's own append never self-triggers); per-cycle and open-draft caps. Nothing auto-starts. * fix(vault): integrate with master — re-chain migration 070 onto 069, mypy-clean tests The vault branch was cut from slave before the sequence-gate promotion, so migration 070 chained from 068 while master already carried 069 — two heads on merge. Master is now merged in and 070 revises 069. Vault test files also get mypy-clean mock idioms (monkeypatch.setattr over method assignment; await_args narrowed before access). * fix(scripts): dedupe SKIP_DIRS again after the master merge Master still carries the twin-merge duplicate (its dedupe hotfix is an unmerged PR); the merge re-imported it here. * fix(vault): reflow hard-wrapped prose in the vault asset templates * chore(config): exclude .uv-cache and .claude from deptry's scan scope Same repo-local tool dirs the prose scanner skips; the standalone deptry target walks the repo root and drowned in the cache's unpacked wheels. * fix(vault): board-review activation path for vault drafts + relocate graft The input loop's held-artifact posture was a dead end: vault_note drafts were unconditionally held by _is_held_ceo_source, owned by the verbless Secretary, hidden from the panel's approval surfaces by team, and the open-drafts cap counted them forever — the engine self-bricked after ten notes. Vault drafts now ride the intake board-review path instead: a tagged note becomes a PENDING Product-Owner-assigned Board draft (the exact confirm_live_draft board shape), the board reviews it, and only the CEO's approve_and_start makes it deliverable — never-auto-starts now rests on the board gate, proven by tests against the real dispatchers. The cap counts only drafts still awaiting the CEO (team==BOARD, non-terminal), so approval and cancellation both free it. relocate into an existing personal vault now grafts old_root/RoboCo as a direct child (refusing loudly if RoboCo/ already exists there) and adds only absent .obsidian/_meta files — a personal vault's config is never clobbered. An absent destination keeps the whole-tree move. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
371 lines
13 KiB
Python
371 lines
13 KiB
Python
"""VaultWriter — pure Obsidian-vault materializer (projection core, V1).
|
|
|
|
Entity -> markdown note (frontmatter + body). Idempotent per entity id: the
|
|
same input always yields the same file, and safe to re-run (rebuild/CLI,
|
|
retried seams). No DB/network access — callers assemble plain dataclasses
|
|
from their own service layer and hand them to this module.
|
|
|
|
Layout (``docs/internal/specs/2026-07-09-obsidian-vault.md`` §Vault layout)::
|
|
|
|
RoboCo/
|
|
Tasks/<project-slug>/<title> (<id8>).md
|
|
Journals/<agent-slug>/<date> <title> (<id8>).md
|
|
A2A/<date> <agents> (<thread-id8>).md
|
|
Agents/<slug>.md
|
|
_meta/
|
|
|
|
Link stability: every note carries ``aliases: [<id8>]`` in frontmatter, so a
|
|
cross-link is always written as ``[[<id8>|<title>]]`` — Obsidian resolves it
|
|
via the alias regardless of the target's CURRENT filename. A title edit
|
|
therefore updates the body's title line (and, for a full ``write_task``
|
|
re-render, the frontmatter) without ever renaming the file or breaking a
|
|
link elsewhere in the vault.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from dataclasses import dataclass
|
|
from pathlib import Path
|
|
from typing import TYPE_CHECKING, Any
|
|
|
|
import yaml
|
|
|
|
if TYPE_CHECKING:
|
|
from datetime import datetime
|
|
|
|
_ILLEGAL_FILENAME_CHARS = re.compile(r'[\\/:*?"<>|]')
|
|
_MAX_TITLE_LEN = 80
|
|
_NARRATIVE_PLACEHOLDER = "_Pending Auditor curation._"
|
|
_FRONTMATTER_RE = re.compile(r"\A---\n(.*?)\n---\n?", re.DOTALL)
|
|
|
|
|
|
def _safe_title(title: str) -> str:
|
|
"""Filesystem-safe, length-capped title for a filename component."""
|
|
cleaned = _ILLEGAL_FILENAME_CHARS.sub("", title or "").strip()
|
|
cleaned = re.sub(r"\s+", " ", cleaned)
|
|
return (cleaned or "untitled")[:_MAX_TITLE_LEN]
|
|
|
|
|
|
def _id8(entity_id: str) -> str:
|
|
return str(entity_id)[:8]
|
|
|
|
|
|
def _find_by_id8(directory: Path, id8: str) -> Path | None:
|
|
"""Locate an existing note by its stable id8 suffix, if the dir exists."""
|
|
if not directory.exists():
|
|
return None
|
|
matches = sorted(directory.glob(f"*({id8}).md"))
|
|
return matches[0] if matches else None
|
|
|
|
|
|
def _rfind_by_id8(root: Path, id8: str) -> Path | None:
|
|
"""Recursive variant of ``_find_by_id8`` for callers that don't know
|
|
which subfolder (e.g. project slug) a note lives under."""
|
|
if not root.exists():
|
|
return None
|
|
matches = sorted(root.rglob(f"*({id8}).md"))
|
|
return matches[0] if matches else None
|
|
|
|
|
|
def _drop_none(mapping: dict[str, Any]) -> dict[str, Any]:
|
|
return {k: v for k, v in mapping.items() if v is not None}
|
|
|
|
|
|
def _render_note(frontmatter: dict[str, Any], body: str) -> str:
|
|
fm = yaml.safe_dump(
|
|
_drop_none(frontmatter), sort_keys=False, default_flow_style=False
|
|
).strip()
|
|
return f"---\n{fm}\n---\n\n{body.rstrip()}\n"
|
|
|
|
|
|
def _split_frontmatter(text: str) -> tuple[dict[str, Any], str]:
|
|
m = _FRONTMATTER_RE.match(text)
|
|
if not m:
|
|
return {}, text
|
|
loaded = yaml.safe_load(m.group(1))
|
|
fm = loaded if isinstance(loaded, dict) else {}
|
|
return fm, text[m.end() :]
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class TaskLinkRef:
|
|
"""A wikilink target: id (any length; truncated to id8) + display title."""
|
|
|
|
id: str
|
|
title: str = ""
|
|
|
|
|
|
def _wikilink(ref: TaskLinkRef) -> str:
|
|
id8 = _id8(ref.id)
|
|
return f"[[{id8}|{ref.title}]]" if ref.title else f"[[{id8}]]"
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class TaskNoteData:
|
|
"""Deterministic content for one task note. ``narrative`` is None until
|
|
the Auditor curates it (a placeholder is rendered instead)."""
|
|
|
|
id: str
|
|
title: str
|
|
project_slug: str
|
|
description: str
|
|
status: str
|
|
team: str
|
|
priority: int
|
|
task_type: str
|
|
acceptance_criteria: tuple[str, ...] = ()
|
|
pr_number: int | None = None
|
|
pr_url: str | None = None
|
|
parent: TaskLinkRef | None = None
|
|
subtasks: tuple[TaskLinkRef, ...] = ()
|
|
dependencies: tuple[TaskLinkRef, ...] = ()
|
|
batch_id: str | None = None
|
|
narrative: str | None = None
|
|
|
|
|
|
def _task_frontmatter(data: TaskNoteData, id8: str) -> dict[str, Any]:
|
|
return {
|
|
"aliases": [id8],
|
|
"status": data.status,
|
|
"team": data.team,
|
|
"priority": data.priority,
|
|
"pr": data.pr_url or (f"#{data.pr_number}" if data.pr_number else None),
|
|
"parent": f"[[{_id8(data.parent.id)}]]" if data.parent else None,
|
|
"batch": _id8(data.batch_id) if data.batch_id else None,
|
|
"tags": [f"status/{data.status}", f"team/{data.team}"],
|
|
}
|
|
|
|
|
|
def _task_body(data: TaskNoteData) -> list[str]:
|
|
body: list[str] = [f"# {data.title}", "", (data.description or "").strip()]
|
|
if data.acceptance_criteria:
|
|
body += ["", "## Acceptance Criteria"]
|
|
body += [f"- [ ] {c}" for c in data.acceptance_criteria]
|
|
if data.parent:
|
|
body += ["", "## Parent", f"- {_wikilink(data.parent)}"]
|
|
if data.subtasks:
|
|
body += ["", "## Subtasks"]
|
|
body += [f"- {_wikilink(s)}" for s in data.subtasks]
|
|
if data.dependencies:
|
|
body += ["", "## Dependencies"]
|
|
body += [f"- {_wikilink(d)}" for d in data.dependencies]
|
|
body += ["", "## Narrative", (data.narrative or _NARRATIVE_PLACEHOLDER).strip()]
|
|
return body
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class JournalNoteData:
|
|
entry_id: str
|
|
agent_slug: str
|
|
scope: str
|
|
title: str
|
|
content: str
|
|
timestamp: datetime
|
|
task_ref: TaskLinkRef | None = None
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class A2AMessageData:
|
|
conversation_id: str
|
|
message_id: str
|
|
from_agent: str
|
|
to_agent: str
|
|
content: str
|
|
timestamp: datetime
|
|
task_ref: TaskLinkRef | None = None
|
|
|
|
|
|
@dataclass(frozen=True)
|
|
class AgentNoteData:
|
|
slug: str
|
|
name: str
|
|
role: str
|
|
team: str | None = None
|
|
|
|
|
|
class VaultWriter:
|
|
"""Pure file-system materializer, rooted at ``root`` (``ROBOCO_VAULT_PATH``)."""
|
|
|
|
def __init__(self, root: Path) -> None:
|
|
self.root = Path(root)
|
|
|
|
# --- paths ---------------------------------------------------------- #
|
|
|
|
def _tasks_root(self) -> Path:
|
|
return self.root / "RoboCo" / "Tasks"
|
|
|
|
def _journals_root(self) -> Path:
|
|
return self.root / "RoboCo" / "Journals"
|
|
|
|
def _a2a_root(self) -> Path:
|
|
return self.root / "RoboCo" / "A2A"
|
|
|
|
def _agents_root(self) -> Path:
|
|
return self.root / "RoboCo" / "Agents"
|
|
|
|
# --- tasks ------------------------------------------------------------ #
|
|
|
|
def write_task(self, data: TaskNoteData) -> Path:
|
|
"""Full deterministic materialize (create-or-overwrite). The
|
|
filename is stable across title renames — an existing note is found
|
|
by id8 and its filename reused; only a brand-new note is named from
|
|
the current title."""
|
|
id8 = _id8(data.id)
|
|
directory = self._tasks_root() / (data.project_slug or "unassigned")
|
|
directory.mkdir(parents=True, exist_ok=True)
|
|
existing = _find_by_id8(directory, id8)
|
|
filename = (
|
|
existing.name if existing else f"{_safe_title(data.title)} ({id8}).md"
|
|
)
|
|
path = directory / filename
|
|
path.write_text(
|
|
_render_note(_task_frontmatter(data, id8), "\n".join(_task_body(data))),
|
|
encoding="utf-8",
|
|
)
|
|
return path
|
|
|
|
def existing_narrative(self, project_slug: str, task_id: str) -> str | None:
|
|
"""Read back an existing note's ``## Narrative`` section so a rebuild
|
|
never clobbers Auditor-authored prose (it isn't derivable from DB
|
|
state). None when the note doesn't exist yet or still carries the
|
|
deterministic placeholder."""
|
|
directory = self._tasks_root() / (project_slug or "unassigned")
|
|
existing = _find_by_id8(directory, _id8(task_id))
|
|
if existing is None:
|
|
return None
|
|
_, body = _split_frontmatter(existing.read_text(encoding="utf-8"))
|
|
marker = "## Narrative"
|
|
idx = body.find(marker)
|
|
if idx == -1:
|
|
return None
|
|
narrative = body[idx + len(marker) :].strip()
|
|
return narrative if narrative and narrative != _NARRATIVE_PLACEHOLDER else None
|
|
|
|
def touch_task_frontmatter(
|
|
self,
|
|
*,
|
|
task_id: str,
|
|
status: str,
|
|
team: str,
|
|
pr_number: int | None,
|
|
pr_url: str | None,
|
|
) -> bool:
|
|
"""Cheap status-transition touch: patch frontmatter keys in place on
|
|
an EXISTING note, never rewriting the body/links. No-op (returns
|
|
False) when the note hasn't been materialized yet — full
|
|
materialization happens at Auditor curation / CLI rebuild, per the
|
|
vault's event-driven freshness model, so this never invents content
|
|
it doesn't have (no extra queries — just the fields on the row)."""
|
|
id8 = _id8(task_id)
|
|
path = _rfind_by_id8(self._tasks_root(), id8)
|
|
if path is None:
|
|
return False
|
|
fm, body = _split_frontmatter(path.read_text(encoding="utf-8"))
|
|
fm["status"] = status
|
|
fm["team"] = team
|
|
fm["pr"] = pr_url or (f"#{pr_number}" if pr_number else None)
|
|
fm["tags"] = [f"status/{status}", f"team/{team}"]
|
|
path.write_text(_render_note(fm, body), encoding="utf-8")
|
|
return True
|
|
|
|
# --- journals ----------------------------------------------------------- #
|
|
|
|
def write_journal_entry(self, data: JournalNoteData) -> Path:
|
|
"""One file per entry (immutable once written — always safe to
|
|
re-render the same entry id in place)."""
|
|
directory = self._journals_root() / data.agent_slug
|
|
directory.mkdir(parents=True, exist_ok=True)
|
|
id8 = _id8(data.entry_id)
|
|
date_str = data.timestamp.strftime("%Y-%m-%d")
|
|
existing = _find_by_id8(directory, id8)
|
|
filename = (
|
|
existing.name
|
|
if existing
|
|
else f"{date_str} {_safe_title(data.title)} ({id8}).md"
|
|
)
|
|
path = directory / filename
|
|
|
|
frontmatter = {
|
|
"aliases": [id8],
|
|
"agent": data.agent_slug,
|
|
"scope": data.scope,
|
|
"date": date_str,
|
|
}
|
|
body = [f"# {data.title}", ""]
|
|
if data.task_ref:
|
|
body += [f"Task: {_wikilink(data.task_ref)}", ""]
|
|
body.append((data.content or "").strip())
|
|
|
|
path.write_text(_render_note(frontmatter, "\n".join(body)), encoding="utf-8")
|
|
return path
|
|
|
|
# --- A2A ---------------------------------------------------------------- #
|
|
|
|
def append_a2a_message(self, data: A2AMessageData) -> Path:
|
|
"""Per-thread digest file, appended to on every message. Idempotent
|
|
per message id (a marker comment guards against a double-append on
|
|
retry)."""
|
|
directory = self._a2a_root()
|
|
directory.mkdir(parents=True, exist_ok=True)
|
|
id8 = _id8(data.conversation_id)
|
|
participants = sorted({data.from_agent, data.to_agent})
|
|
existing = _find_by_id8(directory, id8)
|
|
if existing is None:
|
|
date_str = data.timestamp.strftime("%Y-%m-%d")
|
|
label = "-".join(participants)
|
|
filename = f"{date_str} {_safe_title(label)} ({id8}).md"
|
|
path = directory / filename
|
|
frontmatter = {
|
|
"aliases": [id8],
|
|
"participants": participants,
|
|
"task": _wikilink(data.task_ref) if data.task_ref else None,
|
|
}
|
|
header = [
|
|
f"# A2A: {label}",
|
|
"",
|
|
"Participants: " + ", ".join(f"[[{p}]]" for p in participants),
|
|
]
|
|
if data.task_ref:
|
|
header += [f"Task: {_wikilink(data.task_ref)}"]
|
|
path.write_text(
|
|
_render_note(frontmatter, "\n".join(header)), encoding="utf-8"
|
|
)
|
|
else:
|
|
path = existing
|
|
|
|
marker = f"<!-- msg:{data.message_id} -->"
|
|
text = path.read_text(encoding="utf-8")
|
|
if marker in text:
|
|
return path
|
|
ts = data.timestamp.strftime("%H:%M:%S")
|
|
block = (
|
|
f"\n**{data.from_agent}** ({ts}) {marker}\n{(data.content or '').strip()}\n"
|
|
)
|
|
with path.open("a", encoding="utf-8") as fh:
|
|
fh.write(block)
|
|
return path
|
|
|
|
# --- agents --------------------------------------------------------------- #
|
|
|
|
def write_agent(self, data: AgentNoteData) -> Path:
|
|
"""Identity hub note; backlinks (Obsidian-native) collect this
|
|
agent's tasks/journal-entries/A2A threads — no explicit index kept
|
|
here."""
|
|
directory = self._agents_root()
|
|
directory.mkdir(parents=True, exist_ok=True)
|
|
path = directory / f"{data.slug}.md"
|
|
frontmatter = {"role": data.role, "team": data.team}
|
|
body = f"# {data.name}\n\nRole: {data.role}\nTeam: {data.team or '(none)'}\n"
|
|
path.write_text(_render_note(frontmatter, body), encoding="utf-8")
|
|
return path
|
|
|
|
|
|
def get_vault_writer() -> VaultWriter:
|
|
"""Factory reading ``settings.vault_path``. Callers gate on
|
|
``settings.obsidian_vault_enabled`` themselves (this module has no
|
|
opinion on the flag — it's a pure materializer)."""
|
|
from roboco.config import settings
|
|
|
|
return VaultWriter(Path(settings.vault_path))
|