mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
* fix(mcp): delegate tool carries the collision surface the B1a gate demands
TASK_AT_DELEGATE (5fc85419) requires intends_to_touch on code delegations,
but the MCP delegate tool never gained the parameter — PMs were rejected
with incomplete_input and could never comply (live fleet-wide delegation
wall, 2026-07-02). Adds intends_to_touch / adds_migration / touches_shared /
depends_on to the tool and forwards them; parity test locks the invariant.
* fix(git): assembly-integrity guard accepts squash-merged children
git cherry patch-matches each child commit individually, so a squash merge
(N patches -> one commit, new patch-id) read as 'work missing' and the #11
guard refused every legitimate submit_up (live 2026-07-02: S6 cell, three
squash-merged children at the branch tip). A parent commit carrying the
child's [taskid8] prefix now proves the child landed; children with no
marker stay flagged — the original incident the guard exists for.
* fix(git): diff head prefers origin when the local ref is behind it
Assembled branches advance on ORIGIN as child PRs squash-merge on GitHub,
but _resolve_head_ref preferred the inspecting clone's parked local ref —
the PR-gate reviewer's evidence diff was built from a pre-merge snapshot
and re-flagged work that had already landed (two false pr_fail verdicts
on the S6 cell PR, live 2026-07-02). When both refs exist and the local
ref is strictly behind origin, resolve to origin/<branch>; local-ahead
(unpushed) and diverged refs keep priority, single-ref cases unchanged.
* test(mcp): plan-gate fields must be tool parameters (parity class lock)
Extends the delegate parity test to every choreographer plan-depth gate:
a gate that can reject with missing=[field] must name only fields the
corresponding MCP tool can send, else the agent can never comply.
* perf(api): wire TaskSummaryResponse into a bounded /tasks/summary route
The panel fetched /api/tasks unbounded and full-fat — 2MB per refresh
measured live (2026-07-02), ~21KB/task, and the trimmed
TaskSummaryResponse was dead code. /tasks/summary returns exactly the
fields list views render (~50x lighter); the status-only branch of
/tasks now honors its limit, and the eleven unbounded task list routes
are capped.
* perf(panel): kill the per-page request flood and fat payloads
Every page load funneled ~85 default-prefetch RSC requests + 665KB of
images + the 2MB task list through the browser's six HTTP/1.1
connections — real data calls queued ~2s before being sent (measured
via Playwright resource timing, 2026-07-02).
- prefetch={false} on all 59 Links (sidebar, task rows, kanban cards,
list rows) — ~85 requests/refresh down to a handful
- icon/apple-icon/logo resized to render size: 665KB -> 54KB; unused
219KB PNG removed
- task list fetches the trimmed /tasks/summary (2MB -> ~100KB),
normalized into the Task shape so list consumers keep their types
- ReactQueryDevtools rendered only in development
* fix(api): Annotated limit defaults so direct-call tests get real ints
Query(...) positional defaults arrive as Query objects when a route
function is invoked outside the HTTP layer (integration tests call
handlers directly) and broke the new [:limit] slices.
* fix(api,panel): summary carries completed_at + board_review_complete
The metrics page computes velocity client-side from completed_at and the
CEO approval queue gates on board_review_complete — both were nulled by
the summary normalizer, so Completed Today/Week read 0 against 63 real
completions and approved-board tasks could vanish from the queue. The
queue also renders quick_context, so it fetches the full list (small,
status-scoped) via tasksApi.listFull instead of the summary.
* fix(runtime): spawn manifest workspace_path follows the task's project
_build_manifest_for_agent hardcoded the roboco project workspace for
every agent; a guard-core task's manifest claimed /data/workspaces/roboco
while the container cwd sat in the task worktree. The manifest now takes
the same _resolve_workspace_cwd the container -w uses — one resolver,
both surfaces agree by construction.
* fix(runtime): respawn breaker catches status ping-pong loops
Any status CHANGE fully reset the strike counter, so a blocked <->
in_progress oscillation — which changes status on every spawn while
advancing nothing — never tripped the gate (live 2026-07-02: 8 spawns
over two hours). A status never seen on the (agent, task) still fully
resets; a REVISITED status gets a bounded reset budget mirroring
tracing_resets, after which strikes accrue and the gate fires.
* fix(runtime): unassigned-QA dispatch spawns without pre-claiming
The transitioning pre-claim moved awaiting_qa -> claimed before the QA
agent existed; the spawned agent's claim_review/pass_review both demand
awaiting_qa, so it bounced twice and unclaimed (live 2026-07-02,
ba7b751c). Matches _spawn_assigned_qa and the external-PR reviewer
dispatch: no pre-claim, the agent claims itself via claim_review.
* fix(tests): narrow await_args before kwargs access (mypy union-attr)
* Minor upgrades
* fix(policy): team-match gate gains org-wide exemption; resume/unblock/activate now team-matched
needs_team_match sat in its permissive fallback since shipping (no
caller supplied Context.agent_team) and three PM verbs opted out
entirely — a misrouted frontend cell PM blocked, escalated, and held a
backend task through exactly that gap (live 2026-07-02). Org-wide roles
(main_pm, board, CEO, PR reviewer) are exempt so escalation handling
and root-PR gating keep working; cell-scoped roles are now enforced
wherever the caller supplies the team.
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
149 lines
4.8 KiB
TypeScript
149 lines
4.8 KiB
TypeScript
"use client";
|
|
|
|
import {
|
|
useCeoOverview,
|
|
useAuditorFlags,
|
|
useRecentActivity,
|
|
} from "@/hooks/use-dashboard";
|
|
import { useTasks } from "@/hooks/use-tasks";
|
|
import { TeamHealthCards } from "./team-health-cards";
|
|
import { KeyMetricsPanel } from "./key-metrics-panel";
|
|
import { AuditorAlertsPanel } from "./auditor-alerts-panel";
|
|
import { ActiveBlockersPanel } from "./active-blockers-panel";
|
|
import { RecentActivityFeed } from "./recent-activity-feed";
|
|
import { QuickActionsBar } from "./quick-actions-bar";
|
|
import { CeoApprovalQueue } from "./ceo-approval-queue";
|
|
import { PrReviewQueue } from "./pr-review-queue";
|
|
import { ReleaseProposalCard } from "./release-proposal-card";
|
|
import { PlaybookReviewQueue } from "./playbook-review-queue";
|
|
import { StrategySignalsPanel } from "./strategy-signals-panel";
|
|
import type { Activity } from "./activity-item";
|
|
import { Button } from "@/components/ui/button";
|
|
import { UsageOverviewPanel } from "./usage-overview-panel";
|
|
import { ScorecardOverviewPanel } from "./scorecard-overview-panel";
|
|
import { RefreshCw, Settings, AlertCircle } from "lucide-react";
|
|
import Link from "next/link";
|
|
|
|
export function CommandCenter() {
|
|
const {
|
|
data: overview,
|
|
isLoading: loadingOverview,
|
|
isError: errorOverview,
|
|
refetch: refetchOverview,
|
|
} = useCeoOverview();
|
|
const {
|
|
data: flags,
|
|
isLoading: loadingFlags,
|
|
isError: errorFlags,
|
|
refetch: refetchFlags,
|
|
} = useAuditorFlags({ resolved: false });
|
|
const {
|
|
data: tasks,
|
|
isLoading: loadingTasks,
|
|
isError: errorTasks,
|
|
refetch: refetchTasks,
|
|
} = useTasks();
|
|
const {
|
|
data: activity,
|
|
isLoading: loadingActivity,
|
|
isError: errorActivity,
|
|
refetch: refetchActivity,
|
|
} = useRecentActivity(24);
|
|
|
|
const hasError = errorOverview || errorFlags || errorTasks || errorActivity;
|
|
|
|
const handleRefresh = () => {
|
|
refetchOverview();
|
|
refetchFlags();
|
|
refetchTasks();
|
|
refetchActivity();
|
|
};
|
|
|
|
return (
|
|
<div className="space-y-6">
|
|
{/* Header */}
|
|
<div className="flex items-center justify-between">
|
|
<div>
|
|
<h1 className="text-3xl font-bold tracking-tight">
|
|
RoboCo Command Center
|
|
</h1>
|
|
<p className="text-muted-foreground">
|
|
Complete visibility into all operations
|
|
</p>
|
|
</div>
|
|
<div className="flex items-center gap-2">
|
|
<Button variant="outline" onClick={handleRefresh}>
|
|
<RefreshCw className="h-4 w-4 mr-2" />
|
|
Refresh
|
|
</Button>
|
|
<Link href="/settings" prefetch={false}>
|
|
<Button variant="ghost" size="icon">
|
|
<Settings className="h-5 w-5" />
|
|
</Button>
|
|
</Link>
|
|
</div>
|
|
</div>
|
|
|
|
{/* Error indicator */}
|
|
{hasError && (
|
|
<div className="flex items-center gap-2 rounded-md border border-destructive/50 bg-destructive/10 px-4 py-2 text-sm text-destructive">
|
|
<AlertCircle className="h-4 w-4 shrink-0" />
|
|
Some data failed to load. Click Refresh to try again.
|
|
</div>
|
|
)}
|
|
|
|
{/* Team Health */}
|
|
<section>
|
|
<h2 className="text-lg font-semibold mb-4">Team Health</h2>
|
|
<TeamHealthCards
|
|
teams={overview?.health_status}
|
|
isLoading={loadingOverview}
|
|
/>
|
|
</section>
|
|
|
|
{/* Quick Actions — placed immediately after Team Health so it is
|
|
visible without scrolling on a 900px-tall viewport, before the
|
|
data-heavy grid rows below. */}
|
|
<section>
|
|
<h2 className="text-lg font-semibold mb-4">Quick Actions</h2>
|
|
<QuickActionsBar />
|
|
</section>
|
|
|
|
{/* CEO Approval Queue + Strategy Signals - side-by-side on lg+ */}
|
|
<div className="grid grid-cols-1 lg:grid-cols-2 gap-6">
|
|
<CeoApprovalQueue />
|
|
<StrategySignalsPanel />
|
|
</div>
|
|
|
|
{/* External-PR review decision queue (hidden when empty) */}
|
|
<PrReviewQueue />
|
|
|
|
{/* Gated release proposal (hidden when none open) */}
|
|
<ReleaseProposalCard />
|
|
|
|
{/* Playbook review queue (hidden when no drafts) */}
|
|
<PlaybookReviewQueue />
|
|
|
|
{/* Metrics, Alerts, Usage, and Performance Row */}
|
|
<div className="grid grid-cols-1 lg:grid-cols-2 xl:grid-cols-4 gap-6">
|
|
<KeyMetricsPanel
|
|
metrics={overview?.key_metrics}
|
|
isLoading={loadingOverview}
|
|
/>
|
|
<AuditorAlertsPanel alerts={flags} isLoading={loadingFlags} />
|
|
<UsageOverviewPanel />
|
|
<ScorecardOverviewPanel />
|
|
</div>
|
|
|
|
{/* Blockers and Activity Row */}
|
|
<div className="grid grid-cols-1 lg:grid-cols-2 xl:grid-cols-2 2xl:grid-cols-2 gap-6">
|
|
<ActiveBlockersPanel tasks={tasks} isLoading={loadingTasks} />
|
|
<RecentActivityFeed
|
|
activities={activity as Activity[] | undefined}
|
|
isLoading={loadingActivity}
|
|
/>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|