mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
82 lines
2.7 KiB
Python
82 lines
2.7 KiB
Python
"""Python definition-kind classification (tree-sitter), precision-over-recall."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from roboco.conventions.classify_python import classify_definitions
|
|
|
|
|
|
def test_pydantic_model_is_classified_model() -> None:
|
|
src = b"from pydantic import BaseModel\nclass UserCreate(BaseModel):\n x: int\n"
|
|
defs = classify_definitions(src)
|
|
assert ("UserCreate", 2, "model") in defs
|
|
|
|
|
|
def test_dotted_base_model_is_classified_model() -> None:
|
|
defs = classify_definitions(b"class M(pydantic.BaseModel):\n pass\n")
|
|
assert defs == [("M", 1, "model")]
|
|
|
|
|
|
def test_sqlalchemy_declarative_base_is_model() -> None:
|
|
defs = classify_definitions(b"class Account(Base):\n pass\n")
|
|
assert defs == [("Account", 1, "model")]
|
|
|
|
|
|
def test_router_decorated_function_is_route() -> None:
|
|
src = b"@router.get('/x')\ndef list_x():\n return 1\n"
|
|
defs = classify_definitions(src)
|
|
assert defs == [("list_x", 2, "route")]
|
|
|
|
|
|
def test_app_post_decorated_function_is_route() -> None:
|
|
src = b"@app.post('/y')\ndef create_y():\n return 1\n"
|
|
assert classify_definitions(src) == [("create_y", 2, "route")]
|
|
|
|
|
|
def test_blueprint_get_decorated_function_is_route() -> None:
|
|
# Any object with an HTTP-method attribute counts as a route handler.
|
|
src = b"@bp.delete('/z')\ndef drop_z():\n return 1\n"
|
|
assert classify_definitions(src) == [("drop_z", 2, "route")]
|
|
|
|
|
|
def test_plain_function_is_helper() -> None:
|
|
assert classify_definitions(b"def helper():\n pass\n") == [
|
|
("helper", 1, "helper")
|
|
]
|
|
|
|
|
|
def test_non_route_decorated_function_is_helper() -> None:
|
|
# A decorator that is not an HTTP route still leaves a plain function.
|
|
src = b"@functools.cache\ndef compute():\n return 1\n"
|
|
assert classify_definitions(src) == [("compute", 2, "helper")]
|
|
|
|
|
|
def test_ambiguous_class_abstains_to_other() -> None:
|
|
assert classify_definitions(b"class Thing:\n pass\n") == [("Thing", 1, "other")]
|
|
|
|
|
|
def test_class_with_unknown_base_abstains() -> None:
|
|
assert classify_definitions(b"class Widget(Gadget):\n pass\n") == [
|
|
("Widget", 1, "other")
|
|
]
|
|
|
|
|
|
def test_multiple_top_level_defs_in_order() -> None:
|
|
src = (
|
|
b"from pydantic import BaseModel\n"
|
|
b"class Req(BaseModel):\n x: int\n"
|
|
b"@router.put('/u')\ndef upd():\n return 1\n"
|
|
b"def util():\n pass\n"
|
|
)
|
|
defs = classify_definitions(src)
|
|
assert defs == [
|
|
("Req", 2, "model"),
|
|
("upd", 5, "route"),
|
|
("util", 7, "helper"),
|
|
]
|
|
|
|
|
|
def test_nested_defs_are_not_top_level() -> None:
|
|
# Only module-level definitions are classified (precision).
|
|
src = b"def outer():\n def inner():\n pass\n return inner\n"
|
|
assert classify_definitions(src) == [("outer", 1, "helper")]
|