mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
107 lines
2.8 KiB
Python
107 lines
2.8 KiB
Python
"""The project_conventions_cache table round-trips JSONB and enforces uniqueness."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import TYPE_CHECKING
|
|
from uuid import uuid4
|
|
|
|
import pytest
|
|
from roboco.db.tables import (
|
|
AgentTable,
|
|
ProjectConventionsCacheTable,
|
|
ProjectTable,
|
|
)
|
|
from roboco.models import AgentRole, AgentStatus, Team
|
|
from sqlalchemy import select
|
|
from sqlalchemy.exc import IntegrityError
|
|
|
|
if TYPE_CHECKING:
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
|
|
async def _seed_project(db: AsyncSession) -> ProjectTable:
|
|
agent = AgentTable(
|
|
id=uuid4(),
|
|
name="Dev",
|
|
slug=f"be-dev-{uuid4().hex[:8]}",
|
|
role=AgentRole.DEVELOPER,
|
|
team=Team.BACKEND,
|
|
status=AgentStatus.ACTIVE,
|
|
model_config={},
|
|
system_prompt="dev",
|
|
capabilities=[],
|
|
permissions={},
|
|
metrics={},
|
|
)
|
|
db.add(agent)
|
|
await db.flush()
|
|
project = ProjectTable(
|
|
id=uuid4(),
|
|
name="C-Proj",
|
|
slug=f"c-proj-{uuid4().hex[:8]}",
|
|
git_url="https://example.com/r.git",
|
|
assigned_cell=Team.BACKEND,
|
|
created_by=agent.id,
|
|
)
|
|
db.add(project)
|
|
await db.flush()
|
|
return project
|
|
|
|
|
|
async def test_cache_row_round_trips_jsonb(db_session: AsyncSession) -> None:
|
|
project = await _seed_project(db_session)
|
|
row = ProjectConventionsCacheTable(
|
|
id=uuid4(),
|
|
project_id=project.id,
|
|
commit_sha="abc1234",
|
|
effective_map={
|
|
"version": 1,
|
|
"rules": {
|
|
"no_models_in_routers": {
|
|
"name": "no_models_in_routers",
|
|
"level": "block",
|
|
}
|
|
},
|
|
},
|
|
status="ok",
|
|
)
|
|
db_session.add(row)
|
|
await db_session.flush()
|
|
await db_session.refresh(row)
|
|
|
|
fetched = (
|
|
await db_session.execute(
|
|
select(ProjectConventionsCacheTable).where(
|
|
ProjectConventionsCacheTable.project_id == project.id
|
|
)
|
|
)
|
|
).scalar_one()
|
|
assert fetched.status == "ok"
|
|
assert fetched.effective_map["rules"]["no_models_in_routers"]["level"] == "block"
|
|
assert fetched.derived_at is not None
|
|
|
|
|
|
async def test_project_sha_uniqueness_is_enforced(db_session: AsyncSession) -> None:
|
|
project = await _seed_project(db_session)
|
|
db_session.add(
|
|
ProjectConventionsCacheTable(
|
|
id=uuid4(),
|
|
project_id=project.id,
|
|
commit_sha="dup",
|
|
effective_map={},
|
|
status="ok",
|
|
)
|
|
)
|
|
await db_session.flush()
|
|
db_session.add(
|
|
ProjectConventionsCacheTable(
|
|
id=uuid4(),
|
|
project_id=project.id,
|
|
commit_sha="dup",
|
|
effective_map={},
|
|
status="ok",
|
|
)
|
|
)
|
|
with pytest.raises(IntegrityError):
|
|
await db_session.flush()
|