mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
16789c1ca7
* feat(conventions): standard schema models + effective-map merge * feat(conventions): tree-sitter Python classifier + placement checks * feat(conventions): TS classifier, hygiene/custom checks, runner + CLI * feat(conventions): ROBOCO_CONVENTIONS_ENABLED flag + cache table + migration * feat(conventions): repo auto-scan + scaffold draft renderer * feat(conventions): ConventionsService (cache/baseline/ambient/scaffold/restore) * feat(conventions): auto-scaffold on project registration (flag-gated) * feat(conventions): TaskDescription.constraints + auto-baseline attach * feat(conventions): ambient architecture-map injection at spawn * test(conventions): subprocess CLI smoke for the agent-image entrypoint * feat(conventions): block i_am_done on block-level convention violations * feat(conventions): block pr_pass on unresolved convention violations * feat(conventions): surface convention findings into QA evidence * docs(prompts): convention awareness for PO/Intake/Dev/QA/PR-reviewer * feat(conventions): panel Conventions tab + flag toggle + parity * test(conventions): end-to-end block, fix, and waiver through the gate * refactor(conventions): extract pr_pass guards to keep pr_gate under the gate * style(conventions): format the baseline-constraints attach in task.create * test(conventions): type-annotate test helpers for the full mypy gate * build(conventions): ignore types-PyYAML in deptry (mypy-only type stub) * docs(conventions): document the standard in CLAUDE.md + PM prompt awareness * fix(conventions): baseline constraints are non-suppressible (dedup-append) * feat(conventions): scaffold on first workspace clone (threaded workspace) * feat(conventions): multi-project ambient map for PO/Intake (per-product) * feat(conventions): persist findings + violations-feed route (migration 044) * feat(conventions): panel violations feed in the Conventions tab * test(conventions): intake-spawn mock accepts the ambient layer kwarg * fix(docker): ollama-init best-effort pull, gate startup on cached models present A degraded/slow ollama registry made the model manifest re-check fail under set -e, so ollama-init exited 1 and blocked the orchestrator's service_completed_successfully gate — taking the whole stack down even though both models were already cached. Pulls are now best-effort; success is gated on the models being present, so a flaky registry can't down a cached deployment. * refactor(content): drop dead TaskDescription.with_baseline_constraints The structured baseline-merge helper had zero production callers. Project-task baseline constraints are attached by the wired string backstop (TaskService._attach_baseline_constraints), and a real task is free-form prose that cannot form a valid TaskDescription (requires a non-trivial objective + non-empty the_work), so the helper was unreachable from any live path — a leftover from the structured-merge -> string-append design pivot. Removing it leaves a single enforcement path. The constraints field itself stays: it is a member of the well-formed-spec schema (Objective / What This Builds / The Work / Notes / Constraints / Acceptance Criteria), rendered by render_markdown and unit-tested. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
64 lines
2.2 KiB
Python
64 lines
2.2 KiB
Python
"""Add the project_convention_findings table (violations feed).
|
|
|
|
Persists architectural-conventions validator findings per task so the panel
|
|
can show recent block/warn violations across a project. Pure schema change;
|
|
no backfill. Inert until ``ROBOCO_CONVENTIONS_ENABLED``.
|
|
|
|
Revision ID: 044_convention_findings
|
|
Revises: 043_conventions_cache
|
|
Create Date: 2026-06-22
|
|
|
|
NOTE: revision id is 23 chars — alembic's ``alembic_version.version_num`` is
|
|
``VARCHAR(32)`` and a longer id raises at record time.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sqlalchemy as sa
|
|
from alembic import op
|
|
|
|
revision = "044_convention_findings"
|
|
down_revision = "043_conventions_cache"
|
|
branch_labels = None
|
|
depends_on = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
op.create_table(
|
|
"project_convention_findings",
|
|
sa.Column("id", sa.UUID(as_uuid=True), nullable=False),
|
|
sa.Column("project_id", sa.UUID(as_uuid=True), nullable=False),
|
|
sa.Column("task_id", sa.UUID(as_uuid=True), nullable=True),
|
|
sa.Column("file", sa.String(length=500), nullable=False),
|
|
sa.Column("line", sa.Integer(), nullable=False),
|
|
sa.Column("rule", sa.String(length=100), nullable=False),
|
|
sa.Column("level", sa.String(length=20), nullable=False),
|
|
sa.Column("kind", sa.String(length=40), nullable=True),
|
|
sa.Column("message", sa.Text(), nullable=False),
|
|
sa.Column("detected_at", sa.DateTime(timezone=True), nullable=False),
|
|
sa.ForeignKeyConstraint(["project_id"], ["projects.id"], ondelete="CASCADE"),
|
|
sa.PrimaryKeyConstraint("id"),
|
|
)
|
|
op.create_index(
|
|
"ix_project_convention_findings_project_id",
|
|
"project_convention_findings",
|
|
["project_id"],
|
|
)
|
|
op.create_index(
|
|
"ix_project_convention_findings_detected_at",
|
|
"project_convention_findings",
|
|
["detected_at"],
|
|
)
|
|
|
|
|
|
def downgrade() -> None:
|
|
op.drop_index(
|
|
"ix_project_convention_findings_detected_at",
|
|
table_name="project_convention_findings",
|
|
)
|
|
op.drop_index(
|
|
"ix_project_convention_findings_project_id",
|
|
table_name="project_convention_findings",
|
|
)
|
|
op.drop_table("project_convention_findings")
|