mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
e9ca7d4036
* feat(gateway): delegation detail-fidelity — details survive hand-off, both directions
Details thinned out at every delegation hop: a PM child task mapped to no
parent criterion was legal (coverage only surfaced at submit_up, after the
whole wave ran — a 12-subtask docs tree grew through 8 review rounds that
way, one child titled 'docs page and route wrapper' shipping only the
page), and QA could pass work on a gestalt read (a 4-scene video brief
shipped 3 scenes past every gate because the features existed only in
prose). Three chokepoint gates:
- delegate (down): every child must declare covers_parent_criteria
resolving against the parent's real acceptance criteria — no mapping or
an unresolvable ref rejects naming every offending child and the valid
criteria; the success envelope carries parent_ac_coverage
{covered, uncovered} so a wave-planning PM sees remaining gaps in the
same turn. Full coverage stays enforced at submit_up (waves stay legal).
- pass_review (up): mandatory criteria_verified — one {criterion,
evidence} entry per task AC, matched by the findings ledger's
id-or-exact-text matcher, evidence soup-checked and capped; rejects
naming the unverified criteria; entries render deterministically into
qa_notes as '[AC] <criterion> — verified: <evidence>' lines. The old
count-only ac_verdicts gate is superseded (arg kept for back-compat).
- video briefs (structured detail at origination): an enumerable feature
list (release highlights, or input_props.highlights carried onto a
reject re-author) becomes its own scene acceptance criterion, bounded to
the AC caps; a re-author without highlights carries the
feedback-addressed criterion instead.
Extracted findings.py's criterion matcher into shared unmatched_criteria /
uncovered_acceptance_criteria instead of duplicating it; criteria_verified
joins the WAF free-text exclusion set like findings/issues.
* fix(gateway): break the block/unblock wedge — four hardening fixes from the live PM loop
A cell task looped fe-pm/main-pm block/unblock for hours (10 cycles, 43
spawns): a transient GitHub API error resolving CI became an unwaivable
blocker finding whose own fix text said no code change was required, the
submit freshness guard then demanded a commit no finding called for,
escalate_up auto-blocked, and main-pm's correct recovery plan 422'd on
the approach length cap, degrading it to a bare unblock. Four fixes:
- pr_pass CI-unresolvable refusal is now explicitly transient-worded:
retry pr_pass shortly, do NOT pr_fail over a CI-status lookup error —
a platform blip is not a code finding
- submit freshness guard grants ONE unchanged-head resubmission per
head sha when the findings ledger has zero open rows (all addressed
without code changes) — stamped via the resubmit_unchanged_head
marker so the same head can never loop a second time
- unblock carries a flip breaker: block_flip_count marker, and at the
third flip a one-shot CEO notification flags the task as structurally
wedged (unblock itself still succeeds — the breaker signals, it does
not wedge recovery)
- i_will_plan's approach cap truncates at 800 chars instead of
rejecting — an over-detailed plan must never cost the PM its turn
---------
Co-authored-by: Renn F <rennf93@users.noreply.github.com>
2.2 KiB
2.2 KiB
Verbs available to you (autogenerated source of truth)
Flow verbs
| Verb | Body schema |
|---|---|
claim_review |
claim_review(task_id: UUID) |
fail_review |
`fail_review(task_id: UUID, issues: list[str] = PydanticUndefined, findings: list[str |
give_me_work |
give_me_work() |
i_am_blocked |
`i_am_blocked(task_id: UUID, reason: str, blocker_type: str |
i_am_idle |
i_am_idle() |
pass_review |
`pass_review(task_id: UUID, notes: str, ac_verdicts: list[str] |
resume |
resume(task_id: UUID) |
unclaim |
unclaim(task_id: UUID) |
Content (do) tools
| Tool | Body schema |
|---|---|
note |
`note(text: str, scope: str = 'note', task_id: UUID |
dm |
`dm(recipient: str, text: str, task_id: UUID |
evidence |
evidence(task_id: UUID) |
draft_playbook |
`draft_playbook(title: str, problem: str, procedure: str, tags: list[str] = PydanticUndefined, source_task_id: UUID |
request_sandbox |
`request_sandbox(services: list[str] |
request_render |
`request_render(composition_id: str |
notify_list |
notify_list(unread_only: bool = True, pending_ack_only: bool = False, limit: int = 20) |
notify_get |
notify_get(notification_id: UUID) |
notify_ack |
notify_ack(notification_id: UUID) |
read_messages |
read_messages() |
read_a2a |
read_a2a(see do_server) |