Delegation detail-fidelity + PM-loop hardening (#541)

* feat(gateway): delegation detail-fidelity — details survive hand-off, both directions Details thinned out at every delegation hop: a PM child task mapped to no parent criterion was legal (coverage only surfaced at submit_up, after the whole wave ran — a 12-subtask docs tree grew through 8 review rounds that way, one child titled 'docs page and route wrapper' shipping only the page), and QA could pass work on a gestalt read (a 4-scene video brief shipped 3 scenes past every gate because the features existed only in prose). Three chokepoint gates: - delegate (down): every child must declare covers_parent_criteria resolving against the parent's real acceptance criteria — no mapping or an unresolvable ref rejects naming every offending child and the valid criteria; the success envelope carries parent_ac_coverage {covered, uncovered} so a wave-planning PM sees remaining gaps in the same turn. Full coverage stays enforced at submit_up (waves stay legal). - pass_review (up): mandatory criteria_verified — one {criterion, evidence} entry per task AC, matched by the findings ledger's id-or-exact-text matcher, evidence soup-checked and capped; rejects naming the unverified criteria; entries render deterministically into qa_notes as '[AC] <criterion> — verified: <evidence>' lines. The old count-only ac_verdicts gate is superseded (arg kept for back-compat). - video briefs (structured detail at origination): an enumerable feature list (release highlights, or input_props.highlights carried onto a reject re-author) becomes its own scene acceptance criterion, bounded to the AC caps; a re-author without highlights carries the feedback-addressed criterion instead. Extracted findings.py's criterion matcher into shared unmatched_criteria / uncovered_acceptance_criteria instead of duplicating it; criteria_verified joins the WAF free-text exclusion set like findings/issues. * fix(gateway): break the block/unblock wedge — four hardening fixes from the live PM loop A cell task looped fe-pm/main-pm block/unblock for hours (10 cycles, 43 spawns): a transient GitHub API error resolving CI became an unwaivable blocker finding whose own fix text said no code change was required, the submit freshness guard then demanded a commit no finding called for, escalate_up auto-blocked, and main-pm's correct recovery plan 422'd on the approach length cap, degrading it to a bare unblock. Four fixes: - pr_pass CI-unresolvable refusal is now explicitly transient-worded: retry pr_pass shortly, do NOT pr_fail over a CI-status lookup error — a platform blip is not a code finding - submit freshness guard grants ONE unchanged-head resubmission per head sha when the findings ledger has zero open rows (all addressed without code changes) — stamped via the resubmit_unchanged_head marker so the same head can never loop a second time - unblock carries a flip breaker: block_flip_count marker, and at the third flip a one-shot CEO notification flags the task as structurally wedged (unblock itself still succeeds — the breaker signals, it does not wedge recovery) - i_will_plan's approach cap truncates at 800 chars instead of rejecting — an over-detailed plan must never cost the PM its turn --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
2026-08-03 07:23:24 +02:00 · 2026-07-17 01:52:33 +02:00
parent 028b11871b
commit e9ca7d4036
34 changed files with 1823 additions and 140 deletions
@@ -36,6 +36,9 @@ ONE = 1
 TWO = 2
 THREE = 3
 FOUR = 4
+FIVE = 5
+SEVEN = 7
+_AC_ITEM_CHAR_CAP = 200  # mirrors task_completeness._AC_MAX_ITEM_CHARS


 async def _seed(session: AsyncSession) -> None:
@@ -896,3 +899,152 @@ async def test_reauthor_from_rejection_missing_draft_returns_none(

    result = await engine.reauthor_from_rejection(task, "some reason")
    assert result is None
+
+
+# --------------------------------------------------------------------------- #
+# scene criterion — a brief-named feature list becomes its own gate-checkable
+# AC (delegation detail-fidelity: prose feature counts used to pass gates
+# even when a dev shipped fewer scenes than the brief named)
+# --------------------------------------------------------------------------- #
+
+
+@pytest.mark.asyncio
+async def test_draft_release_video_carries_scene_criterion_for_highlights(
+    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    await _seed(db_session)
+    _enable(monkeypatch, video_on_release=True)
+    _mock_local_model(monkeypatch, "shipped!")
+    engine = video_engine_module.VideoEngine(db_session)
+    task = await engine.draft_release_video(version="1.0.0", changelog=_CHANGELOG)
+    assert task is not None
+    assert len(task.acceptance_criteria) == FIVE
+    scene_ac = task.acceptance_criteria[FOUR]
+    assert scene_ac.startswith("Every brief-named feature appears as its own")
+    assert "a huge new release" in scene_ac
+
+
+@pytest.mark.asyncio
+async def test_open_video_task_no_highlights_keeps_ac_count_unchanged(
+    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    await _seed(db_session)
+    _enable(monkeypatch)
+    engine = video_engine_module.VideoEngine(db_session)
+    task = await engine.open_video_task(
+        occasion="spotlight no-highlights",
+        script="s",
+        platforms=["x"],
+        brief="b",
+        suggested_input_props={"version": "1.0.0"},  # no "highlights" key
+    )
+    assert task is not None
+    assert len(task.acceptance_criteria) == FOUR  # no scene criterion appended
+
+
+@pytest.mark.asyncio
+async def test_reauthor_from_rejection_with_highlights_regenerates_scene_criterion(
+    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    await _seed(db_session)
+    _enable(monkeypatch)
+    engine = video_engine_module.VideoEngine(db_session)
+    source_task = await engine.open_video_task(
+        occasion="release v3.0.0",
+        script="s",
+        platforms=["x"],
+        brief="b",
+        suggested_input_props={
+            "version": "3.0.0",
+            "highlights": ["Feature A", "Feature B"],
+        },
+    )
+    assert source_task is not None
+    draft = markers.get_video_draft(source_task) or {}
+    # Simulate propose_video: the dev's real input_props carries the same
+    # highlights forward onto the marker.
+    markers.set_video_draft(
+        source_task,
+        {
+            **draft,
+            "composition_id": "ReleaseIntro",
+            "input_props": {
+                "version": "3.0.0",
+                "highlights": ["Feature A", "Feature B"],
+            },
+        },
+    )
+    source_task.status = TS.COMPLETED
+    await db_session.flush()
+
+    post_task = await engine._originate_video_post(
+        source_task=source_task,
+        mp4_paths={"vertical": "a.mp4", "square": "b.mp4"},
+        captions={"x": "cap"},
+        platforms=["x"],
+    )
+    post_task.status = TS.CANCELLED
+    await db_session.flush()
+
+    revision = await engine.reauthor_from_rejection(post_task, "Logo too small")
+    assert revision is not None
+    assert len(revision.acceptance_criteria) == FIVE
+    scene_ac = revision.acceptance_criteria[FOUR]
+    assert "Feature A" in scene_ac
+    assert "Feature B" in scene_ac
+
+
+@pytest.mark.asyncio
+async def test_reauthor_from_rejection_without_highlights_adds_feedback_criterion(
+    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    await _seed(db_session)
+    _enable(monkeypatch)
+    engine = video_engine_module.VideoEngine(db_session)
+    source_task = await engine.open_video_task(
+        occasion="release v4.0.0", script="s", platforms=["x"], brief="b"
+    )
+    assert source_task is not None
+    draft = markers.get_video_draft(source_task) or {}
+    markers.set_video_draft(source_task, {**draft, "composition_id": "Intro"})
+    source_task.status = TS.COMPLETED
+    await db_session.flush()
+
+    post_task = await engine._originate_video_post(
+        source_task=source_task,
+        mp4_paths={"vertical": "a.mp4", "square": "b.mp4"},
+        captions={"x": "cap"},
+        platforms=["x"],
+    )
+    post_task.status = TS.CANCELLED
+    await db_session.flush()
+
+    revision = await engine.reauthor_from_rejection(post_task, "Logo is cut off")
+    assert revision is not None
+    assert len(revision.acceptance_criteria) == FIVE
+    assert revision.acceptance_criteria[FOUR] == (
+        "Every point in the CEO rejection feedback is visibly addressed in "
+        "the rendered cut"
+    )
+
+
+@pytest.mark.asyncio
+async def test_open_video_task_scene_criterion_truncates_pathological_feature_list(
+    db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
+) -> None:
+    await _seed(db_session)
+    _enable(monkeypatch)
+    engine = video_engine_module.VideoEngine(db_session)
+    features = [f"Feature number {i}" for i in range(50)]
+    task = await engine.open_video_task(
+        occasion="release pathological",
+        script="s",
+        platforms=["x"],
+        brief="b",
+        suggested_input_props={"highlights": features},
+    )
+    assert task is not None
+    assert len(task.acceptance_criteria) <= SEVEN
+    scene_ac = task.acceptance_criteria[-1]
+    assert len(scene_ac) <= _AC_ITEM_CHAR_CAP
+    assert "more)" in scene_ac  # truncated, not silently dropped