fix(rag): migrate chunks_* tables to in-house vector-store schema

The in-house RAG engine (which replaced piragi) reads/writes a `content`
column and a `created_at` column on every chunks_<index_type> table and
provisions them at runtime via CREATE TABLE IF NOT EXISTS. On databases that
already carried the piragi-era tables (column `text`, no `created_at`) that
DDL is a silent no-op, so the engine never reshapes them and every
ingest/search/list fails with `column "content" ... does not exist`.

Migration 030 ALTERs each existing chunk table in place — renames
text -> content and adds created_at — preserving the non-rebuildable agent
knowledge (journals, decisions, errors, learnings, reviews, conversations)
that a docs reindex cannot regenerate. It guards on actual column presence,
so it is idempotent and safe on piragi-shaped, already-correct, or absent
tables (e.g. chunks_code).

Adds a guard test pinning the migration's table list to the IndexType enum so
a new index type cannot silently escape the schema alignment.
This commit is contained in:
Renn F
2026-06-15 03:43:05 +02:00
parent 0039e2a7ee
commit 996ef56ac3
2 changed files with 156 additions and 0 deletions
@@ -0,0 +1,96 @@
"""Align RAG chunk tables with the in-house vector-store schema.
The in-house vector store (which replaced piragi) reads and writes a ``content``
column and a ``created_at`` column on every ``chunks_<index_type>`` table, and
provisions those tables at runtime with ``CREATE TABLE IF NOT EXISTS``. On a
database that already carried the piragi-era tables column named ``text``, no
``created_at`` that runtime DDL is a silent no-op, so the new engine never
reshapes them and every ingest/search/list fails with
``column "content" of relation "chunks_<type>" does not exist``.
These tables hold derived chunks AND non-rebuildable agent knowledge
(journals, decisions, errors, learnings, reviews, conversations) that a docs
reindex cannot regenerate, so this migration ALTERs in place renaming
``text`` -> ``content`` and adding ``created_at`` rather than dropping data.
The legacy ``chunk_index`` / integer ``id`` columns are left untouched: the
engine never references them and dropping them would be a needless destructive
change.
Both directions guard on actual column presence, so the migration is idempotent
and safe whether a table is piragi-shaped, already engine-shaped, or absent
(e.g. ``chunks_code``, which has never been populated and will be created fresh
in the correct shape by the engine).
Revision ID: 030_rag_chunks_content_schema
Revises: 029_project_quality_command
Create Date: 2026-06-15
"""
from __future__ import annotations
from typing import TYPE_CHECKING
import sqlalchemy as sa
from alembic import op
if TYPE_CHECKING:
from sqlalchemy.engine import Inspector
revision = "030_rag_chunks_content_schema"
down_revision = "029_project_quality_command"
branch_labels = None
depends_on = None
# Frozen snapshot of the chunk tables — one per ``IndexType`` value at the time
# of writing. Hardcoded so the migration stays self-contained and never imports
# evolving application code; a unit test guards this tuple against the live
# ``IndexType`` enum so a newly added index type cannot silently escape the
# schema alignment.
CHUNK_TABLES = (
"chunks_code",
"chunks_documentation",
"chunks_conversations",
"chunks_journals",
"chunks_errors",
"chunks_standards",
"chunks_decisions",
"chunks_reviews",
"chunks_learnings",
)
def _columns(inspector: Inspector, table: str) -> set[str]:
"""Return the set of column names currently present on ``table``."""
return {col["name"] for col in inspector.get_columns(table)}
def upgrade() -> None:
inspector = sa.inspect(op.get_bind())
for table in CHUNK_TABLES:
if not inspector.has_table(table):
continue
cols = _columns(inspector, table)
if "text" in cols and "content" not in cols:
op.alter_column(table, "text", new_column_name="content")
if "created_at" not in cols:
op.add_column(
table,
sa.Column(
"created_at",
sa.TIMESTAMP(timezone=True),
nullable=False,
server_default=sa.text("NOW()"),
),
)
def downgrade() -> None:
inspector = sa.inspect(op.get_bind())
for table in CHUNK_TABLES:
if not inspector.has_table(table):
continue
cols = _columns(inspector, table)
if "created_at" in cols:
op.drop_column(table, "created_at")
if "content" in cols and "text" not in cols:
op.alter_column(table, "content", new_column_name="text")
@@ -0,0 +1,60 @@
"""Guard the 030 chunk-schema migration against IndexType drift.
The migration that aligns the ``chunks_<index_type>`` tables with the in-house
vector store hardcodes the table list (so it stays self-contained and never
imports evolving app code). This test is the other half of that contract: it
fails the moment a new ``IndexType`` is added without extending the migration,
which is exactly the gap that let the piragi-era ``text`` columns survive the
engine swap and break every ingest/search.
"""
from __future__ import annotations
import importlib.util
from pathlib import Path
from typing import TYPE_CHECKING
import pytest
from roboco.models.optimal import IndexType
if TYPE_CHECKING:
from types import ModuleType
def _repo_root() -> Path:
for parent in Path(__file__).resolve().parents:
if (parent / "alembic" / "versions").is_dir():
return parent
raise RuntimeError("could not locate alembic/versions from the test file")
@pytest.fixture(scope="module")
def migration() -> ModuleType:
path = _repo_root() / "alembic" / "versions" / "030_rag_chunks_content_schema.py"
spec = importlib.util.spec_from_file_location("_migration_030", path)
assert spec is not None and spec.loader is not None
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)
return module
def test_chunk_tables_match_index_type_enum(migration: ModuleType) -> None:
expected = {f"chunks_{t.value}" for t in IndexType}
assert set(migration.CHUNK_TABLES) == expected, (
"CHUNK_TABLES is out of sync with IndexType — a new index type was added "
"without extending the 030 chunk-schema migration."
)
def test_chunk_tables_has_no_duplicates(migration: ModuleType) -> None:
assert len(migration.CHUNK_TABLES) == len(set(migration.CHUNK_TABLES))
def test_revision_chain_is_wired(migration: ModuleType) -> None:
assert migration.revision == "030_rag_chunks_content_schema"
assert migration.down_revision == "029_project_quality_command"
def test_upgrade_and_downgrade_are_callable(migration: ModuleType) -> None:
assert callable(migration.upgrade)
assert callable(migration.downgrade)