External/roboco
1
0
Fork 0
mirror of https://github.com/rennf93/roboco.git synced 2026-08-03 07:23:24 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor(gateway): rename submit_for_qa to open_pr; pin atomic preconditions

Browse Source 
Pre-fix, submit_for_qa opened a PR (side effect) and returned OK with
next='call i_am_done' — agents read the verb name, assumed they were
done with QA handoff, never called i_am_done, and PRs ended up
orphaned (PR #12 in the 2026-05-08 trace).

Two changes:

1. Rename submit_for_qa -> open_pr so the verb name matches the
   semantic. The PR opens here; the actual QA handoff happens at
   i_am_done. Renamed across:
   - choreographer/_impl.py (method)
   - mcp/flow_server.py (tool registration + _TOOLS dict)
   - api/routes/v2/flow_dev.py (route + handler)
   - api/schemas/v2/flow.py (OpenPrRequest)
   - services/gateway/verb_gates.py (_STATE_VERBS)
   - services/gateway/role_config.py (developer flow manifest)
   - services/gateway/content_actions.py (commit-success next= hint)
   - agent_sdk/server.py (post-tool guidance map)
   - runtime/orchestrator.py (developer prompt)
   - agents/prompts/{base,roles/developer,_generated/*}.md
   - tests/unit/gateway/test_submit_for_qa.py -> test_open_pr.py
   - tests/unit/api/routes/v2/test_flow_dev.py
   - tests/unit/gateway/test_verb_gates.py
   - tests/unit/api/test_correlation_id.py
   - tests/unit/mcp_servers/test_flow_server.py
   - tests/integration/test_full_lifecycle_real_db.py

2. New regression test (test_open_pr_does_not_create_pr_if_no_commits)
   pins the atomic invariant: preconditions (assignee, commits,
   no-prior-PR) must be checked BEFORE git.create_pr/push_branch run.
   Any future re-ordering breaks the test.

Tests: 3128 passing (3127 + 1 new), 100% coverage, ruff clean.

Note: TaskService.submit_for_qa() (the v1-layer service method) is
INTENTIONALLY not renamed — it's a different layer used by the v1
routes. The rename here is only the gateway verb surface.
This commit is contained in:
Renn F
2026-05-08 11:54:31 +02:00
parent 2eeefb2ee1
commit 6806516015
20 changed files with 125 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/api/routes/v2/test_flow_dev.py
+5 -5
View File
@@ -157,20 +157,20 @@ def test_i_am_blocked_rejects_empty_reason() -> None:
@pytest.mark.asyncio
async def test_submit_for_qa_dispatches_task_id() -> None:
"""POST submit_for_qa forwards task_id."""
async def test_open_pr_dispatches_task_id() -> None:
"""POST open_pr forwards task_id."""
mock_chore = MagicMock()
mock_chore.submit_for_qa = AsyncMock(
mock_chore.open_pr = AsyncMock(
return_value=_make_envelope(status="awaiting_qa", task_id=_TASK_ID)
)
client = TestClient(_build_app(mock_chore))
resp = client.post(
"/api/v2/flow/developer/submit_for_qa",
"/api/v2/flow/developer/open_pr",
json={"task_id": _TASK_ID},
headers=_HEADERS,
)
assert resp.status_code == _HTTP_200
mock_chore.submit_for_qa.assert_awaited_once()
mock_chore.open_pr.assert_awaited_once()
@pytest.mark.asyncio