mirror of
https://github.com/rennf93/roboco.git
synced 2026-08-03 07:23:24 +02:00
feat(board): Board Programs — the complete twelve-program catalog (Phases 1-3) (#699)
* feat(board): Pest Control — the first project-scoped Board Program The Product Owner hunts latent defects (what the org records but nobody reads): a weekly cycle — accelerated off-schedule when the trailing-7-day rework rate crosses pest_rework_threshold, with the cheap dedup/scope gates evaluated before the metrics queries — opens one held exploration task against the least-recently-explored opted-in project (deterministic round-robin; opted_in_projects gains a stable ORDER BY), with server- assembled evidence in the spawn prompt (rework hotspots, recurring-findings and waived-minor ledger aggregates, all capped) plus prior-cycle LEARN context. The PO calls the new PO-only propose_bug_hunt verb once: ≤5 items, evidence required per item, targets validated against pest_control participation. CEO decides per item — approve materializes a BACKLOG task (source pest_control, never auto-starts), reject records the reason; both feed the LEARN ledger by exploration task id; all-terminal completes the cycle. Telegram queue pushes carry working Approve/Reject handlers mirroring the roadmap kind. Doctrine: board.md Pest Control section + product-owner verb entry + regenerated verb tables. * feat(panel): Pest Control review queue Command Center gains the pest review queue (per-item approve/reject with reason, mirroring the roadmap queue); the Programs card and the project settings participates-in checkboxes pick the new program up registry-driven — the settings section renders for the first time now that a project-scoped program exists. * feat(board): Periscope — HoM market-research brief program Weekly org-scoped cycle: a solo HoM spawn researches the market (web research with mandatory source URLs — uncited findings are rejected) and files one structured brief via the new HoM-only propose_market_brief verb: headline, cited findings, threats/opportunities, positioning note, all soup-checked and screened through the injection guard at persist time (web-derived text later reaches prompts; flags recorded, content never dropped). A brief is a report, not a proposal: the verb completes the exploration in the same call (the x_feature asymmetry), the cycle ledger auto-closes, and the CEO gets a best-effort notification with no approve/reject surface (periscope deliberately never joins Telegram's action kinds). The latest brief is injected into the roadmap exploration prompt — Periscope feeds Printer, the first cross-role program input. * feat(panel): Market Briefs tab (read-only) Business page gains a Market Briefs tab listing Periscope briefs — headline, cited findings, threats/opportunities — read-only by design; a report has nothing to approve. * feat(board): Coroner — event-triggered Auditor postmortems The first EVENT program: no cron — three best-effort hooks open an autopsy when a task bounces to its 3rd revision (the audit chokepoint), is cancelled after work started, or is budget-blocked; all gated on arming + one-open-autopsy dedup, none can fail the underlying transition. A solo Auditor spawn reads the incident (server-assembled findings + transition context) and files one propose_postmortem: incident summary, root cause, failed stage (validated against the real status vocabulary), and ONE process change — a playbook-kind change drafts via PlaybookService directly into the normal pending-curation queue; the briefed draft_playbook manifest grant was deliberately NOT added, preserving the existing 'auditor curates but never drafts' invariant test. Complete-at-propose (report asymmetry), cycle ledger auto-closes, CEO notified link-only. Integrated as a union with Periscope across the shared program surfaces. * feat(panel): Coroner postmortems card Read-only postmortems list under Business → Programs — incident, root cause, failed stage, process change; nothing to approve, the process-change artifact (a draft playbook) rides the existing curation queue. * feat(board): Sentinel — Auditor drift-watch quality reports Weekly org-scoped cycle: a solo Auditor spawn receives a server-assembled drift context (waived-findings trend, open findings by severity, conventions-violation hotspots, top spend — all capped, pure ORM) and files one propose_quality_report: headline, 1-7 area-validated items with evidence and suggested actions, overall assessment. Report semantics — complete-at-propose, cycle auto-closes, CEO notified display-only (never on Telegram's approve/reject surface); items are structured so a later convert-to-task control is cheap. Integration adopts Sentinel's module- level dict-dispatch for board-program routing (xenon-driven), folding all prior programs in; app router mounting extracted to a helper for the same budget. * feat(panel): Quality Reports tab (read-only) Business page gains the Sentinel quality-reports tab — headline, per-area observations with evidence and suggested actions; read-only, a report has nothing to approve. * feat(board): Spackle — gap-fill audit program Biweekly project-scoped PO cycle over the half-shipped surface area: API routes without panel surfaces (and vice versa), armed flags without docs, docs promises the code doesn't keep, dead-end tabs — the inventory diffing is the PO's own read-tool work, ordered by the spawn prompt with file:line citations required; the server injects only prior-cycle LEARN and the rotation target. Rotation is now a shared module-level helper (pick_rotation_target, parameterized by source) both project-scoped engines use — pest_control delegates to it, behavior-identical, with a cross-pollution test proving the two programs' rotations stay independent. propose_gap_fill mirrors the bug-hunt verb (≤5 items, two-sided evidence required, participation gate); per-item CEO decide materializes BACKLOG source=spackle tasks; full Telegram kind incl. approve/reject handlers. All seven program routers now mount from one helper. * feat(panel): Spackle gap-fill review queue Command Center gains the gap-fill queue mirroring the pest-control one — per-item approve/reject with the two-sided gap evidence rendered. * feat(board): Scales — monthly portfolio rebalance Org-scoped PO cycle over the stale backlog: the spawn receives a capped stale-task snapshot (BACKLOG/PENDING unclaimed >30 days) plus the charter and prior-cycle LEARN, and files one propose_rebalance — 1-7 items, each a resolvable task_ref with action reprioritize (validated new priority) or cancel, rationale required. Per-item CEO decide: approve EXECUTES the action (audited priority update, or the normal cancel path) — the first program whose materializer mutates existing tasks instead of creating them; reject records the reason; LEARN by exploration task id; all-terminal completes the cycle. Full Telegram decide-kind wiring. Integrated as the eight-program union (registry, dict dispatch, routers helper, teardown enumerations). * feat(panel): Scales rebalance review queue Command Center gains the rebalance queue — per-item approve/reject with the action, target task, and rationale rendered. * feat(board): Mirror — quarterly positioning audit Project-scoped HoM cycle over messaging surfaces: README claims vs shipped reality, docs-site promises vs code, charter alignment — the audit is the HoM's own read-tool work with citations required; the server injects the charter, prior-cycle LEARN, and the shared rotation target. propose_ messaging_fixes mirrors the gap-fill verb (≤5 items, drift evidence naming claim + contradicting reality, participation gate); per-item CEO decide materializes BACKLOG source=mirror documentation tasks; full Telegram decide-kind wiring. Nine-program union across the shared surfaces. * feat(panel): Mirror messaging-fixes review queue * feat(board): Megaphone — HoM standing editorial calendar Cron cycle (3 days, org-scoped, gated on X credentials — drafting content nobody can post is pointless): the HoM receives a shipped-this-week digest plus Unreleased changelog bullets and files one propose_editorial_post (angle-validated, ≤280, brand voice) that materializes a held x_editorial draft through the SAME X-queue origination chokepoint release posts use — zero new approval surface, notifications and CEO decide for free. Complete-at-propose; cycle auto-closes. Ten-program union. * feat(panel): x_editorial source labels in the X queue surfaces * feat(board): Librarian — proactive playbook mining Biweekly org-scoped Auditor cycle: mines recurring non-private learning journals (≥2-count grouping with a recency fallback) against the existing playbook-title inventory and files one propose_playbook_drafts — 1-3 drafts, each with the repeated-pattern evidence that justifies it, duplicate titles rejected in-batch and against the live store. Drafts are created via PlaybookService directly (the Coroner precedent — the 'auditor curates but never drafts' do-verb invariant stays intact and tested) and land in the normal pending-curation queue the Auditor's own triage already surfaces; no new panel surface. Complete-at-propose; display-only CEO notification. Eleven-program union. * feat(board): War Room — release campaign planning EVENT program with a REAL originator (unlike coroner's stub): a release publish hooks a campaign brief beside the release-post seam, and the CEO's run-now originates on demand — the cron loop never fires it. The HoM designs a 2-6 post arc (teaser → launch → follow-up → spotlight; 280-cap, future strictly-ascending publish_after, stage vocabulary) and one propose_campaign call materializes each post as a held x_campaign draft through the X-queue chokepoint. V1 is manual-cadence by design: publish_ after renders as queue guidance and the CEO approves each post at its moment — nothing auto-posts, ever; the auto-schedule upgrade is a documented ceiling. Twelve-program union: full registry complete. * feat(panel): x_campaign labels + publish-after guidance in the X queue * feat(board): Barfly — adjacent-conversation replies Cron cycle (2 days, org-scoped, X-credentials gated): the engine searches X for conversations where RoboCo is relevant but unmentioned (new OAuth- signed search_recent on the client; queries + candidate cap configurable), screens every fetched tweet through the injection guard (stored unclamped — a clamp was truncating the candidate under the envelope, caught by the dev's own tests), dedupes via the existing x_seen_mentions ledger (no migration; also prevents double-drafting against the mentions poll), and opens one held HoM exploration carrying the screened candidates. propose_ conversation_replies enforces candidate-id-only replies (≤5, 280-cap); each materializes a held x_barfly draft through the X-queue chokepoint, threaded via a new in_reply_to seam on post_tweet that only x_barfly drafts use. The X redraft machinery is now dict-dispatch over per-source extractors with reply-ref carry for x_barfly. Thirteen-program registry. War Room's test fakes gained the new abstract search_recent stub. * feat(board): Dogfood — the PO walks the product The fourteenth and final registry entry, completing the catalog. EVENT program (release-publish hook beside the war-room hook + CEO run-now, both through the same real originator; the cron loop never fires it), project- scoped with shared rotation. The permission surface is the careful part: the PO's dogfood spawn — and ONLY that spawn — gets the Playwright MCP mounted, via a task-scoped fail-closed probe mirroring the video-authoring precedent (a PO spawned for roadmap/pest/scales never sees browser tools; tested both ways); the PM agent image bakes chromium unconditionally like the ux image, the mount stays task-gated in code. The walk targets the rotation target's live surfaces (panel_base_url only when the target is the org's own project, honest degradation otherwise); propose_friction_ fixes files ≤5 walked-path-evidenced items; per-item CEO decide materializes BACKLOG source=dogfood tasks; full Telegram decide kind. Also: megaphone/librarian/war_room arming keys restored to the settings validator — their panel toggles would have been rejected (dropped in earlier unions; the same silent-arming class the drill killed once already). * feat(panel): Dogfood friction review queue * chore(board): final whole-branch sweep fixes The night's closing adversarial pass over the integrated fourteen-program registry found ONE functional defect — the war-room test fakes' post_tweet predated Barfly's in_reply_to_tweet_id kwarg (LSP violation, the only red in an otherwise fully green gate) — plus doc/test drift, all fixed: the source-parity test completes to fourteen (spackle/mirror were silently absent while its neighboring comment claimed full coverage), the PO identity doc gains its missing Dogfood verb, the auditor quick-list gains propose_postmortem, three stale comments corrected (rotation docstring, panel registry header, X source enumerations), the dogfood release-hook gains the exception-swallow test its four sibling hooks already had, and the CHANGELOG's Unreleased section documents the whole Board Programs train. Full make quality: exit 0, all gates green. * docs: full documentation sweep for the Board Programs train CLAUDE.md's roadmap-engine entry superseded by the Board Program registry entry (all fourteen programs, arming, scoping, LEARN, guardrails) with the role verb tables and playwright row refreshed; docs/rag gains the agent- facing architecture doc plus full propose_* call-shape sections in the three board role docs, and corrects the strategy-engine section to shipped reality (only idle→roadmap is wired); docs/map covers the registry + all twelve engines with flags, gotchas, and drift notes. The 0.27.0 reference inventory confirmed only the release-executor's canonical set carries the version — left for the 0.28.0 cut. * feat(board): human titles + descriptions on every program surface Raw registry keys rendered as bare panel labels — an operator reading x_feature had no idea what enabling or running it does. The registry dataclass gains title/description (test-enforced non-empty for every entry, unique titles), the API passes them through, and every surface renders title-with-description-tooltip instead of the key: the Programs card (label, toggle hint, run-now toast), and the project settings participates-in/excluded-from checkboxes. --------- Co-authored-by: Renn F <rennf93@users.noreply.github.com>
This commit is contained in:
@@ -11,7 +11,7 @@ from __future__ import annotations
|
||||
from contextlib import contextmanager
|
||||
from datetime import UTC, datetime, timedelta
|
||||
from typing import TYPE_CHECKING, cast
|
||||
from unittest.mock import AsyncMock, patch
|
||||
from unittest.mock import AsyncMock, MagicMock, patch
|
||||
from uuid import UUID, uuid4
|
||||
|
||||
import pytest
|
||||
@@ -31,6 +31,7 @@ from roboco.foundation.policy.content import markers
|
||||
from roboco.models.base import (
|
||||
AgentRole,
|
||||
AgentStatus,
|
||||
Complexity,
|
||||
TaskNature,
|
||||
TaskType,
|
||||
Team,
|
||||
@@ -39,10 +40,13 @@ from roboco.models.base import TaskStatus as TS
|
||||
from roboco.services import x_engine as x_engine_module
|
||||
from roboco.services.company_goals import get_company_goals_service
|
||||
from roboco.services.task import (
|
||||
MEGAPHONE_SOURCE,
|
||||
X_EDITORIAL_SOURCE,
|
||||
X_FEATURE_EXPLORATION_SOURCE,
|
||||
X_FEATURE_SOURCE,
|
||||
X_POST_SOURCE,
|
||||
X_REPLY_SOURCE,
|
||||
TaskCreateRequest,
|
||||
get_task_service,
|
||||
)
|
||||
from roboco.services.x_client import MAX_TWEET_CHARS, XClient, XMention, XPostResult
|
||||
@@ -74,7 +78,10 @@ class _FakeClient(XClient):
|
||||
def configured(self) -> bool:
|
||||
return True
|
||||
|
||||
async def post_tweet(self, text: str) -> XPostResult:
|
||||
async def post_tweet(
|
||||
self, text: str, *, in_reply_to_tweet_id: str | None = None
|
||||
) -> XPostResult:
|
||||
_ = in_reply_to_tweet_id
|
||||
self.posted.append(text)
|
||||
return XPostResult(posted=True, tweet_id="1", detail="ok")
|
||||
|
||||
@@ -84,14 +91,20 @@ class _FakeClient(XClient):
|
||||
_ = (since_id, max_results)
|
||||
return self._mentions
|
||||
|
||||
async def search_recent(self, query: str, max_results: int) -> list[XMention]:
|
||||
_ = (query, max_results)
|
||||
return []
|
||||
|
||||
|
||||
class _NullClient(XClient):
|
||||
@property
|
||||
def configured(self) -> bool:
|
||||
return False
|
||||
|
||||
async def post_tweet(self, text: str) -> XPostResult:
|
||||
_ = text
|
||||
async def post_tweet(
|
||||
self, text: str, *, in_reply_to_tweet_id: str | None = None
|
||||
) -> XPostResult:
|
||||
_ = (text, in_reply_to_tweet_id)
|
||||
return XPostResult(posted=False, tweet_id=None, detail="no creds")
|
||||
|
||||
async def fetch_mentions(
|
||||
@@ -100,6 +113,10 @@ class _NullClient(XClient):
|
||||
_ = (since_id, max_results)
|
||||
return []
|
||||
|
||||
async def search_recent(self, query: str, max_results: int) -> list[XMention]:
|
||||
_ = (query, max_results)
|
||||
return []
|
||||
|
||||
|
||||
async def _seed(session: AsyncSession) -> None:
|
||||
for uuid, slug, role, team in (
|
||||
@@ -1037,6 +1054,225 @@ async def test_materialize_feature_spotlight_enforces_280_chars(
|
||||
assert len(body) <= MAX_TWEET_CHARS
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------- #
|
||||
# materialize_editorial_post — Megaphone (Board Program). XEngine has no
|
||||
# "open" method for this exploration source (that's MegaphoneEngine's job,
|
||||
# a different service); build the held exploration task directly, mirroring
|
||||
# test_board_program_engine.py's ``_make_exploration`` helper.
|
||||
# --------------------------------------------------------------------------- #
|
||||
|
||||
|
||||
async def _make_megaphone_exploration(session: AsyncSession) -> TaskTable:
|
||||
project = (
|
||||
await session.execute(select(ProjectTable).where(ProjectTable.slug == SLUG))
|
||||
).scalar_one()
|
||||
return await get_task_service(session).create(
|
||||
TaskCreateRequest(
|
||||
title="Megaphone editorial cycle",
|
||||
description="x",
|
||||
acceptance_criteria=["propose once"],
|
||||
team=Team.BOARD,
|
||||
assigned_to=HOM_UUID,
|
||||
created_by=SYSTEM_UUID,
|
||||
task_type=TaskType.ADMINISTRATIVE,
|
||||
nature=TaskNature.NON_TECHNICAL,
|
||||
estimated_complexity=Complexity.LOW,
|
||||
project_id=cast("UUID", project.id),
|
||||
status=TS.PENDING,
|
||||
source=MEGAPHONE_SOURCE,
|
||||
confirmed_by_human=False,
|
||||
)
|
||||
)
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_materialize_editorial_post_holds_draft_and_completes_exploration(
|
||||
db_session: AsyncSession,
|
||||
) -> None:
|
||||
await _seed(db_session)
|
||||
exploration = await _make_megaphone_exploration(db_session)
|
||||
|
||||
draft = await x_engine_module.XEngine(db_session).materialize_editorial_post(
|
||||
exploration_task=exploration,
|
||||
angle="dev_log",
|
||||
body="This week the fleet shipped MegaTask waves and a PR-review gate.",
|
||||
rationale="Dev-log cadence keeps the audience close to real shipping.",
|
||||
)
|
||||
|
||||
assert draft.source == X_EDITORIAL_SOURCE
|
||||
assert draft.assigned_to == SECRETARY_UUID
|
||||
assert draft.confirmed_by_human is False
|
||||
assert draft.status == TS.PENDING
|
||||
ref = markers.get_x_editorial_ref(draft)
|
||||
assert ref is not None
|
||||
assert ref["angle"] == "dev_log"
|
||||
assert (
|
||||
ref["rationale"] == "Dev-log cadence keeps the audience close to real shipping."
|
||||
)
|
||||
body = markers.get_x_draft_body(draft)
|
||||
assert body is not None
|
||||
assert "MegaTask" in body
|
||||
|
||||
# The exploration task itself is completed as a side effect...
|
||||
assert exploration.status == TS.COMPLETED
|
||||
# ...and therefore excluded from the open-cycle list on the next query.
|
||||
still_open = await get_task_service(db_session).list_open_megaphone_cycles()
|
||||
assert still_open == []
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_materialize_editorial_post_enforces_280_chars(
|
||||
db_session: AsyncSession,
|
||||
) -> None:
|
||||
await _seed(db_session)
|
||||
exploration = await _make_megaphone_exploration(db_session)
|
||||
|
||||
draft = await x_engine_module.XEngine(db_session).materialize_editorial_post(
|
||||
exploration_task=exploration,
|
||||
angle="other",
|
||||
body="z" * 500, # a runaway HoM-authored draft
|
||||
rationale="testing the clamp",
|
||||
)
|
||||
body = markers.get_x_draft_body(draft)
|
||||
assert body is not None
|
||||
assert len(body) <= MAX_TWEET_CHARS
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_materialize_editorial_post_reuses_the_same_notify_path_as_x_post(
|
||||
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
"""Zero new approval surface (spec): an editorial draft fires the exact
|
||||
SAME ``notify_ceo_of_queue_item(kind='xpost', ...)`` chokepoint a release
|
||||
post does — mirrors ``test_originate_post_sends_telegram_push``."""
|
||||
await _seed(db_session)
|
||||
exploration = await _make_megaphone_exploration(db_session)
|
||||
notify = AsyncMock()
|
||||
monkeypatch.setattr(
|
||||
"roboco.services.notification_delivery.NotificationDeliveryService."
|
||||
"notify_ceo_of_queue_item",
|
||||
notify,
|
||||
)
|
||||
|
||||
draft = await x_engine_module.XEngine(db_session).materialize_editorial_post(
|
||||
exploration_task=exploration,
|
||||
angle="behind_scenes",
|
||||
body="Here's how the fleet actually plans a release week.",
|
||||
rationale="Process transparency builds trust.",
|
||||
)
|
||||
|
||||
notify.assert_awaited_once()
|
||||
assert notify.await_args is not None
|
||||
_args, kwargs = notify.await_args
|
||||
assert kwargs["kind"] == "xpost"
|
||||
assert kwargs["id8"] == str(draft.id)[:8]
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------- #
|
||||
# materialize_barfly_reply — the propose_conversation_replies chokepoint call
|
||||
# (spec: "materializes a held X draft through the same _originate_post
|
||||
# chokepoint"). Unlike materialize_feature_spotlight this never touches the
|
||||
# exploration task's own status — the verb completes it once, after every
|
||||
# item in the batch has materialized.
|
||||
# --------------------------------------------------------------------------- #
|
||||
|
||||
_BARFLY_CANDIDATE = {
|
||||
"id": "111",
|
||||
"author_handle": "someone",
|
||||
"text": "we should build a multi-agent coding org",
|
||||
"engagement_note": "3 combined likes/replies/retweets",
|
||||
}
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_materialize_barfly_reply_holds_draft_through_originate_post(
|
||||
db_session: AsyncSession,
|
||||
) -> None:
|
||||
await _seed(db_session)
|
||||
project = (
|
||||
await db_session.execute(select(ProjectTable).where(ProjectTable.slug == SLUG))
|
||||
).scalar_one()
|
||||
engine = x_engine_module.XEngine(db_session, client=_FakeClient())
|
||||
|
||||
class _Exploration:
|
||||
project_id = project.id
|
||||
|
||||
draft = await engine.materialize_barfly_reply(
|
||||
exploration_task=cast("TaskTable", _Exploration()),
|
||||
candidate=_BARFLY_CANDIDATE,
|
||||
reply_body="That's exactly what request_sandbox() gives you.",
|
||||
rationale="Directly answers their question.",
|
||||
)
|
||||
|
||||
assert draft.source == "x_barfly"
|
||||
assert draft.assigned_to == SECRETARY_UUID
|
||||
assert draft.confirmed_by_human is False
|
||||
assert draft.status == TS.PENDING
|
||||
ref = markers.get_barfly_reply_ref(draft)
|
||||
assert ref is not None
|
||||
assert ref["tweet_id"] == "111"
|
||||
assert ref["author_handle"] == "someone"
|
||||
assert ref["rationale"] == "Directly answers their question."
|
||||
body = markers.get_x_draft_body(draft)
|
||||
assert body == "That's exactly what request_sandbox() gives you."
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_materialize_barfly_reply_enforces_280_chars(
|
||||
db_session: AsyncSession,
|
||||
) -> None:
|
||||
await _seed(db_session)
|
||||
project = (
|
||||
await db_session.execute(select(ProjectTable).where(ProjectTable.slug == SLUG))
|
||||
).scalar_one()
|
||||
engine = x_engine_module.XEngine(db_session, client=_FakeClient())
|
||||
|
||||
class _Exploration:
|
||||
project_id = project.id
|
||||
|
||||
draft = await engine.materialize_barfly_reply(
|
||||
exploration_task=cast("TaskTable", _Exploration()),
|
||||
candidate=_BARFLY_CANDIDATE,
|
||||
reply_body="z" * 500,
|
||||
rationale="whatever",
|
||||
)
|
||||
body = markers.get_x_draft_body(draft)
|
||||
assert body is not None
|
||||
assert len(body) <= MAX_TWEET_CHARS
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_materialize_barfly_reply_sends_telegram_push(
|
||||
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
"""Proves the shared _originate_post chokepoint's Telegram push fires
|
||||
for the barfly source too — same seam every other X draft rides."""
|
||||
await _seed(db_session)
|
||||
project = (
|
||||
await db_session.execute(select(ProjectTable).where(ProjectTable.slug == SLUG))
|
||||
).scalar_one()
|
||||
engine = x_engine_module.XEngine(db_session, client=_FakeClient())
|
||||
notify = AsyncMock()
|
||||
monkeypatch.setattr(
|
||||
"roboco.services.x_engine.get_notification_delivery_service",
|
||||
lambda _s: MagicMock(notify_ceo_of_queue_item=notify),
|
||||
)
|
||||
|
||||
class _Exploration:
|
||||
project_id = project.id
|
||||
|
||||
await engine.materialize_barfly_reply(
|
||||
exploration_task=cast("TaskTable", _Exploration()),
|
||||
candidate=_BARFLY_CANDIDATE,
|
||||
reply_body="A real reply.",
|
||||
rationale="whatever",
|
||||
)
|
||||
notify.assert_awaited_once()
|
||||
call = notify.await_args
|
||||
assert call is not None
|
||||
assert call.kwargs["kind"] == "xpost"
|
||||
|
||||
|
||||
# --------------------------------------------------------------------------- #
|
||||
# redraft_from_rejection — CEO reject feedback loop (mirrors VideoEngine.
|
||||
# reauthor_from_rejection). ``post_task.status = TS.CANCELLED`` below mirrors
|
||||
@@ -1157,6 +1393,42 @@ async def test_redraft_from_rejection_feature_carries_feature_ref(
|
||||
assert await engine.is_feature_seen("org-memory") is True
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_redraft_from_rejection_barfly_carries_reply_ref(
|
||||
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
) -> None:
|
||||
"""A rejected x_barfly draft's redraft keeps replying to the SAME
|
||||
tweet — losing barfly_reply_ref would silently turn a threaded reply
|
||||
into a standalone tweet on the next approve."""
|
||||
await _seed(db_session)
|
||||
project = (
|
||||
await db_session.execute(select(ProjectTable).where(ProjectTable.slug == SLUG))
|
||||
).scalar_one()
|
||||
engine = x_engine_module.XEngine(db_session, client=_FakeClient())
|
||||
|
||||
class _Exploration:
|
||||
project_id = project.id
|
||||
|
||||
post_task = await engine.materialize_barfly_reply(
|
||||
exploration_task=cast("TaskTable", _Exploration()),
|
||||
candidate=_BARFLY_CANDIDATE,
|
||||
reply_body="Original reply.",
|
||||
rationale="whatever",
|
||||
)
|
||||
post_task.status = TS.CANCELLED
|
||||
await db_session.flush()
|
||||
|
||||
_mock_local_model(monkeypatch, "A sharper reply.")
|
||||
with _redraft_lock_free():
|
||||
redraft = await engine.redraft_from_rejection(post_task, "Too generic")
|
||||
assert redraft is not None
|
||||
assert redraft.source == "x_barfly"
|
||||
ref = markers.get_barfly_reply_ref(redraft)
|
||||
assert ref is not None
|
||||
assert ref["tweet_id"] == "111"
|
||||
assert markers.get_x_draft_body(redraft) == "A sharper reply."
|
||||
|
||||
|
||||
@pytest.mark.asyncio
|
||||
async def test_redraft_from_rejection_local_model_failure_originates_nothing(
|
||||
db_session: AsyncSession, monkeypatch: pytest.MonkeyPatch
|
||||
|
||||
Reference in New Issue
Block a user