External/powershell-scripts
1
0
Fork 0
mirror of https://github.com/admindroid-community/powershell-scripts.git synced 2025-12-17 08:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update TrackOffboardedM365UserActivities.ps1

Browse Source 
- Moved $null to the left side of the equality for safe comparison
- Remove unused variables
This commit is contained in:
Yoanndp 2024-12-18 15:41:54 +01:00
parent 529426933e
commit d1413263f4
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
Track offboarded user activities/TrackOffboardedM365UserActivities.ps1
View File

@ -74,7 +74,7 @@ Write-Host Connecting to Exchange Online...
#Retrive audit log for the past 180 days
if(($StartDate -eq $null) -and ($EndDate -eq $null))
if(($null -eq $StartDate) -and ($null -eq $EndDate))
{
$EndDate=(Get-Date).Date
$StartDate=$MaxStartDate
@ -82,7 +82,7 @@ if(($StartDate -eq $null) -and ($EndDate -eq $null))
#Getting start date to audit export report
While($true)
{
if ($StartDate -eq $null)
if ($null -eq $StartDate)
{
$StartDate=Read-Host Enter start time for report generation '(Eg:12/15/2023)'
}
@ -109,7 +109,7 @@ While($true)
#Getting end date to export audit report
While($true)
{
if ($EndDate -eq $null)
if ($null -eq $EndDate)
{
$EndDate=Read-Host Enter End time for report generation '(Eg: 12/15/2023)'
}
@ -146,8 +146,6 @@ if($UserID -eq "")
$UserID=Read-Host Enter user UPN '(eg:John@contoso.com)'
}
Write-host ~~~~~~~~
$AggregateResults = @()
$CurrentResult= @()
$CurrentResultCount=0
$AggregateResultCount=0
Write-Host `nRetrieving user activity log from $StartDate to $EndDate... -ForegroundColor Yellow
@ -164,7 +162,6 @@ while($true)
#Getting audit log for given time range
$Results=Search-UnifiedAuditLog -StartDate $CurrentStart -EndDate $CurrentEnd -UserIds $UserID -SessionId s -SessionCommand ReturnLargeSet -ResultSize 5000
$ResultCount=($Results | Measure-Object).count
$AllAuditData=@()
foreach($Result in $Results)
{
$Count++
@ -195,7 +192,6 @@ while($true)
[DateTime]$CurrentStart=$CurrentEnd
[DateTime]$CurrentEnd=$CurrentStart.AddMinutes($IntervalTimeInMinutes)
$CurrentResultCount=0
$CurrentResult = @()
if($CurrentEnd -gt $EndDate)
{
$CurrentEnd=$EndDate
@ -224,7 +220,6 @@ while($true)
}
$CurrentEnd=$CurrentStart.AddMinutes($IntervalTimeInMinutes)
$CurrentResultCount=0
$CurrentResult = @()
if($CurrentEnd -gt $EndDate)
{
$CurrentEnd=$EndDate