mirror of
https://github.com/Portabase/portabase.git
synced 2026-07-14 11:16:13 +02:00
fix: coderabbit review fixed(typo, url validation, and unique ping key
This commit is contained in:
@@ -18,7 +18,7 @@ const BaseChannelFormSchema = z.object({
|
|||||||
name: z
|
name: z
|
||||||
.string()
|
.string()
|
||||||
.min(5, "Name must be at least 5 characters long")
|
.min(5, "Name must be at least 5 characters long")
|
||||||
.max(40, "Name e at most 40 characters long"),
|
.max(40, "Name must be at most 40 characters long"),
|
||||||
enabled: z.boolean().default(true),
|
enabled: z.boolean().default(true),
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|||||||
@@ -5,7 +5,7 @@ export const BlobChannelConfigSchema = z.object({
|
|||||||
accountKey: z.string().optional(),
|
accountKey: z.string().optional(),
|
||||||
connectionString: z.string().optional(),
|
connectionString: z.string().optional(),
|
||||||
containerName: z.string().min(1, "Container name is required"),
|
containerName: z.string().min(1, "Container name is required"),
|
||||||
endpointUrl: z.string().optional(),
|
endpointUrl: z.string().url("Endpoint URL must be a valid URL").optional(),
|
||||||
}).refine(
|
}).refine(
|
||||||
(data) => data.accountKey || data.connectionString,
|
(data) => data.accountKey || data.connectionString,
|
||||||
{message: "Either account key or connection string is required"}
|
{message: "Either account key or connection string is required"}
|
||||||
|
|||||||
@@ -128,11 +128,14 @@ export async function pingBlob(config: BlobConfig): Promise<StorageResult> {
|
|||||||
provider: "blob",
|
provider: "blob",
|
||||||
response: "Container does not exist"
|
response: "Container does not exist"
|
||||||
};
|
};
|
||||||
const key = `${BASE_DIR}ping.txt`;
|
const key = `${BASE_DIR}ping-${Date.now()}-${Math.random().toString(36).slice(2)}.txt`;
|
||||||
const blockBlobClient = containerClient.getBlockBlobClient(key);
|
const blockBlobClient = containerClient.getBlockBlobClient(key);
|
||||||
await blockBlobClient.upload(Buffer.from("ping"), 4);
|
try {
|
||||||
await blockBlobClient.download();
|
await blockBlobClient.upload(Buffer.from("ping"), 4);
|
||||||
await blockBlobClient.delete();
|
await blockBlobClient.download();
|
||||||
|
} finally {
|
||||||
|
await blockBlobClient.delete().catch(() => undefined);
|
||||||
|
}
|
||||||
|
|
||||||
return {
|
return {
|
||||||
success: true,
|
success: true,
|
||||||
|
|||||||
Reference in New Issue
Block a user