fix: coderabbit review fixed(typo, url validation, and unique ping key

This commit is contained in:
jingi
2026-06-19 14:45:24 -07:00
parent 1dfd0c2e56
commit c34d8c5532
3 changed files with 9 additions and 6 deletions
+1 -1
View File
@@ -18,7 +18,7 @@ const BaseChannelFormSchema = z.object({
name: z
.string()
.min(5, "Name must be at least 5 characters long")
.max(40, "Name e at most 40 characters long"),
.max(40, "Name must be at most 40 characters long"),
enabled: z.boolean().default(true),
});
+1 -1
View File
@@ -5,7 +5,7 @@ export const BlobChannelConfigSchema = z.object({
accountKey: z.string().optional(),
connectionString: z.string().optional(),
containerName: z.string().min(1, "Container name is required"),
endpointUrl: z.string().optional(),
endpointUrl: z.string().url("Endpoint URL must be a valid URL").optional(),
}).refine(
(data) => data.accountKey || data.connectionString,
{message: "Either account key or connection string is required"}
+7 -4
View File
@@ -128,11 +128,14 @@ export async function pingBlob(config: BlobConfig): Promise<StorageResult> {
provider: "blob",
response: "Container does not exist"
};
const key = `${BASE_DIR}ping.txt`;
const key = `${BASE_DIR}ping-${Date.now()}-${Math.random().toString(36).slice(2)}.txt`;
const blockBlobClient = containerClient.getBlockBlobClient(key);
await blockBlobClient.upload(Buffer.from("ping"), 4);
await blockBlobClient.download();
await blockBlobClient.delete();
try {
await blockBlobClient.upload(Buffer.from("ping"), 4);
await blockBlobClient.download();
} finally {
await blockBlobClient.delete().catch(() => undefined);
}
return {
success: true,