mirror of
https://github.com/safedep/pmg.git
synced 2026-08-03 07:24:09 +02:00
Address remaining review comments: - shim: force root:root 0755 on the managed system dirs (shim tree and profile.d) after MkdirAll. A pre-created dir with weaker ownership, possible under Debian's group-writable /usr/local/lib, would let a non-root user replace the shims every account executes. - audit: when SUDO_USER has no passwd entry (minimal containers), attribute cloud events from sudo's recorded SUDO_USER/SUDO_UID env instead of falling back to root. Still gated on euid 0. - setup: reword the root-without---system warning; alias/shim install follows HOME, so claiming it configures only root's home was wrong. - shim: skip the non-root-owner validation test on Windows, where file ownership is not resolvable.
158 lines
4.1 KiB
Go
158 lines
4.1 KiB
Go
package audit
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"os"
|
|
"os/user"
|
|
"strings"
|
|
|
|
controltowerv1 "buf.build/gen/go/safedep/api/protocolbuffers/go/safedep/messages/controltower/v1"
|
|
"github.com/google/uuid"
|
|
"github.com/safedep/dry/cloud/endpointsync"
|
|
"github.com/safedep/dry/log"
|
|
"github.com/safedep/pmg/config"
|
|
)
|
|
|
|
type cloudSink struct {
|
|
*SyncClientBundle
|
|
invocationID string
|
|
ciResolver CloudSinkCIResolver
|
|
command string
|
|
workingDir string
|
|
}
|
|
|
|
func newCloudSink(cfg *config.RuntimeConfig, ciResolver CloudSinkCIResolver) (*cloudSink, error) {
|
|
bundle, err := NewSyncClientBundle(cfg)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
invocationID, err := uuid.NewRandom()
|
|
if err != nil {
|
|
if closeErr := bundle.Close(); closeErr != nil {
|
|
log.Warnf("failed to close sync client bundle after invocation ID failure: %v", closeErr)
|
|
}
|
|
return nil, fmt.Errorf("failed to generate invocation ID: %w", err)
|
|
}
|
|
|
|
wd, err := os.Getwd()
|
|
if err != nil {
|
|
if closeErr := bundle.Close(); closeErr != nil {
|
|
log.Warnf("failed to close sync client bundle after getwd failure: %v", closeErr)
|
|
}
|
|
return nil, fmt.Errorf("failed to get working directory: %w", err)
|
|
}
|
|
|
|
return &cloudSink{
|
|
SyncClientBundle: bundle,
|
|
invocationID: invocationID.String(),
|
|
ciResolver: ciResolver,
|
|
workingDir: wd,
|
|
}, nil
|
|
}
|
|
|
|
func (s *cloudSink) Handle(ctx context.Context, event AuditEvent) error {
|
|
if event.Type == EventTypeInstallStarted {
|
|
s.command = buildCommand(event.PackageManager, event.Args)
|
|
return nil
|
|
}
|
|
|
|
pmgEvents := s.translateToPmgEvents(event)
|
|
if len(pmgEvents) == 0 {
|
|
return nil
|
|
}
|
|
|
|
for _, pmgEvent := range pmgEvents {
|
|
toolEvent, err := s.syncClient.NewEvent()
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create tool event: %w", err)
|
|
}
|
|
|
|
toolEvent.SetPmgEvent(pmgEvent)
|
|
toolEvent.SetInvocationId(s.invocationID)
|
|
// Invocation context (CI, command, working dir) is set once per
|
|
// execution on the session summary event to avoid redundancy.
|
|
if event.Type == EventTypeSessionComplete {
|
|
toolEvent.SetInvocationContext(s.buildInvocationContext())
|
|
}
|
|
|
|
if err := s.syncClient.Emit(ctx, toolEvent); err != nil {
|
|
if errors.Is(err, endpointsync.ErrWALFull) {
|
|
log.Warnf("Cloud sync WAL is full, dropping event: %v", err)
|
|
return nil
|
|
}
|
|
return fmt.Errorf("failed to emit cloud event: %w", err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (s *cloudSink) buildInvocationContext() *controltowerv1.EndpointInvocationContext {
|
|
ctx := &controltowerv1.EndpointInvocationContext{}
|
|
ctx.SetCommand(s.command)
|
|
ctx.SetWorkingDirectory(s.workingDir)
|
|
|
|
if u := invokingUser(); u != nil {
|
|
ctx.SetUsername(u.Username)
|
|
ctx.SetUsernameUid(u.Uid)
|
|
}
|
|
|
|
if s.ciResolver != nil {
|
|
ci := &controltowerv1.EndpointCIContext{}
|
|
ci.SetProvider(s.ciResolver.Provider())
|
|
ci.SetRunId(s.ciResolver.RunId())
|
|
ci.SetRepository(s.ciResolver.Repository())
|
|
ci.SetBranch(s.ciResolver.Branch())
|
|
ci.SetCommitSha(s.ciResolver.CommitSha())
|
|
ci.SetActor(s.ciResolver.Actor())
|
|
ci.SetPrNumber(s.ciResolver.PrNumber())
|
|
if metadata := s.ciResolver.Metadata(); len(metadata) > 0 {
|
|
ci.SetMetadata(metadata)
|
|
}
|
|
ctx.SetCi(ci)
|
|
}
|
|
|
|
return ctx
|
|
}
|
|
|
|
var auditGeteuid = os.Geteuid
|
|
|
|
// invokingUser resolves the human behind the command. SUDO_USER is honored
|
|
// only when the process is actually elevated (euid 0); otherwise any user
|
|
// could set SUDO_USER to spoof cloud-audit attribution to another account.
|
|
func invokingUser() *user.User {
|
|
if auditGeteuid() == 0 {
|
|
if name := os.Getenv("SUDO_USER"); name != "" {
|
|
if u, err := user.Lookup(name); err == nil {
|
|
return u
|
|
}
|
|
// No passwd entry for the sudo user (minimal containers): keep
|
|
// the attribution sudo recorded rather than reporting root.
|
|
return &user.User{Username: name, Uid: os.Getenv("SUDO_UID")}
|
|
}
|
|
}
|
|
u, err := user.Current()
|
|
if err != nil {
|
|
return nil
|
|
}
|
|
return u
|
|
}
|
|
|
|
func buildCommand(packageManager string, args []string) string {
|
|
if packageManager == "" {
|
|
return ""
|
|
}
|
|
if len(args) == 0 {
|
|
return packageManager
|
|
}
|
|
return packageManager + " " + strings.Join(args, " ")
|
|
}
|
|
|
|
// Close delegates to the embedded SyncClientBundle.Close().
|
|
func (s *cloudSink) Close() error {
|
|
return s.SyncClientBundle.Close()
|
|
}
|