* refactor: remove guard mode execution paths and guard-only packages Guard (non-proxy) mode is removed; all package-manager commands now always run the proxy flow. Removes the guard engine, the common flow, the extractor package, the npm/pypi dependency resolvers and the PackageResolver plumbing that only guard mode consumed. The guard package retains only PackageManagerGuardInteraction, which the proxy flow and confirmation interceptors reuse for user prompts. Proxy behavior is unchanged. * refactor: remove proxy opt-out surfaces, guard references in config, action and docs Removes Config.ProxyMode, ProxyConfig.Enabled, IsProxyModeEnabled, the proxy_mode legacy fallback, PMG_PROXY_ENABLED handling and the --proxy-mode / --include-dev-dependencies flags. Proxy interception can no longer be disabled. Also removes the proxy-mode input from the GitHub Action, the proxy-mode doctor check and setup info row, updates the E2E workflow to stop passing --proxy-mode=false, and sweeps guard-mode wording from docs and the config template. The legacy proxy_install_only flat key and PMG_PROXY_INSTALL_ONLY env var remain supported. audit.FlowTypeGuard is kept so previously recorded audit events still translate for cloud sync. * feat: fail loudly when a removed proxy opt-out is still configured A leftover proxy.enabled: false / proxy_mode: false config key or PMG_PROXY_ENABLED=false / PMG_PROXY_MODE=false env var previously meant guard mode; silently ignoring it would switch those users to proxy interception without notice. PMG now exits with an actionable error naming the exact source. Precedence mirrors the old resolution order: env (ignored under lockdown) > proxy.enabled > legacy proxy_mode. The pmg config subtree is exempt so the config file can still be fixed with pmg config edit/set. The GitHub Action's proxy-mode input is kept as a tombstone that fails the action when set to false and warns otherwise. * refactor: extract flows.RunProxy and address review findings Collapses the identical parse-then-run body duplicated across the 12 package manager commands into flows.RunProxy. Documents the cache-hit / offline analysis trade-off versus the removed guard manifest path, fixes a stale non-proxy label in the E2E workflow and a stale guard reference in the uvx parser comment. * fix(config): mirror old proxy opt-out precedence exactly PMG_PROXY_MODE only ever took effect through the legacy fallback, which was gated on the presence of a proxy: key in the config file (even a null one). Promoting it to the top env tier caused two inversions: a stale PMG_PROXY_MODE=false hard-failed configs that resolved to proxy mode, and PMG_PROXY_MODE=true silently overrode an explicit proxy.enabled: false file opt-out. The check now resolves in the old order: PMG_PROXY_ENABLED > proxy: section (presence gates the legacy tier) > PMG_PROXY_MODE > flat proxy_mode. parseOptOutBool also accepts numeric values (0 = false) to match viper's WeaklyTypedInput/cast.ToBool coercion, so proxy.enabled: 0 and proxy_mode: 0 are detected as opt-outs. * refactor: move package manager interaction out of guard * refactor: trim package manager interaction * fix(config): normalize config keys viper-style in proxy opt-out check Viper resolved config file keys case-insensitively and expanded dotted keys, so spellings like Proxy:, Enabled:, a literal proxy.enabled key or Proxy_Mode selected guard mode before the removal. The opt-out check now lowercases keys recursively and nests dotted keys before matching, so those existing opt-outs fail loudly instead of being silently ignored. * refactor: remove inert transitive controls, dead parser state and guard audit variant transitive / transitive_depth lost their only consumers with the dependency resolvers; remove the config fields, flags, template and doc entries, and the report/audit plumbing that misreported transitive analysis as enabled. Remove write-only parser state (PackageInstallTarget.Extras, ParsedCommand.ManifestFiles, ShouldExtractFromManifest); IsManifestInstall stays as it feeds sandbox gating via IsInstallationCommand. Remove audit.FlowTypeGuard and its cloud mapping; guard events recorded by pre-removal versions in an unsynced WAL translate to UNSPECIFIED. * fix: address review findings on the opt-out wiring and cleanups Move the removed-opt-out rejection from the CLI PersistentPreRun into proxyFlow.Run: the check now fires exactly for package-manager runs, so non-install commands (pmg setup remove, doctor, config, version) stay usable to fix or remove an opted-out installation, and future commands inherit or avoid the check by construction instead of by exemption list. Also: make the e2e malicious-package assertion actually fail the job when an install is not blocked, route pmg go through flows.RunProxy, and drop the dead extras return from pypiParsePackageInfo (extras are still stripped from package names). * fix(config): make the removed opt-out check faithful to the old resolution The gate that silenced the legacy proxy_mode surfaces matched the raw proxy key case-sensitively in the old code, while values resolved viper-style (case-insensitive, dotted keys); applying each semantic where the old code did fixes both divergences: a case-variant Proxy: section no longer hides a flat proxy_mode: false opt-out, and a dotted proxy.enabled: false overridden by proxy_mode: true no longer errors. Replace the generic key-tree normalization with two targeted lookups (the check only ever resolves proxy.enabled and proxy_mode), which also makes colliding spellings resolve deterministically. Coerce legacy-tier values cast.ToBool-style so PMG_PROXY_MODE=off style opt-outs are detected, log the config read error instead of swallowing it, and shorten the error to a one-line statement with the specific remedy in the help text. Add lockdown coverage (env inert both directions) and a repeated-run determinism test. * fix(config): fall back to defaults for unrecognized proxy opt-out values The old loader swallowed viper errors and ran on defaults, so values like proxy.enabled: yes or PMG_PROXY_ENABLED=banana silently discarded the whole config and defaulted to proxy. Treat them the same way now: unrecognized values mean the default (proxy on) instead of a hard error, and the doc comment no longer claims the old loader failed loudly. Only values that actually meant guard mode fail. Also check the removed opt-out before the CA trust check in pmg go, restoring the old error precedence: a config problem must not steer the user into an unnecessary OS trust store change. * fix(e2e): PMG_PROXY_MODE assertion must match the legacy gate semantics The runner's setup step writes the template config, which has a proxy: section — and with one present the legacy PMG_PROXY_MODE was always inert, so expecting a loud failure there asserts pre-fidelity-fix behavior. Assert both sides instead: inert (command succeeds) with the standard config, loud failure against an empty config dir where the legacy fallback actually applied. * refactor(config): collapse parseOptOutBool to ParseBool over the string form YAML hands us typed values (bool, int), so route them through fmt.Sprintf %v and strconv.ParseBool instead of a per-type switch. Identical behavior for every recognized value; numbers other than 0/1 now read as no opinion instead of cast.ToBool's nonzero-true, which no real config relies on.
7.0 KiB
Landlock Sandbox: Developer Notes
How the Linux Landlock driver works and why. User docs: sandbox.md.
Why Landlock + seccomp
Landlock is positive allow-list. Our profiles are negative on top of broad allow:
allow_read: / plus implicit deny on ~/.ssh, ~/.aws, .env, .git/hooks. Landlock
cannot subtract from a subtree, so we layer seccomp-notify on top:
- Landlock: kernel-native allow-list, fast, applies to most syscalls.
- seccomp-notify: intercepts
openat/openat2/execve/execveat, resolves the path arg by reading the trapping process's memory, matches against the deny list, respondsEACCESorCONTINUE.
Architecture
pmg main ──fork+exec──► pmg __landlock_sandbox_exec [helper, unfiltered]
│ runs supervisor loop
│
clone(CLONE_NEWUSER, uid=0→host)
│
▼
pmg __landlock_shim [single-threaded,
├ install seccomp (no NNP) uid 0 in ns,
├ apply Landlock CAP_SYS_ADMIN]
├ send notify_fd via SCM_RIGHTS
└ execve target
│
▼
target ─► child ─► grandchild [filter inherited,
dumpable=1]
The helper has no filter on itself, so it can read /proc/<pid>/mem for any descendant
to resolve openat paths.
Code layout
| File | Role |
|---|---|
cmd/landlock/landlock_sandbox_exec_linux.go |
Helper subcommand wrapper |
cmd/landlock/landlock_shim_linux.go |
Shim subcommand wrapper |
sandbox/platform/landlock_linux.go |
Sandbox impl, command rewrite |
sandbox/platform/landlock_translator_linux.go |
PMG policy → landlockExecPolicy |
sandbox/platform/landlock_helper_linux.go |
Helper: forks shim, runs supervisor |
sandbox/platform/landlock_shim_linux.go |
Shim: installs seccomp+Landlock, execve |
sandbox/platform/landlock_seccomp_linux.go |
BPF, supervisor loop, deny matchers, memfd cache |
sandbox/platform/landlock_abi_linux.go |
Kernel ABI probe |
Key decisions
Shim runs in CLONE_NEWUSER so seccomp can be installed without NNP
Unprivileged seccomp install requires PR_SET_NO_NEW_PRIVS. NNP plus execve triggers
LSM_UNSAFE_NO_NEW_PRIVS and the kernel sets dumpable=0. With dumpable=0,
/proc/<pid>/mem opens require CAP_SYS_PTRACE, which the helper does not have.
Result: supervisor cannot resolve openat paths for descendants.
The shim boots inside a fresh user namespace mapped 0 → host_uid. As uid 0 in the ns
it has CAP_SYS_ADMIN, which lets seccomp install skip NNP. No NNP, no dumpable reset,
memfd reads work for the whole tree. The mapping preserves host uid for filesystem
ownership; tools that gate on getuid() see no change.
Landlock is applied in the shim, after seccomp install
Earlier the helper installed seccomp first, then ran landlock.RestrictPaths.
BestEffort() probes via openat. Each probe trapped through the supervisor in the
same process. Go's GC stop-the-world needs every thread at a safepoint; a thread
suspended inside seccomp_do_user_notification cannot reach one. Helper hung after a
handful of notifications.
Now seccomp + Landlock both live in the shim, which is single-threaded by virtue of being just-exec'd Go. No GC pressure during setup. Helper is unfiltered.
No TSYNC on the filter
SECCOMP_FILTER_FLAG_TSYNC applies the filter to every thread in the group. Go runtime
threads (GC, sysmon, netpoll) routinely openat, all would trap and deadlock the same
way the unsandboxed-helper variant did.
Without TSYNC the filter is only on the installing thread. Descendants inherit it via
clone() and execve() anyway, so we get the same coverage without polluting the Go
runtime threads.
Stop() wakes the supervisor via an eventfd
Closing notifyFd does not wake an ioctl(SECCOMP_IOCTL_NOTIF_RECV) blocker. We
ppoll over notifyFd + an eventfd; Stop() writes to the eventfd. See
waitForNotif in landlock_seccomp_linux.go.
landlockReadAccess includes EXECUTE
Bubblewrap's --ro-bind permits execve implicitly. Landlock requires explicit
AccessFSExecute. Without it allow_read: / blocks every binary load. We bake EXECUTE
into read access; deny-exec is still enforced by the seccomp supervisor.
Per-PID /proc/<pid>/mem cache, invalidated on execve
execve reshapes the address space; the cached fd returns EOF afterwards. We
invalidate on each execve notification (seccompPhase.invalidateMemFd) and lazily
reopen via memFdFor. Grandchildren get their own entries.
Deny matcher treats a path as its own subtree
GetMandatoryDenyPatterns emits /home/user/.ssh (no trailing slash). The matcher
covers the path itself and anything beneath entry+"/", so ~/.ssh/id_rsa is caught.
Trailing-slash entries still prefix-match.
Go-specific nuances
The Landlock+seccomp pattern was designed around the C/Rust threading model. Go pays a constant tax that maps to most of the decisions above:
- Multi-threaded from
main(). Go always has GC, sysmon, netpoll threads. There is no single-threaded mode. TSYNC turns those threads into traffic for our supervisor. - GC stop-the-world vs. seccomp wait. A goroutine suspended by the kernel inside a seccomp trap cannot reach a GC safepoint. STW blocks. The supervisor goroutine, which would unblock the trap, never runs. Rust has no GC, no STW.
- No code injection between fork and execve. Go's
exec.Cmddoesclone()+ a hardcoded sequence +execve(). There is noPreExecFnfield. The shim subcommand exists to provide a hookpoint that doesn't exist inos/exec. In Rust this is inline post-fork(). unshare(CLONE_NEWUSER)rejects multi-threaded callers. A Go program cannot enter a new user namespace frommain(). We route the namespace throughclone(CLONE_NEWUSER)on the child path ofcmd.Startinstead.runtime.LockOSThreadis mandatory wherever per-thread state matters (NNP, seccomp install, the supervisor'sppoll/ioctlloop). Otherwise Go's scheduler will move the goroutine and the per-thread state goes with the wrong thread.
Limitations
- Unprivileged user namespaces required. On distros that disable them,
clone()returns EPERM. We don't yet probe and fall back to bubblewrap (TODO). - Network filtering not enforced. Landlock V4 does TCP ports, not hostnames. PMG's proxy interception provides network control.
- PID/IPC namespace isolation is best-effort. Retried without on EPERM.
- Audit events are dropped. Wired but consumed by
io.Discard. - TOCTOU between path read and deny response. Microseconds. Adequate for benign install scripts; not a hardened defense.