feat: add progress bar and add debug & silent flags

This commit is contained in:
Sahilb315
2025-04-29 01:33:27 +05:30
parent 5ea85fa1f3
commit 8b31fd458b
4 changed files with 165 additions and 5 deletions
+17 -1
View File
@@ -8,6 +8,7 @@ import (
"time"
"github.com/safedep/dry/log"
"github.com/safedep/pmg/internal/ui"
"github.com/safedep/pmg/pkg/analyser"
"github.com/safedep/pmg/pkg/common/utils"
"github.com/safedep/pmg/pkg/models"
@@ -19,6 +20,7 @@ import (
var (
packageName string
action string
silentScan bool
)
func NewNpmCommand() *cobra.Command {
@@ -49,10 +51,18 @@ func NewNpmCommand() *cobra.Command {
return utils.ExecCmd(npmPath, args, []string{})
},
}
cmd.Flags().BoolVarP(&silentScan, "silent", "s", false,
"Silent scan to prevent rendering UI")
return cmd
}
func wrapNpm() error {
if !silentScan {
ui.StartProgressWriter()
}
var progressTracker ui.ProgressTracker
progressTracker = ui.TrackProgress(fmt.Sprintf("Scanning %s ", packageName), 1)
if packageName == "" {
return fmt.Errorf("package name cannot be empty")
}
@@ -81,17 +91,21 @@ func wrapNpm() error {
// Update packageName with resolved version for npm installation
packageName = fmt.Sprintf("%s@%s", name, version)
}
ui.IncrementProgress(progressTracker, 1)
deps, err := npmFetcher.GetFlattenedDependencies(ctx, name, version)
ui.IncrementProgress(progressTracker, 1)
if err != nil {
return err
}
ui.IncrementTrackerTotal(progressTracker, int64(len(deps)))
client, err := analyser.GetMalwareAnalysisClient()
if err != nil {
return fmt.Errorf("error while creating a malware analysis client: %w", err)
}
pkgAnalyser := analyser.New(client, ctx)
pkgAnalyser.ProgressTracker = progressTracker
handler := pkgAnalyser.Handler()
// Create work queue with appropriate buffer size and concurrency
@@ -114,6 +128,8 @@ func wrapNpm() error {
// Wait for all analysis to complete
queue.Wait()
ui.MarkTrackerAsDone(progressTracker)
ui.StopProgressWriter()
// Get the npm PATH and continue with installation
npmPath, err := utils.GetExecutablePath("npm")
+136
View File
@@ -0,0 +1,136 @@
package ui
import (
"os"
"time"
"github.com/jedib0t/go-pretty/v6/progress"
)
// ProgressTracker defines the interface for tracking progress
type ProgressTracker interface {
Increment(count int64)
SetValue(count int64)
UpdateTotal(count int64)
MarkAsDone()
GetValue() int64
GetTotal() int64
}
// progressTrackerImpl implements ProgressTracker using go-pretty/progress
type progressTrackerImpl struct {
tracker *progress.Tracker
}
func (p *progressTrackerImpl) Increment(count int64) {
if p.tracker != nil {
p.tracker.Increment(count)
}
}
func (p *progressTrackerImpl) SetValue(count int64) {
if p.tracker != nil {
p.tracker.SetValue(count)
}
}
func (p *progressTrackerImpl) UpdateTotal(count int64) {
if p.tracker != nil {
p.tracker.UpdateTotal(count)
}
}
func (p *progressTrackerImpl) MarkAsDone() {
if p.tracker != nil {
p.tracker.MarkAsDone()
}
}
func (p *progressTrackerImpl) GetValue() int64 {
if p.tracker != nil {
return p.tracker.Value()
}
return 0
}
func (p *progressTrackerImpl) GetTotal() int64 {
if p.tracker != nil {
return p.tracker.Total
}
return 0
}
var progressWriter progress.Writer
func StartProgressWriter() {
pw := progress.NewWriter()
pw.SetAutoStop(false)
pw.SetTrackerLength(25)
pw.SetMessageLength(20)
pw.SetSortBy(progress.SortByPercentDsc)
pw.SetStyle(progress.StyleDefault)
pw.SetOutputWriter(os.Stderr)
pw.SetTrackerPosition(progress.PositionRight)
pw.SetUpdateFrequency(time.Millisecond * 100)
pw.Style().Colors = progress.StyleColorsExample
pw.Style().Options.PercentFormat = "%4.1f%%"
pw.Style().Visibility.Pinned = true
pw.Style().Visibility.ETA = true
pw.Style().Visibility.Value = true
progressWriter = pw
go progressWriter.Render()
}
func StopProgressWriter() {
if progressWriter != nil {
progressWriter.Stop()
time.Sleep(1 * time.Second)
}
}
func SetPinnedMessageOnProgressWriter(msg string) {
if progressWriter != nil {
progressWriter.SetPinnedMessages(msg)
}
}
func TrackProgress(message string, total int) ProgressTracker {
tracker := progress.Tracker{Message: message, Total: int64(total),
Units: progress.UnitsDefault}
if progressWriter != nil {
progressWriter.AppendTracker(&tracker)
}
return &progressTrackerImpl{tracker: &tracker}
}
func MarkTrackerAsDone(i any) {
if tracker, ok := i.(ProgressTracker); ok {
tracker.MarkAsDone()
}
}
func IncrementTrackerTotal(i any, count int64) {
if tracker, ok := i.(ProgressTracker); ok {
tracker.UpdateTotal(tracker.GetTotal() + count)
}
}
func IncrementProgress(i any, count int64) {
if tracker, ok := i.(ProgressTracker); ok && (progressTrackerDelta(tracker) > count) {
tracker.Increment(count)
}
}
func UpdateValue(i any, count int64) {
if tracker, ok := i.(ProgressTracker); ok {
tracker.SetValue(count)
}
}
func progressTrackerDelta(tracker ProgressTracker) int64 {
return (tracker.GetTotal() - tracker.GetValue())
}
+9 -4
View File
@@ -9,14 +9,17 @@ import (
"github.com/spf13/cobra"
)
func init() {
log.Init("pmg-logger", "debug")
}
func main() {
var debug bool
cmd := &cobra.Command{
Use: "pmg",
TraverseChildren: true,
PersistentPreRun: func(cmd *cobra.Command, args []string) {
if debug {
log.Init("pmg-logger", "debug")
}
},
RunE: func(cmd *cobra.Command, args []string) error {
if len(args) == 0 {
return nil
@@ -25,6 +28,8 @@ func main() {
},
}
cmd.PersistentFlags().BoolVar(&debug, "debug", false, "Enable debug logging")
cmd.AddCommand(ecosystems.NewNpmCommand())
if err := cmd.Execute(); err != nil {
+3
View File
@@ -10,6 +10,7 @@ import (
packagev1 "buf.build/gen/go/safedep/api/protocolbuffers/go/safedep/messages/package/v1"
malysisv1 "buf.build/gen/go/safedep/api/protocolbuffers/go/safedep/services/malysis/v1"
"github.com/safedep/dry/log"
"github.com/safedep/pmg/internal/ui"
"github.com/safedep/pmg/pkg/models"
vetUtils "github.com/safedep/vet/pkg/common/utils"
)
@@ -19,6 +20,7 @@ type PackageAnalyser struct {
Client malysisv1grpc.MalwareAnalysisServiceClient
Ctx context.Context
MaliciousPkgsMutex sync.Mutex
ProgressTracker ui.ProgressTracker
}
func New(client malysisv1grpc.MalwareAnalysisServiceClient, ctx context.Context) *PackageAnalyser {
@@ -66,6 +68,7 @@ func (ap *PackageAnalyser) Handler() vetUtils.WorkQueueFn[models.Package] {
ap.MaliciousPkgsMutex.Unlock()
}
ui.IncrementProgress(ap.ProgressTracker, 1)
return nil
}
}