External/open-design
1
0
Fork 0
mirror of https://github.com/nexu-io/open-design.git synced 2026-10-27 09:51:12 +01:00
Code Issues Packages Projects Releases Wiki Activity

test(web): pin deck bridge structured-first precedence with decoy .slide

Browse Source 
Address review feedback on #1542: the existing structured-first case
expected count === 3 but the fixture only contained the three real
slides, so a regression that dropped the structured selector entirely
and went straight to `.slide` would still pass. Add a decoy `.slide`
in a sibling <header> outside `.deck`; the structured-first pass
keeps count === 3, while a naive broad selector would now count 4.

Verified by temporarily collapsing slides() to `document.querySelectorAll('.slide')`
and observing the second case fail with `expected 4 to be 3`.
This commit is contained in:
SidQin-cyber
2026-05-13 15:32:18 +08:00
parent c4444df0e6
commit 650e007d05
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/web/tests/runtime/srcdoc-deck-bridge-nested-slides.test.ts
+8 -6
View File
@@ -80,17 +80,19 @@ describe('deck bridge — nested slide markup (#1530)', () => {
expect(state.count).toBe(8);
});
it('still counts slides under the documented containers as direct children', async () => {
it('still counts slides under the documented containers as direct children and ignores decorative .slide markup outside them', async () => {
// Pin the structured-first contract: direct children of `.deck` /
// `.deck-stage` / `.deck-shell` / `body` keep working as before, so
// the fallback is only reached for nested decks and decorative
// `.slide` markup in non-deck pages does not get accidentally
// counted just because it sits somewhere in the document.
// `.deck-stage` / `.deck-shell` / `body` keep working as before AND
// decorative `.slide` markup placed outside any structured container
// (e.g. a utility class on a banner graphic) is not pulled in just
// because it shares the class name. Without the structured-first
// pass a broad `.slide` selector would count 4 here, so this fixture
// pins the precedence directly rather than only by docstring.
const slides = Array.from({ length: 3 }, (_, i) =>
`<section class="slide">${i}</section>`,
).join('');
const { win, parentPostMessage } = setupDeckBridge(
`<div class="deck">${slides}</div>`,
`<header><span class="slide" aria-hidden="true">decoy</span></header><div class="deck">${slides}</div>`,
);
await new Promise<void>((resolve) => win.setTimeout(resolve, 350));
const state = lastSlideState(parentPostMessage);