External/oott
1
0
Fork 0
mirror of https://github.com/rzuasti/oott.git synced 2026-07-08 19:21:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix startup WAL race and stale sidecar I/O errors

Browse Source 
Enabling WAL per pooled connection raced several concurrent journal-mode
switches when r2d2 eagerly opens the pool at startup, producing transient
"disk I/O error" and "database is locked" failures. WAL is a persistent
property of the database file, so enable it once in init_db (before the
scanners and web server start) and keep only the genuinely per-connection
pragmas (busy_timeout, synchronous, foreign_keys) in the pool initializer.

Also remove the -wal/-shm sidecars in run.sh: deleting oott.db but leaving
a stale write-ahead log behind makes SQLite open the fresh database against
an orphaned log and fail with "disk I/O error".

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
rzuasti
2026-06-06 09:46:44 -04:00
co-authored by Claude Opus 4.8
parent 393e545501
commit 5c5087d687
2 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/run.sh
+4 -1
View File
@@ -1,3 +1,6 @@
#!/bin/sh
sudo rm -f oott.db
# Remove the database and its WAL sidecars. Deleting oott.db but leaving a stale -wal/-shm
# behind (e.g. from a previous run killed before a checkpoint) makes SQLite open the fresh
# database against an orphaned write-ahead log and fail with "disk I/O error".
sudo rm -f oott.db oott.db-wal oott.db-shm
sudo CARGO_HOME=$HOME/.cargo cargo run
backend/src/db.rs
+16 -7
View File
@@ -27,18 +27,20 @@ lazy_static! {
build(
r2d2_sqlite::SqliteConnectionManager::file(get_settings().database.path.as_str())
.with_init(|conn| {
// Tune every pooled connection for the concurrent access pattern of this
// app (five scanners + web server + retention sharing the pool):
// - WAL lets readers and a writer proceed concurrently instead of blocking.
// - synchronous=NORMAL is the safe, recommended pairing with WAL and avoids
// an fsync on every commit (the default FULL fsyncs on each write).
// Per-connection pragmas. These must be set on every pooled connection (they
// are not persisted in the database file). The WAL journal mode is NOT set
// here: it is a persistent property of the database file and is enabled once
// in `init_db`. Setting it per connection instead races several concurrent WAL
// switches when r2d2 eagerly opens the pool at startup, producing transient
// "disk I/O error" / "database is locked" failures.
// - busy_timeout makes a connection wait for a lock rather than failing
// immediately with "database is locked".
// - synchronous=NORMAL is the safe, recommended pairing with WAL and avoids
// an fsync on every commit (the default FULL fsyncs on each write).
// - foreign_keys are off by default in SQLite and must be set per connection.
conn.execute_batch(
"PRAGMA journal_mode = WAL;
"PRAGMA busy_timeout = 5000;
PRAGMA synchronous = NORMAL;
PRAGMA busy_timeout = 5000;
PRAGMA foreign_keys = ON;",
)
})
@@ -95,6 +97,13 @@ pub async fn init_db() -> Result<(), DbError> {
let mut conn = get_db_connection()?;
// Enable WAL once on the shared database file. WAL is a persistent property of the file, so it
// survives across connections and restarts and only needs to be set a single time, here, before
// the scanners and web server start. Doing it per pooled connection instead races several
// concurrent WAL switches at startup ("disk I/O error" / "database is locked").
debug!("Ensuring the database is in WAL journal mode.");
conn.execute_batch("PRAGMA journal_mode = WAL;")?;
debug!("Executing database migrations if needed.");
let result = match MIGRATIONS.to_latest(&mut conn) {