Fix race condition if user ID is in session but not in user store (#43)

This commit is contained in:
Jochen Schalanda
2022-01-25 15:11:21 +01:00
committed by GitHub
parent e5627e1d02
commit 47adb88cb5

View File

@@ -5,13 +5,13 @@ const hasher = require('../../services/security/hash');
loginRouter.get('/user', async (req, res) => {
const currentUserId = req.session.currentUser;
const isAdmin = currentUserId == null ? false : userStorage.getUser(currentUserId).isAdmin;
if (currentUserId == null) {
const currentUser = currentUserId == null ? null : userStorage.getUser(currentUserId);
if (currentUser == null) {
res.body = {};
} else {
res.body = {
userId: currentUserId,
isAdmin,
userId: currentUser.id,
isAdmin: currentUser.isAdmin,
};
}
res.send();