External/caveman
1
0
Fork 0
mirror of https://github.com/JuliusBrussee/caveman.git synced 2026-08-11 13:21:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(install): force --yes --all on npx skills add (issue #370)

Browse Source 
curl|bash one-liner stdin is not a TTY, so the upstream skills CLI
renders its interactive skill-picker TUI with nothing selected, exits
0, and installs zero skills — while our installer reports "done".
Pass --yes --all to skip the picker and confirmation prompts in both
the per-provider call and the auto-detect fallback.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Julius Brussee
2026-05-12 21:44:32 +02:00
co-authored by Claude Opus 4.7
parent e8b69797a8
commit 63a91ecadb
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bin/install.js
+11 -2
View File
@@ -443,7 +443,14 @@ function installViaSkills(ctx, prov) {
const { say, opts, results } = ctx;
results.detected++;
say(`→ ${prov.label} detected`);
const r = runSpawn('npx', ['-y', 'skills', 'add', REPO, '-a', prov.profile], null, opts.dryRun);
// --yes --all: skip the upstream skill-selection TUI and confirmation prompts.
// Without these, `curl|bash` (no TTY on stdin) renders an empty checkbox list
// the user can't interact with, then exits 0 with zero skills installed —
// and our installer happily reports success. See issue #370.
// We've already decided which agent to install for via auto-detect / --only;
// making the user re-select 7 skills inside skills CLI would be redundant.
const args = ['-y', 'skills', 'add', REPO, '-a', prov.profile, '--yes', '--all'];
const r = runSpawn('npx', args, null, opts.dryRun);
if ((r.status || 0) === 0) results.installed.push(prov.id);
else results.failed.push([prov.id, `npx skills add (${prov.profile}) failed`]);
process.stdout.write('\n');
@@ -1163,7 +1170,9 @@ async function main() {
// Auto-detect fallback if nothing matched
if (!opts.skipSkills && opts.only.length === 0 && ctx.results.detected === 0) {
ctx.say('→ no known agents detected — running npx-skills auto-detect fallback');
const r = runSpawn('npx', ['-y', 'skills', 'add', REPO], null, opts.dryRun);
// --yes --all for the same reason as installViaSkills above (issue #370):
// skip the interactive skill picker so curl|bash actually installs.
const r = runSpawn('npx', ['-y', 'skills', 'add', REPO, '--yes', '--all'], null, opts.dryRun);
if ((r.status || 0) === 0) ctx.results.installed.push('skills-auto');
else ctx.results.failed.push(['skills-auto', 'npx skills add (auto) failed']);
process.stdout.write('\n');