fix(features): flip useFeatureEnabled to fail-open for unknown ids

Per tho's call: manifest membership signals 'this needs gating'; absence
means 'just render it.' A stray <FeatureGate feature='removed-id'> should
not hide UI. Dev-mode console.warn stays so typos still surface during
development; only the resolution flips false -> true.

No call sites or tests asserted the old fail-closed behavior.

Signed-off-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@sprout-oss.stage.blox.sqprod.co>
This commit is contained in:
npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w
2026-06-08 16:38:58 -07:00
parent 5a0508ef21
commit d9968a31d4
@@ -95,6 +95,10 @@ export function useFeatureSnapshot(): Record<string, boolean> {
*
* - stable: always true
* - preview: true only if user opted in
* - unknown id: fail-open (returns true). Manifest membership signals "this
* needs gating"; absence means "just render it." A stray `<FeatureGate>`
* pointing at a removed id should not hide UI. Dev mode still logs a
* `console.warn` so typos surface during development.
*/
export function useFeatureEnabled(featureId: string): boolean {
const overrides = useFeatureSnapshot();
@@ -106,7 +110,7 @@ export function useFeatureEnabled(featureId: string): boolean {
`[FeatureFlags] Unknown feature id: "${featureId}". Check features.json.`,
);
}
return false;
return true;
}
return resolveEnabled(feature.tier, featureId, overrides);