External/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

test: add e2e tests for GitHub PR smart link rendering

Browse Source 
Verifies PR URLs render as inline chips with icon and owner/repo#number,
open in new tabs, and that non-PR GitHub links remain regular links.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Taylor Ho
2026-04-08 14:10:45 -10:00
co-authored by Claude Opus 4.6
parent 9d029410e4
commit d4043920a4
2 changed files with 69 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
desktop/playwright.config.ts
+1
View File
@@ -24,6 +24,7 @@ export default defineConfig({
"**/channel-browser.spec.ts",
"**/messaging.spec.ts",
"**/mentions.spec.ts",
"**/smart-links.spec.ts",
"**/workflows.spec.ts",
],
use: {
desktop/tests/e2e/smart-links.spec.ts
+68
View File
@@ -0,0 +1,68 @@
import { expect, test } from "@playwright/test";
import { installMockBridge } from "../helpers/bridge";
test.beforeEach(async ({ page }) => {
await installMockBridge(page);
});
test("GitHub PR URL renders as an inline smart chip", async ({ page }) => {
const prUrl = "https://github.com/block/goose2/pull/125";
const message = `Check out ${prUrl} for the fix`;
await page.goto("/");
await page.getByTestId("channel-general").click();
await expect(page.getByTestId("chat-title")).toHaveText("general");
const input = page.getByTestId("message-input");
await input.fill(message);
await page.getByTestId("send-message").click();
const lastRow = page.getByTestId("message-row").last();
// The PR link should render as a styled chip with the repo and PR number
const prChip = lastRow.locator("a", { hasText: "block/goose2#125" });
await expect(prChip).toBeVisible();
await expect(prChip).toHaveAttribute("href", prUrl);
// Should contain the GitPullRequest icon (rendered as an SVG)
await expect(prChip.locator("svg")).toBeVisible();
});
test("GitHub PR chip links open in new tab", async ({ page }) => {
const prUrl = "https://github.com/block/sprout/pull/42";
await page.goto("/");
await page.getByTestId("channel-general").click();
await expect(page.getByTestId("chat-title")).toHaveText("general");
const input = page.getByTestId("message-input");
await input.fill(prUrl);
await page.getByTestId("send-message").click();
const lastRow = page.getByTestId("message-row").last();
const prChip = lastRow.locator("a", { hasText: "block/sprout#42" });
await expect(prChip).toHaveAttribute("target", "_blank");
await expect(prChip).toHaveAttribute("rel", "noreferrer");
});
test("non-PR GitHub links render as regular links", async ({ page }) => {
const repoUrl = "https://github.com/block/sprout";
const message = `Check out ${repoUrl}`;
await page.goto("/");
await page.getByTestId("channel-general").click();
await expect(page.getByTestId("chat-title")).toHaveText("general");
const input = page.getByTestId("message-input");
await input.fill(message);
await page.getByTestId("send-message").click();
const lastRow = page.getByTestId("message-row").last();
// Should render as a normal underlined link, not a chip
const link = lastRow.locator("a", { hasText: repoUrl });
await expect(link).toBeVisible();
// Regular links have underline styling, not the chip background
await expect(link.locator("svg")).not.toBeVisible();
});