External/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(mobile/ios): reject events below composite cursor

Browse Source 
Co-authored-by: npub1tquskdu6yc4h8l7xxtceculxw600grekeq0xg2ukqfrwl7vrzg3quz3gmp <58390b379a262b73ffc632f19c73e6769ef40f36c81e642b960246eff9831222@buzz.block.builderlab.xyz>
Signed-off-by: npub1tquskdu6yc4h8l7xxtceculxw600grekeq0xg2ukqfrwl7vrzg3quz3gmp <58390b379a262b73ffc632f19c73e6769ef40f36c81e642b960246eff9831222@buzz.block.builderlab.xyz>
Co-authored-by: Cursor <noreply@cursor.com>
Ai-assisted: true
This commit is contained in:
npub1tquskdu6yc4h8l7xxtceculxw600grekeq0xg2ukqfrwl7vrzg3quz3gmp
2026-07-27 20:20:31 -07:00
co-authored by Cursor
parent 1598cf0f06
commit b20d3114cb
3 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mobile/ios/.gitignore
+1
View File
@@ -9,6 +9,7 @@
.tags*
**/.vagrant/
**/DerivedData/
BuzzPushKit/Package.resolved
Icon?
**/Pods/
**/.symlinks/
mobile/ios/BuzzPushKit/Sources/BuzzPushKit/PushConsumptionState.swift
+1 -1
View File
@@ -112,7 +112,7 @@ public struct PushConsumptionState: Codable, Equatable, Sendable {
) -> Bool {
let originState = state(for: origin)
return position.createdAt <= now + allowedFutureSkew
&& position.createdAt >= (originState.cursor?.createdAt ?? position.createdAt)
&& position >= (originState.cursor ?? position)
&& !originState.contains(eventID: position.id)
}
mobile/ios/BuzzPushKit/Tests/BuzzPushKitTests/PushConsumptionStateTests.swift
+19
View File
@@ -44,6 +44,25 @@ final class PushConsumptionStateTests: XCTestCase {
XCTAssertEqual(state.state(for: "origin").delivered.count, 64)
}
func testEvictedDeliveredEventBelowCompositeCursorIsNeverSelectedAgain() {
var state = PushConsumptionState()
for index in 0..<70 {
state.consume(
PushEventPosition(createdAt: 1_000, id: String(format: "%064x", index)),
for: "origin"
)
}
let evicted = PushEventPosition(createdAt: 1_000, id: String(format: "%064x", 0))
let sameSecondSuccessor = PushEventPosition(
createdAt: 1_000,
id: String(format: "%064x", 70)
)
XCTAssertFalse(state.hasConsumed(eventID: evicted.id, for: "origin"))
XCTAssertFalse(state.canSelect(evicted, for: "origin", now: 2_000))
XCTAssertTrue(state.canSelect(sameSecondSuccessor, for: "origin", now: 2_000))
}
func testEventOlderThanCompositeCursorIsNotSelected() {
var state = PushConsumptionState()
state.consume(PushEventPosition(createdAt: 2_000, id: "newer"), for: "origin")