External/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(dictation): cancel pending starts when composer becomes disabled

Browse Source 
The disabled-state cleanup only checked isRecording, so it never aborted a
start still in isStarting (mic permission / AudioWorklet setup) or the
isTranscribing grace window. If the composer became disabled mid-start
(channel read-only, parent send-state disable), the pending start could
finish and begin microphone capture in a disabled composer.

Broaden the guard to the full ownership window (isRecording || isStarting ||
isTranscribing) and re-run when any flag flips, so cancelRecording() — which
sets startAbortedRef to bail an in-flight start — fires for a start that
completes after the disable.
This commit is contained in:
npub13fn4ahfnvaa2qwylvegdgeajqs0mph6v4qsw4jcqnw4mjh3hzh2quuucm5
2026-07-11 16:20:30 +01:00
parent 4021694be6
commit 8e046c0ed3
1 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
desktop/src/features/dictation/hooks/useComposerDictation.ts
+19 -3
View File
@@ -110,14 +110,30 @@ export function useComposerDictation({
}
}, [draftKey]);
// Auto-cancel dictation when the composer becomes disabled mid-recording
// Auto-cancel dictation when the composer becomes disabled mid-session
// (e.g. channel becomes read-only, parent send state disables thread composer).
// Without this, the STT session keeps running with no way to stop it.
//
// Covers the full ownership window — `isStarting` and `isTranscribing`, not
// just `isRecording`. If the composer is disabled while `startRecording()` is
// still resolving (mic permission / AudioWorklet setup), the pending start
// would otherwise finish and begin microphone capture in a disabled composer.
// `cancelRecording()` aborts the in-flight start as well as a live recording,
// and re-running when any of these flags flip catches a start that completes
// after the disable.
useEffect(() => {
if (disabled && dictation.isRecording) {
const owningSession =
dictation.isRecording || dictation.isStarting || dictation.isTranscribing;
if (disabled && owningSession) {
dictation.cancelRecording();
}
}, [disabled, dictation.isRecording, dictation.cancelRecording]);
}, [
disabled,
dictation.isRecording,
dictation.isStarting,
dictation.isTranscribing,
dictation.cancelRecording,
]);
// ⌘D push-to-talk — hold to record, release to stop.
// Dispatched from AppShell's keydown/keyup handlers.