External/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(dictation): capture session ID by value in listener closures

Browse Source 
Each listener now compares event.payload.session against the local
`sessionId` const (captured by the closure) instead of reading from
the mutable `nativeSessionRef.current`. This prevents stale listeners
from a previous session from matching the new session's ID after the
ref is updated.

Also unregisters any lingering listeners at the start of a new session
before registering fresh ones, ensuring no duplicate handlers exist.
This commit is contained in:
klopez4212
2026-07-11 16:19:20 +01:00
committed by npub13fn4ahfnvaa2qwylvegdgeajqs0mph6v4qsw4jcqnw4mjh3hzh2quuucm5
parent f661dce8ff
commit 3b182acc5e
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
desktop/src/features/dictation/hooks/useLocalDictation.ts
+15 -4
View File
@@ -208,15 +208,26 @@ export function useLocalDictation({
return;
}
// Unregister any lingering listeners from a previous session so they
// can't match the new session ID via the shared ref.
if (unlistenTranscriptRef.current) {
unlistenTranscriptRef.current();
unlistenTranscriptRef.current = null;
}
if (unlistenStateRef.current) {
unlistenStateRef.current();
unlistenStateRef.current = null;
}
// 2. Listen for transcript events from the native layer.
// Each event includes a `session` ID so we can definitively ignore stale
// transcripts from a previous session's forwarder.
// Each listener captures `sessionId` by value (closure) so it only
// matches events from this specific session — immune to ref mutation.
const unlistenTranscript = await listen<{
text: string;
session: number;
}>(DICTATION_TRANSCRIPT_EVENT, (event) => {
const { text, session } = event.payload;
if (session !== nativeSessionRef.current) return;
if (session !== sessionId) return;
if (text) {
onTranscriptTextRef.current(text);
}
@@ -234,7 +245,7 @@ export function useLocalDictation({
session: number;
}>(DICTATION_STATE_EVENT, (event) => {
const { state, session } = event.payload;
if (session !== nativeSessionRef.current) return;
if (session !== sessionId) return;
if (state === "stopped") {
setIsRecording(false);
setIsTranscribing(false);