External/buzz
1
0
Fork 0
mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

test(desktop): stabilize community submenu timing coverage

Browse Source 
Co-authored-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
This commit is contained in:
Taylor Ho
2026-08-17 21:22:24 -07:00
parent c6c5c3ed02
commit 2ef44d2c21
1 changed files with 68 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
desktop/tests/e2e/community-rail.spec.ts
+68 -34
View File
@@ -276,10 +276,52 @@ test.describe("community rail", () => {
expect(feedbackBox?.y).toBeLessThan(settingsBox?.y ?? 0);
const menu = page.getByRole("menu", { name: "Community actions" });
await communityTrigger.evaluate((trigger) => {
trigger.addEventListener(
"mouseenter",
() => {
trigger.dataset.hoverStartedAt = String(performance.now());
},
{ once: true },
);
trigger.addEventListener("mouseleave", () => {
trigger.dataset.leftAt = String(performance.now());
});
const observer = new MutationObserver((records) => {
if (
trigger.getAttribute("aria-expanded") === "true" &&
!trigger.dataset.expandedAt
) {
trigger.dataset.expandedAt = String(performance.now());
}
if (
records.some(
(record) =>
record.attributeName === "aria-expanded" &&
record.oldValue === "true",
)
) {
trigger.dataset.closedAfterOpening = "true";
}
});
observer.observe(trigger, {
attributeFilter: ["aria-expanded"],
attributeOldValue: true,
attributes: true,
});
});
await communityTrigger.hover();
await page.waitForTimeout(40);
await expect(menu).toBeHidden();
await expect(menu).toBeVisible({ timeout: 160 });
await expect(menu).toBeVisible({ timeout: 700 });
const openDelayMs = await communityTrigger.evaluate((trigger) => {
const hoverStartedAt = Number(trigger.dataset.hoverStartedAt);
const expandedAt = Number(trigger.dataset.expandedAt);
if (!Number.isFinite(hoverStartedAt) || !Number.isFinite(expandedAt)) {
throw new Error("Community actions open timing was not recorded");
}
return expandedAt - hoverStartedAt;
});
expect(openDelayMs).toBeGreaterThanOrEqual(40);
expect(openDelayMs).toBeLessThan(300);
const openTriggerBox = await communityTrigger.boundingBox();
const menuBox = await menu.boundingBox();
@@ -288,40 +330,32 @@ test.describe("community rail", () => {
if (!openTriggerBox || !menuBox) {
throw new Error("Community actions geometry unavailable");
}
await communityTrigger.evaluate((trigger) => {
trigger.addEventListener("mouseleave", () => {
document.body.dataset.communityTriggerLeft = "true";
});
const observer = new MutationObserver(() => {
if (trigger.getAttribute("aria-expanded") === "false") {
document.body.dataset.communityMenuClosedDuringBridge = "true";
}
});
observer.observe(trigger, {
attributeFilter: ["aria-expanded"],
attributes: true,
});
});
await page.mouse.move(
openTriggerBox.x + openTriggerBox.width / 2,
openTriggerBox.y + openTriggerBox.height + 4,
const triggerExitX = openTriggerBox.x + openTriggerBox.width - 1;
const triggerExitY = Math.min(
openTriggerBox.y + openTriggerBox.height - 4,
menuBox.y + menuBox.height - 4,
);
await page.mouse.move(triggerExitX, triggerExitY);
await page.mouse.move(menuBox.x + 8, menuBox.y - 8);
await page.waitForTimeout(80);
await expect
.poll(() =>
page.locator("body").getAttribute("data-community-trigger-left"),
)
.toBe("true");
await expect(menu).toBeVisible();
await expect
.poll(() =>
page
.locator("body")
.getAttribute("data-community-menu-closed-during-bridge"),
)
.toBeNull();
await page.mouse.move(menuBox.x + menuBox.width / 2, menuBox.y + 8);
await page.mouse.move(menuBox.x + 8, menuBox.y + 8);
const bridgeDurationMs = await communityTrigger.evaluate((trigger) => {
const leftAt = Number(trigger.dataset.leftAt);
if (!Number.isFinite(leftAt)) {
throw new Error(
"Community actions trigger exit timing was not recorded",
);
}
return performance.now() - leftAt;
});
expect(bridgeDurationMs).toBeGreaterThanOrEqual(60);
expect(bridgeDurationMs).toBeLessThan(140);
await page.waitForTimeout(180);
await expect(menu).toBeVisible();
await expect(communityTrigger).not.toHaveAttribute(
"data-closed-after-opening",
"true",
);
await expect(
menu.getByRole("menuitem", { name: "Copy community URL" }),
).toBeVisible();