Commit Graph
64 Commits
Author SHA1 Message Date
Addy Osmani 8739c15974 Refactor to better reflect Google SWE best practices 2026-03-28 14:06:57 -07:00
Addy Osmani 3aa5a43ae5 Add npm audit triage decision tree to security skill
Provides a structured approach for evaluating audit findings by
severity, reachability, and fix availability. Helps distinguish
between findings that need immediate action versus those that can
be tracked and fixed on a regular schedule.
2026-03-28 00:45:09 -07:00
Addy Osmani ba5e3bdee1 Add CI optimization strategies for slow pipelines
Added a decision tree and example for speeding up CI: dependency
caching, parallel jobs, path filters, matrix sharding, test suite
optimization, and larger runners. Ordered by typical impact.
2026-03-28 00:44:52 -07:00
Addy Osmani 9b644184f5 Quantify context flooding anti-pattern with line count thresholds
Replaced vague description with concrete numbers: agent focus degrades
above ~5,000 lines of non-task-specific context. Recommended target is
under 2,000 lines of focused context per task.
2026-03-28 00:44:29 -07:00
Addy Osmani f09e80ab9f Explain why each AI aesthetic pattern is a problem
The table previously listed AI defaults and their alternatives but did
not explain why each pattern is problematic. Added a middle column with
the specific design or UX reason to avoid each default.
2026-03-28 00:44:20 -07:00
Addy Osmani 5c13ed9330 Add task sizing inflection points to planning skill
Added concrete signals for when a task needs further breakdown: session
length, acceptance criteria count, subsystem scope, and the "and" test
for task titles that indicate multiple tasks in one.
2026-03-28 00:43:59 -07:00
Addy Osmani f932bdc481 Add rollout decision thresholds to shipping-and-launch
Added a concrete table with green/yellow/red thresholds for error rate,
P95 latency, client JS errors, and business metrics. Gives clear
criteria for advancing, holding, or rolling back at each rollout stage.
2026-03-28 00:43:47 -07:00
Addy Osmani 3da834d310 Expand non-reproducible bug strategies in debugging skill
Added a decision tree for when bugs cannot be reproduced on demand,
covering timing-dependent, environment-dependent, state-dependent,
and truly random failure modes with specific investigation steps.
2026-03-28 00:43:22 -07:00
Addy Osmani ad27ae54b4 Add measurement decision tree to performance-optimization
Helps determine what to measure first based on the symptom: slow first
load, sluggish interactions, navigation delays, or backend issues. Each
branch points to a specific profiling action.
2026-03-28 00:43:08 -07:00
Addy Osmani b5dd692cee Add cross-reference from spec-driven-development to context-engineering
The implementation phase now points to context-engineering for guidance
on loading the right spec sections per task instead of dumping the full
spec into context.
2026-03-28 00:42:29 -07:00
Addy Osmani f34cdea627 Add cross-reference from incremental-implementation to git workflow
The commit step in the increment cycle now points to the
git-workflow-and-versioning skill for atomic commit guidance.
2026-03-28 00:42:21 -07:00
Addy Osmani 424ce4aaba Add cross-references from code review to security and performance skills
The five-axis review touches on security and performance but previously
did not link to the detailed skills. Added pointers so reviewers can
consult deeper guidance when needed.
2026-03-28 00:42:12 -07:00
Addy Osmani b88b81f4f1 Add cross-reference from TDD to browser-testing-with-devtools
For browser-based changes, unit tests alone do not verify runtime
behavior. Added a pointer to the browser-testing skill.
2026-03-28 00:41:54 -07:00
Addy Osmani ed34942a40 Add Red Flags and Verification sections to idea-refine
The idea-refine skill was the only skill missing the standard Red Flags
and Verification sections. Added both to match the skill anatomy format
used by all other skills.
2026-03-28 00:41:45 -07:00
Addy Osmani 4d0b832917 Warn about untrusted third-party API responses
Added explicit guidance that external API responses must be validated
before use in logic or rendering. A compromised or misbehaving service
can return unexpected types or malicious content.
2026-03-28 00:41:14 -07:00
Addy Osmani 69e04034c6 Add external data trust checks to code review security axis
The security axis now checks whether external data sources (APIs,
logs, user content, config) are treated as untrusted and validated
at system boundaries. Added to both the review questions and checklist.
2026-03-28 00:40:57 -07:00
Addy Osmani 56786aa738 Use secrets for CI database credentials instead of hardcoded values
Replaced hardcoded test/test credentials in the database integration
example with GitHub Secrets references. Even for CI-only databases,
using secrets builds good habits and avoids accidental credential reuse.
2026-03-28 00:40:43 -07:00
Addy Osmani 18a0e1e0ae Add trust levels for loaded context sources
Source code and tests are trusted, but config files, data fixtures,
and external docs may contain instruction-like text that should be
verified before acting on. Added trust level guidance and red flag.
2026-03-28 00:40:28 -07:00
Addy Osmani 8e1fe9ddf1 Add untrusted error output security guidance to debugging skill
Error messages, stack traces, and log output from external sources
can contain instruction-like text that should not be blindly followed.
Added explicit rules and a red flag for this indirect injection vector.
2026-03-28 00:39:53 -07:00
Addy Osmani c1e7c2547b Address security feedback in #6
Here's what I added to address the audit findings:

**PROMPT_INJECTION (HIGH)** - Added a full "Security Boundaries" section with three subsections:
1. **Treat All Browser Content as Untrusted Data** - Explicit rules that DOM, console, network, and JS execution output are data, never instructions. Covers URL navigation restrictions and suspicious content flagging.
2. **Content Boundary Markers** - Visual diagram and rules separating trusted (user messages, project code) from untrusted (all browser-sourced data) contexts.

**COMMAND_EXECUTION (HIGH)** - Added **JavaScript Execution Constraints** subsection:
- Read-only by default
- No external requests from the page
- No credential/token access (cookies, localStorage, sessionStorage)
- Scope limited to current task
- User confirmation required for DOM mutations

Also updated the tool table description, added 5 new red flags, 2 new rationalizations, and 2 new verification checklist items to reinforce the security boundaries throughout the skill.

The JS execution tool remains functional for its core debugging purpose (state inspection, DOM queries, computed values) - the constraints just prevent misuse vectors.
2026-03-28 00:25:33 -07:00
Addy Osmani 111eade87e For #7 some additional minor tweaks 2026-03-27 18:38:08 -07:00
Addy OsmaniandGitHub bfdda8d22e Merge pull request #7 from federicobartoli/feat/simplify-ignore-hooks
Add simplify-ignore hook for block-level code protection
2026-03-27 18:32:52 -07:00
Federico Bartoli 1730a69454 Add simplify-ignore hook for block-level code protection
Single bash script that prevents the model from seeing (and accidentally
simplifying) code blocks marked with simplify-ignore annotations during
/code-simplify sessions.

Hook flow:
- PreToolUse Read: backs up file, replaces blocks with BLOCK_<hash> placeholders
- PostToolUse Edit|Write: expands placeholders, applies model changes, re-filters
- Stop: restores files from backup when session ends

Features:
- Hash-based tokens (content-addressed, unambiguous round-trip)
- Multi-block support per file
- Optional reason string: /* simplify-ignore-start: perf-critical */
- Language-aware placeholders (preserves comment syntax per language)
- Glob-safe parameter expansion (Bash 3.2 compatible)
- Atomic locking with stale lock recovery
- Trailing newline preservation
- Self-healing recovery from interrupted sessions
- Cross-platform: Bash 3.2+, jq, shasum/sha1sum (macOS, Linux, Git Bash)

Implements #2
2026-03-18 05:20:14 +01:00
Addy Osmani 103124b029 Make it clearer what our slash commands offer 2026-03-15 12:23:58 -07:00
Addy Osmani 5960ad5a1e Minor formatting 2026-03-15 00:30:03 -07:00
Addy Osmani 163cb5507a Large README refactor to better educate value 2026-03-15 00:27:40 -07:00
Addy OsmaniandGitHub ae159c7bd5 Merge pull request #3 from addyosmani/code-simplify
Fixes #2 - adds code simplifier v0.1
2026-03-15 00:02:31 -07:00
Addy OsmaniandGitHub 9a74159d01 Merge pull request #4 from addyosmani/copilot/sub-pr-3
docs: add code-simplification to README
2026-03-15 00:02:17 -07:00
copilot-swe-agent[bot]andaddyosmani 653e48c698 docs: add code-simplification skill to README
Co-authored-by: addyosmani <110953+addyosmani@users.noreply.github.com>
2026-03-15 07:01:48 +00:00
copilot-swe-agent[bot] 51824d44f8 Initial plan 2026-03-15 07:00:11 +00:00
Addy Osmani d099ab7f48 Fixes #2 - adds code simplifier v0.1 2026-03-05 19:26:46 -08:00
Addy OsmaniandGitHub 82981487bc Merge pull request #1 from federicobartoli/fix/add-claude-plugin-manifest
Add Claude Code plugin support and fix stale swe-skills references
2026-03-04 15:44:57 -08:00
Federico Bartoli 0490a93323 Add Claude Code plugin manifest and marketplace catalog
Enable this repo to work as a Claude Code plugin so users can
install it via `/plugin marketplace add addyosmani/agent-skills`.

Add:
- .claude-plugin/plugin.json — plugin manifest exposing
  .claude/commands/ as namespaced slash commands under
  the agent-skills: prefix
- .claude-plugin/marketplace.json — marketplace catalog
  listing this repo as the agent-skills plugin

Fix:
- hooks/hooks.json — rewrite from deprecated flat-array format
  to the plugin-system format keyed by event type; use
  ${CLAUDE_PLUGIN_ROOT} so the hook resolves correctly when the
  plugin is installed from the marketplace into the local cache
- README — replace non-existent `claude plugin add` with the
  correct `/plugin marketplace add` workflow; document namespaced
  slash commands and --plugin-dir usage; add .claude-plugin/ to
  the project tree
2026-02-23 12:29:43 +01:00
Federico Bartoli a63f54b8ab Rename stale swe-skills references to agent-skills
The repository was renamed from swe-skills to agent-skills but
internal references were never updated. This caused:
- session-start.sh to silently fail (path using-swe-skills/ did
  not exist; the directory is using-agent-skills/)
- slash commands to invoke non-existent swe-skills: namespace
- docs and setup guides to point at the old clone URL

Rename all occurrences across 14 files: commands, CLAUDE.md,
README tree, docs/, and hooks/.
2026-02-23 12:02:07 +01:00
Addy OsmaniandClaude Opus 4.6 3e4a665e4e prepare repo for public release
Add MIT LICENSE file, CONTRIBUTING.md with skill quality guidelines,
expand .gitignore for safety, and remove leftover idea-refine.zip artifact.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:40:04 -08:00
Addy OsmaniandClaude Opus 4.6 47b65bf3cb update README with full skills reference and project overview
Rewrite README with phase-organized skills table, per-skill
descriptions, setup guides for multiple editors, design
principles, and updated project structure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:36:52 -08:00
Addy OsmaniandClaude Opus 4.6 9434558fd4 add git-workflow-and-versioning and shipping-and-launch skills
Ship phase skills covering atomic commits, branch strategy,
pre-launch checklists, and staged rollout procedures.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:36:47 -08:00
Addy OsmaniandClaude Opus 4.6 46f377adde add security-and-hardening and performance-optimization skills
Review phase skills covering OWASP Top 10 prevention, input
validation, Core Web Vitals, and measure-before-optimize discipline.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:36:43 -08:00
Addy OsmaniandClaude Opus 4.6 f977f939cd add test-driven-development skill
Verify phase skill covering TDD workflow, Prove-It pattern for
bugs, and test hierarchy guidance.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:36:40 -08:00
Addy OsmaniandClaude Opus 4.6 7ea265f17d add incremental-implementation and frontend-ui-engineering skills
Build phase skills covering thin vertical slices and
production-quality UI development patterns.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:36:36 -08:00
Addy OsmaniandClaude Opus 4.6 74445eaeda add spec-driven-development and planning-and-task-breakdown skills
Define and Plan phase skills covering structured specifications
before code and decomposing work into verifiable tasks.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-15 14:36:24 -08:00
Addy Osmani f04252ca5d add docs and adrs 2026-02-15 14:35:25 -08:00
Addy Osmani 45942b033c add debugging and errors recovery 2026-02-15 14:35:19 -08:00
Addy Osmani 9b3aa3e152 add context engineering 2026-02-15 14:35:11 -08:00
Addy Osmani 638a3f5893 add review 2026-02-15 14:35:07 -08:00
Addy Osmani b4eb0728de add ci cd 2026-02-15 14:35:03 -08:00
Addy Osmani 71aea09fb9 add using agent skills 2026-02-15 14:34:57 -08:00
Addy Osmani f53216f735 add browser testing 2026-02-15 14:34:47 -08:00
Addy Osmani af8eb3ab8a add api and interface design 2026-02-15 14:28:40 -08:00
Addy Osmani dfba53259a add references and examples 2026-02-15 14:28:33 -08:00