mirror of https://github.com/SuperClaude-Org/SuperClaude_Framework.git synced 2025-12-17 17:56:46 +00:00

refactor: PEP8 compliance - directory rename and code formatting (#425 )

* fix(orchestration): add WebFetch auto-trigger for infrastructure configuration

Problem: Infrastructure configuration changes (e.g., Traefik port settings)
were being made based on assumptions without consulting official documentation,
violating the 'Evidence > assumptions' principle in PRINCIPLES.md.

Solution:
- Added Infrastructure Configuration Validation section to MODE_Orchestration.md
- Auto-triggers WebFetch for infrastructure tools (Traefik, nginx, Docker, etc.)
- Enforces MODE_DeepResearch activation for investigation
- BLOCKS assumption-based configuration changes

Testing: Verified WebFetch successfully retrieves Traefik official docs (port 80 default)

This prevents production outages from infrastructure misconfiguration by ensuring
all technical recommendations are backed by official documentation.

* feat: Add PM Agent (Project Manager Agent) for seamless orchestration

Introduces PM Agent as the default orchestration layer that coordinates
all sub-agents and manages workflows automatically.

Key Features:
- Default orchestration: All user interactions handled by PM Agent
- Auto-delegation: Intelligent sub-agent selection based on task analysis
- Docker Gateway integration: Zero-token baseline with dynamic MCP loading
- Self-improvement loop: Automatic documentation of patterns and mistakes
- Optional override: Users can specify sub-agents explicitly if desired

Architecture:
- Agent spec: SuperClaude/Agents/pm-agent.md
- Command: SuperClaude/Commands/pm.md
- Updated docs: README.md (15→16 agents), agents.md (new Orchestration category)

User Experience:
- Default: PM Agent handles everything (seamless, no manual routing)
- Optional: Explicit --agent flag for direct sub-agent access
- Both modes available simultaneously (no user downside)

Implementation Status:
- ✅ Specification complete
- ✅ Documentation complete
- ⏳ Prototype implementation needed
- ⏳ Docker Gateway integration needed
- ⏳ Testing and validation needed

Refs: kazukinakai/docker-mcp-gateway (IRIS MCP Gateway integration)

* feat: Add Agent Orchestration rules for PM Agent default activation

Implements PM Agent as the default orchestration layer in RULES.md.

Key Changes:
- New 'Agent Orchestration' section (CRITICAL priority)
- PM Agent receives ALL user requests by default
- Manual override with @agent-[name] bypasses PM Agent
- Agent Selection Priority clearly defined:
  1. Manual override → Direct routing
  2. Default → PM Agent → Auto-delegation
  3. Delegation based on keywords, file types, complexity, context

User Experience:
- Default: PM Agent handles everything (seamless)
- Override: @agent-[name] for direct specialist access
- Transparent: PM Agent reports delegation decisions

This establishes PM Agent as the orchestration layer while
respecting existing auto-activation patterns and manual overrides.

Next Steps:
- Local testing in agiletec project
- Iteration based on actual behavior
- Documentation updates as needed

* refactor(pm-agent): redesign as self-improvement meta-layer

Problem Resolution:
PM Agent's initial design competed with existing auto-activation for task routing,
creating confusion about orchestration responsibilities and adding unnecessary complexity.

Design Change:
Redefined PM Agent as a meta-layer agent that operates AFTER specialist agents
complete tasks, focusing on:
- Post-implementation documentation and pattern recording
- Immediate mistake analysis with prevention checklists
- Monthly documentation maintenance and noise reduction
- Pattern extraction and knowledge synthesis

Two-Layer Orchestration System:
1. Task Execution Layer: Existing auto-activation handles task routing (unchanged)
2. Self-Improvement Layer: PM Agent meta-layer handles documentation (new)

Files Modified:
- SuperClaude/Agents/pm-agent.md: Complete rewrite with meta-layer design
  - Category: orchestration → meta
  - Triggers: All user interactions → Post-implementation, mistakes, monthly
  - Behavioral Mindset: Continuous learning system
  - Self-Improvement Workflow: BEFORE/DURING/AFTER/MISTAKE RECOVERY/MAINTENANCE

- SuperClaude/Core/RULES.md: Agent Orchestration section updated
  - Split into Task Execution Layer + Self-Improvement Layer
  - Added orchestration flow diagram
  - Clarified PM Agent activates AFTER task completion

- README.md: Updated PM Agent description
  - "orchestrates all interactions" → "ensures continuous learning"

- Docs/User-Guide/agents.md: PM Agent section rewritten
  - Section: Orchestration Agent → Meta-Layer Agent
  - Expertise: Project orchestration → Self-improvement workflow executor
  - Examples: Task coordination → Post-implementation documentation

- PR_DOCUMENTATION.md: Comprehensive PR documentation added
  - Summary, motivation, changes, testing, breaking changes
  - Two-layer orchestration system diagram
  - Verification checklist

Integration Validated:
Tested with agiletec project's self-improvement-workflow.md:
✅ PM Agent aligns with existing BEFORE/DURING/AFTER/MISTAKE RECOVERY phases
✅ Complements (not competes with) existing workflow
✅ agiletec workflow defines WHAT, PM Agent defines WHO executes it

Breaking Changes: None
- Existing auto-activation continues unchanged
- Specialist agents unaffected
- User workflows remain the same
- New capability: Automatic documentation and knowledge maintenance

Value Proposition:
Transforms SuperClaude into a continuously learning system that accumulates
knowledge, prevents recurring mistakes, and maintains fresh documentation
without manual intervention.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* docs: add Claude Code conversation history management research

Research covering .jsonl file structure, performance impact, and retention policies.

Content:
- Claude Code .jsonl file format and message types
- Performance issues from GitHub (memory leaks, conversation compaction)
- Retention policies (consumer vs enterprise)
- Rotation recommendations based on actual data
- File history snapshot tracking mechanics

Source: Moved from agiletec project (research applicable to all Claude Code projects)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat: add Development documentation structure

Phase 1: Documentation Structure complete

- Add Docs/Development/ directory for development documentation
- Add ARCHITECTURE.md - System architecture with PM Agent meta-layer
- Add ROADMAP.md - 5-phase development plan with checkboxes
- Add TASKS.md - Daily task tracking with progress indicators
- Add PROJECT_STATUS.md - Current status dashboard and metrics
- Add pm-agent-integration.md - Implementation guide for PM Agent mode

This establishes comprehensive documentation foundation for:
- System architecture understanding
- Development planning and tracking
- Implementation guidance
- Progress visibility

Related: #pm-agent-mode #documentation #phase-1

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat: PM Agent session lifecycle and PDCA implementation

Phase 2: PM Agent Mode Integration (Design Phase)

Commands/pm.md updates:
- Add "Always-Active Foundation Layer" concept
- Add Session Lifecycle (Session Start/During Work/Session End)
- Add PDCA Cycle (Plan/Do/Check/Act) automation
- Add Serena MCP Memory Integration (list/read/write_memory)
- Document auto-activation triggers

Agents/pm-agent.md updates:
- Add Session Start Protocol (MANDATORY auto-activation)
- Add During Work PDCA Cycle with example workflows
- Add Session End Protocol with state preservation
- Add PDCA Self-Evaluation Pattern
- Add Documentation Strategy (temp → patterns/mistakes)
- Add Memory Operations Reference

Key Features:
- Session start auto-activation for context restoration
- 30-minute checkpoint saves during work
- Self-evaluation with think_about_* operations
- Systematic documentation lifecycle
- Knowledge evolution to CLAUDE.md

Implementation Status:
- ✅ Design complete (Commands/pm.md, Agents/pm-agent.md)
- ⏳ Implementation pending (Core components)
- ⏳ Serena MCP integration pending

Salvaged from mistaken development in ~/.claude directory

Related: #pm-agent-mode #session-lifecycle #pdca-cycle #phase-2

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: disable Serena MCP auto-browser launch

Disable web dashboard and GUI log window auto-launch in Serena MCP server
to prevent intrusive browser popups on startup. Users can still manually
access the dashboard at http://localhost:24282/dashboard/ if needed.

Changes:
- Add CLI flags to Serena run command:
  - --enable-web-dashboard false
  - --enable-gui-log-window false
- Ensures Git-tracked configuration (no reliance on ~/.serena/serena_config.yml)
- Aligns with AIRIS MCP Gateway integration approach

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* refactor: rename directories to lowercase for PEP8 compliance

- Rename superclaude/Agents -> superclaude/agents
- Rename superclaude/Commands -> superclaude/commands
- Rename superclaude/Core -> superclaude/core
- Rename superclaude/Examples -> superclaude/examples
- Rename superclaude/MCP -> superclaude/mcp
- Rename superclaude/Modes -> superclaude/modes

This change follows Python PEP8 naming conventions for package directories.

* style: fix PEP8 violations and update package name to lowercase

Changes:
- Format all Python files with black (43 files reformatted)
- Update package name from 'SuperClaude' to 'superclaude' in pyproject.toml
- Fix import statements to use lowercase package name
- Add missing imports (timedelta, __version__)
- Remove old SuperClaude.egg-info directory

PEP8 violations reduced from 2672 to 701 (mostly E501 line length due to black's 88 char vs flake8's 79 char limit).

* docs: add PM Agent development documentation

Add comprehensive PM Agent development documentation:
- PM Agent ideal workflow (7-phase autonomous cycle)
- Project structure understanding (Git vs installed environment)
- Installation flow understanding (CommandsComponent behavior)
- Task management system (current-tasks.md)

Purpose: Eliminate repeated explanations and enable autonomous PDCA cycles

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(pm-agent): add self-correcting execution and warning investigation culture

## Changes

### superclaude/commands/pm.md
- Add "Self-Correcting Execution" section with root cause analysis protocol
- Add "Warning/Error Investigation Culture" section enforcing zero-tolerance for dismissal
- Define error detection protocol: STOP → Investigate → Hypothesis → Different Solution → Execute
- Document anti-patterns (retry without understanding) and correct patterns (research-first)

### docs/Development/hypothesis-pm-autonomous-enhancement-2025-10-14.md
- Add PDCA workflow hypothesis document for PM Agent autonomous enhancement

## Rationale

PM Agent must never retry failed operations without understanding root causes.
All warnings and errors require investigation via context7/WebFetch/documentation
to ensure production-quality code and prevent technical debt accumulation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* feat(installer): add airis-mcp-gateway MCP server option

## Changes

- Add airis-mcp-gateway to MCP server options in installer
- Configuration: GitHub-based installation via uvx
- Repository: https://github.com/oraios/airis-mcp-gateway
- Purpose: Dynamic MCP Gateway for zero-token baseline and on-demand tool loading

## Implementation

Added to setup/components/mcp.py self.mcp_servers dictionary with:
- install_method: github
- install_command: uvx test installation
- run_command: uvx runtime execution
- required: False (optional server)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: kazuki <kazuki@kazukinoMacBook-Air.local>
Co-authored-by: Claude <noreply@anthropic.com>

2025-10-14 08:47:09 +05:30

9.9 KiB

Raw Blame History

PM Agent Implementation Status

Last Updated: 2025-10-14 Version: 1.0.0

📋 Overview

PM Agent has been redesigned as an Always-Active Foundation Layer that provides continuous context preservation, PDCA self-evaluation, and systematic knowledge management across sessions.

✅ Implemented Features

1. Session Lifecycle (Serena MCP Memory Integration)

Status: ✅ Documented (Implementation Pending)

Session Start Protocol

Auto-Activation: PM Agent restores context at every session start
Memory Operations:
- list_memories() → Check existing state
- read_memory("pm_context") → Overall project context
- read_memory("last_session") → Previous session summary
- read_memory("next_actions") → Planned next steps
User Report: Automatic status report (前回/進捗/今回/課題)

Implementation Details: superclaude/Commands/pm.md:34-97

During Work (PDCA Cycle)

Plan Phase: Hypothesis generation with docs/temp/hypothesis-*.md
Do Phase: Experimentation with docs/temp/experiment-*.md
Check Phase: Self-evaluation with docs/temp/lessons-*.md
Act Phase: Success → docs/patterns/ | Failure → docs/mistakes/

Implementation Details: superclaude/Commands/pm.md:56-80, superclaude/Agents/pm-agent.md:48-98

Session End Protocol

Final Checkpoint: think_about_whether_you_are_done()
State Preservation: write_memory("pm_context", complete_state)
Documentation Cleanup: Temporary → Formal/Mistakes

Implementation Details: superclaude/Commands/pm.md:82-97, superclaude/Agents/pm-agent.md:100-135

2. PDCA Self-Evaluation Pattern

Status: ✅ Documented (Implementation Pending)

Plan (仮説生成)

Goal definition and success criteria
Hypothesis formulation
Risk identification

Do (実験実行)

TodoWrite task tracking
30-minute checkpoint saves
Trial-and-error recording

Check (自己評価)

think_about_task_adherence() → Pattern compliance
think_about_collected_information() → Context sufficiency
think_about_whether_you_are_done() → Completion verification

Act (改善実行)

Success → Extract pattern → docs/patterns/
Failure → Root cause analysis → docs/mistakes/
Update CLAUDE.md if global pattern

Implementation Details: superclaude/Agents/pm-agent.md:137-175

3. Documentation Strategy (Trial-and-Error to Knowledge)

Status: ✅ Documented (Implementation Pending)

Temporary Documentation (`docs/temp/`)

Purpose: Trial-and-error experimentation
Files:
- hypothesis-YYYY-MM-DD.md → Initial plan
- experiment-YYYY-MM-DD.md → Implementation log
- lessons-YYYY-MM-DD.md → Reflections
Lifecycle: 7 days → Move to formal or delete

Formal Documentation (`docs/patterns/`)

Purpose: Successful patterns ready for reuse
Trigger: Verified implementation success
Content: Clean approach + concrete examples + "Last Verified" date

Mistake Documentation (`docs/mistakes/`)

Purpose: Error records with prevention strategies
Structure:
- What Happened (現象)
- Root Cause (根本原因)
- Why Missed (なぜ見逃したか)
- Fix Applied (修正内容)
- Prevention Checklist (防止策)
- Lesson Learned (教訓)

Implementation Details: superclaude/Agents/pm-agent.md:177-235

4. Memory Operations Reference

Status: ✅ Documented (Implementation Pending)

Memory Types

Session Start: pm_context, last_session, next_actions
During Work: plan, checkpoint, decision
Self-Evaluation: think_about_* operations
Session End: last_session, next_actions, pm_context

Implementation Details: superclaude/Agents/pm-agent.md:237-267

🚧 Pending Implementation

1. Serena MCP Memory Operations

Required Actions:

Implement list_memories() integration
Implement read_memory(key) integration
Implement write_memory(key, value) integration
Test memory persistence across sessions

Blockers: Requires Serena MCP server configuration

2. PDCA Think Operations

Required Actions:

Implement think_about_task_adherence() hook
Implement think_about_collected_information() hook
Implement think_about_whether_you_are_done() hook
Integrate with TodoWrite completion tracking

Blockers: Requires Serena MCP server configuration

3. Documentation Directory Structure

Required Actions:

Create docs/temp/ directory template
Create docs/patterns/ directory template
Create docs/mistakes/ directory template
Implement automatic file lifecycle management (7-day cleanup)

Blockers: None (can be implemented immediately)

4. Auto-Activation at Session Start

Required Actions:

Implement PM Agent auto-activation hook
Integrate with Claude Code session lifecycle
Test context restoration across sessions
Verify "前回/進捗/今回/課題" report generation

Blockers: Requires understanding of Claude Code initialization hooks

📊 Implementation Roadmap

Phase 1: Documentation Structure (Immediate)

Timeline: 1-2 days Complexity: Low

Create docs/temp/, docs/patterns/, docs/mistakes/ directories
Add README.md to each directory explaining purpose
Create template files for hypothesis/experiment/lessons

Phase 2: Serena MCP Integration (High Priority)

Timeline: 1 week Complexity: Medium

Configure Serena MCP server
Implement memory operations (read/write/list)
Test memory persistence
Integrate with PM Agent workflow

Phase 3: PDCA Think Operations (High Priority)

Timeline: 1 week Complexity: Medium

Implement think_about_* hooks
Integrate with TodoWrite
Test self-evaluation flow
Document best practices

Phase 4: Auto-Activation (Critical)

Timeline: 2 weeks Complexity: High

Research Claude Code initialization hooks
Implement PM Agent auto-activation
Test session start protocol
Verify context restoration

Phase 5: Documentation Lifecycle (Medium Priority)

Timeline: 3-5 days Complexity: Low

Implement 7-day temporary file cleanup
Create docs/temp → docs/patterns migration script
Create docs/temp → docs/mistakes migration script
Automate "Last Verified" date updates

🔍 Testing Strategy

Unit Tests

Memory operations (read/write/list)
Think operations (task_adherence/collected_information/done)
File lifecycle management (7-day cleanup)

Integration Tests

Session start → context restoration → user report
PDCA cycle → temporary docs → formal docs
Mistake detection → root cause analysis → prevention checklist

E2E Tests

Full session lifecycle (start → work → end)
Cross-session context preservation
Knowledge accumulation over time

📖 Documentation Updates Needed

SuperClaude Framework

superclaude/Commands/pm.md - Updated with session lifecycle
superclaude/Agents/pm-agent.md - Updated with PDCA and memory operations
docs/ARCHITECTURE.md - Add PM Agent architecture section
docs/GETTING_STARTED.md - Add PM Agent usage examples

Global CLAUDE.md (Future)

Add PM Agent PDCA cycle to global rules
Document session lifecycle best practices
Add memory operations reference

🐛 Known Issues

Issue 1: Serena MCP Not Configured

Status: Blocker Impact: High (prevents memory operations) Resolution: Configure Serena MCP server in project

Issue 2: Auto-Activation Hook Unknown

Status: Research Needed Impact: High (prevents session start automation) Resolution: Research Claude Code initialization hooks

Issue 3: Documentation Directory Structure Missing

Status: Can Implement Immediately Impact: Medium (prevents PDCA documentation flow) Resolution: Create directory structure (Phase 1)

📈 Success Metrics

Quantitative

Context Restoration Rate: 100% (sessions resume without re-explanation)
Documentation Coverage: >80% (implementations documented)
Mistake Prevention: <10% (recurring mistakes)
Session Continuity: >90% (successful checkpoint restorations)

Qualitative

Users never re-explain project context
Knowledge accumulates systematically
Mistakes documented with prevention checklists
Documentation stays fresh (Last Verified dates)

🎯 Next Steps

Immediate: Create documentation directory structure (Phase 1)
High Priority: Configure Serena MCP server (Phase 2)
High Priority: Implement PDCA think operations (Phase 3)
Critical: Research and implement auto-activation (Phase 4)
Medium Priority: Implement documentation lifecycle automation (Phase 5)

📚 References

PM Agent Command: superclaude/Commands/pm.md
PM Agent Persona: superclaude/Agents/pm-agent.md
Salvaged Changes: tmp/salvaged-pm-agent/
Original Patches: tmp/salvaged-pm-agent/*.patch

🔐 Commit Information

Branch: master Salvaged From: /Users/kazuki/.claude (mistaken development location) Integration Date: 2025-10-14 Status: Documentation complete, implementation pending

Git Operations:

# Salvaged valuable changes to tmp/
cp ~/.claude/Commands/pm.md tmp/salvaged-pm-agent/pm.md
cp ~/.claude/agents/pm-agent.md tmp/salvaged-pm-agent/pm-agent.md
git diff ~/.claude/CLAUDE.md > tmp/salvaged-pm-agent/CLAUDE.md.patch
git diff ~/.claude/RULES.md > tmp/salvaged-pm-agent/RULES.md.patch

# Cleaned up .claude directory
cd ~/.claude && git reset --hard HEAD
cd ~/.claude && rm -rf .git

# Applied changes to SuperClaude_Framework
cp tmp/salvaged-pm-agent/pm.md superclaude/Commands/pm.md
cp tmp/salvaged-pm-agent/pm-agent.md superclaude/Agents/pm-agent.md

Last Verified: 2025-10-14 Next Review: 2025-10-21 (1 week)

9.9 KiB Raw Blame History

PM Agent Implementation Status

📋 Overview

✅ Implemented Features

1. Session Lifecycle (Serena MCP Memory Integration)

Session Start Protocol

During Work (PDCA Cycle)

Session End Protocol

2. PDCA Self-Evaluation Pattern

Plan (仮説生成)

Do (実験実行)

Check (自己評価)

Act (改善実行)

3. Documentation Strategy (Trial-and-Error to Knowledge)

Temporary Documentation (docs/temp/)

Formal Documentation (docs/patterns/)

Mistake Documentation (docs/mistakes/)

4. Memory Operations Reference

Memory Types

🚧 Pending Implementation

1. Serena MCP Memory Operations

2. PDCA Think Operations

3. Documentation Directory Structure

4. Auto-Activation at Session Start

📊 Implementation Roadmap

Phase 1: Documentation Structure (Immediate)

Phase 2: Serena MCP Integration (High Priority)

Phase 3: PDCA Think Operations (High Priority)

Phase 4: Auto-Activation (Critical)

Phase 5: Documentation Lifecycle (Medium Priority)

🔍 Testing Strategy

Unit Tests

Integration Tests

E2E Tests

📖 Documentation Updates Needed

SuperClaude Framework

Global CLAUDE.md (Future)

🐛 Known Issues

Issue 1: Serena MCP Not Configured

Issue 2: Auto-Activation Hook Unknown

Issue 3: Documentation Directory Structure Missing

📈 Success Metrics

Quantitative

Qualitative

🎯 Next Steps

📚 References

🔐 Commit Information

9.9 KiB

Raw Blame History

Temporary Documentation (`docs/temp/`)

Formal Documentation (`docs/patterns/`)

Mistake Documentation (`docs/mistakes/`)