mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
AI sidecar failures reached Sentry as 'Error: Error': the scrubber type-onlys plain Errors and the tool wrappers threw them from result.error. The bridge now exports toSidecarError(), wrapping the sidecar reason in a SafeError (memory-allocation text classifies as operational, the rest as bug); all 14 wrappers use it, plus the dispatcher crash/stdin/spawn rejection paths and parseStdoutJson. toBgRemovalError from #535 delegates to the shared helper. On the web side, DOMExceptions report their specific name via err.name, so the NATIVE_ERRORS allowlist dropped the whole family's browser-authored messages. It now carries the full WebIDL DOMException name table; messages still pass through url/path redaction. Bridge-mocking test files switched to importOriginal passthrough mocks.
141 lines
5.5 KiB
TypeScript
141 lines
5.5 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
buildWebBeforeSend,
|
|
DENY_URLS,
|
|
IGNORE_ERRORS,
|
|
scrubBrowserMessage,
|
|
} from "@/lib/sentry-scrub";
|
|
|
|
describe("scrubBrowserMessage", () => {
|
|
it("keeps browser-native messages with urls/paths redacted", () => {
|
|
expect(scrubBrowserMessage("TypeError", "Failed to fetch https://intra.host/x?q=1")).toBe(
|
|
"Failed to fetch <url>",
|
|
);
|
|
expect(scrubBrowserMessage("TypeError", "cannot read /Users/bob/file.png")).toBe(
|
|
"cannot read <path>",
|
|
);
|
|
expect(scrubBrowserMessage("RangeError", "Invalid array length")).toBe("Invalid array length");
|
|
});
|
|
|
|
it("redacts blob urls and windows paths", () => {
|
|
expect(scrubBrowserMessage("DOMException", "load blob:http://x/abc failed")).toBe(
|
|
"load <blob> failed",
|
|
);
|
|
expect(scrubBrowserMessage("TypeError", "open C:\\Users\\bob\\tax.pdf")).toBe("open <path>");
|
|
});
|
|
|
|
it("drops messages for non-native error names", () => {
|
|
expect(scrubBrowserMessage("CustomerDataError", "contains secret.pdf")).toBeNull();
|
|
});
|
|
|
|
// DOMExceptions report their specific name ("NotFoundError"), not
|
|
// "DOMException", so listing only the base name dropped the diagnostic
|
|
// browser message for the whole family (WEB-3/4/6 showed as
|
|
// "NotFoundError: NotFoundError" with no way to tell which DOM call failed).
|
|
it("keeps messages for specific DOMException names, still redacted", () => {
|
|
expect(
|
|
scrubBrowserMessage(
|
|
"NotFoundError",
|
|
"Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.",
|
|
),
|
|
).toBe(
|
|
"Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.",
|
|
);
|
|
expect(scrubBrowserMessage("InvalidStateError", "The object is in an invalid state.")).toBe(
|
|
"The object is in an invalid state.",
|
|
);
|
|
expect(scrubBrowserMessage("NotAllowedError", "Write permission denied.")).toBe(
|
|
"Write permission denied.",
|
|
);
|
|
expect(scrubBrowserMessage("NotReadableError", "error reading /Users/bob/file.png")).toBe(
|
|
"error reading <path>",
|
|
);
|
|
expect(scrubBrowserMessage("DataCloneError", "could not be cloned.")).toBe(
|
|
"could not be cloned.",
|
|
);
|
|
});
|
|
});
|
|
|
|
describe("static filter lists", () => {
|
|
it("deny extension frames and ignore noisy network errors", () => {
|
|
expect(DENY_URLS.some((re) => re.test("chrome-extension://abcdef/content.js"))).toBe(true);
|
|
expect(DENY_URLS.some((re) => re.test("moz-extension://abcdef/content.js"))).toBe(true);
|
|
expect(IGNORE_ERRORS).toContain("Failed to fetch");
|
|
expect(IGNORE_ERRORS).toContain("Load failed");
|
|
});
|
|
});
|
|
|
|
describe("buildWebBeforeSend", () => {
|
|
const baseEvent = (over: Record<string, any> = {}): Record<string, any> => ({
|
|
request: { url: "http://192.168.0.4:1349/image/resize" },
|
|
breadcrumbs: [{}],
|
|
user: { id: "x" },
|
|
contexts: { react: { componentStack: "at ToolPage" }, device: { name: "leak" } },
|
|
exception: {
|
|
values: [
|
|
{
|
|
type: "TypeError",
|
|
value: "secret /Users/a/b",
|
|
stacktrace: { frames: [{ filename: "http://192.168.0.4:1349/assets/app.js" }] },
|
|
},
|
|
],
|
|
},
|
|
tags: { tool_id: "resize", drop_me: "x" },
|
|
...over,
|
|
});
|
|
|
|
it("gates, strips, keeps react componentStack, redacts values", () => {
|
|
const send = buildWebBeforeSend(() => true);
|
|
const out = send(baseEvent(), { originalException: new TypeError("boom /Users/a/b") })!;
|
|
expect(out.request).toBeUndefined();
|
|
expect(out.user).toBeUndefined();
|
|
expect(out.contexts.react.componentStack).toBe("at ToolPage");
|
|
expect(out.contexts.device).toBeUndefined();
|
|
expect(out.exception.values[0].value).toBe("boom <path>");
|
|
expect(out.exception.values[0].stacktrace.frames[0].filename).toBe("/assets/app.js");
|
|
expect(out.tags.tool_id).toBe("resize");
|
|
expect(out.tags.drop_me).toBeUndefined();
|
|
expect(buildWebBeforeSend(() => false)(baseEvent(), {})).toBeNull();
|
|
});
|
|
|
|
it("keeps the breadcrumb trail, redacting urls but keeping safe fetch status/method", () => {
|
|
const send = buildWebBeforeSend(() => true);
|
|
const out = send(
|
|
baseEvent({
|
|
breadcrumbs: [
|
|
{
|
|
message: "fetch https://host/user.png",
|
|
category: "fetch",
|
|
data: { url: "https://host/user.png", status_code: 500, method: "POST" },
|
|
},
|
|
{ message: "open /Users/a/secret.pdf", category: "console", level: "warning" },
|
|
],
|
|
}),
|
|
{},
|
|
)!;
|
|
expect(out.breadcrumbs).toEqual([
|
|
{ message: "fetch <url>", category: "fetch", data: { status_code: 500, method: "POST" } },
|
|
{ message: "open <path>", category: "console", level: "warning" },
|
|
]);
|
|
});
|
|
|
|
it("falls back to type-only for non-native exceptions without a rebuild", () => {
|
|
const send = buildWebBeforeSend(() => true);
|
|
const custom = Object.assign(new Error("user secret"), { name: "WeirdLibError" });
|
|
const out = send(baseEvent(), { originalException: custom })!;
|
|
expect(out.exception.values[0].value).toBe("TypeError");
|
|
});
|
|
|
|
it("enforces the 500-per-hour ceiling", () => {
|
|
const send = buildWebBeforeSend(() => true);
|
|
for (let i = 0; i < 500; i++) expect(send(baseEvent(), {})).not.toBeNull();
|
|
expect(send(baseEvent(), {})).toBeNull();
|
|
});
|
|
|
|
it("never throws on malformed events", () => {
|
|
const send = buildWebBeforeSend(() => true);
|
|
expect(() => send({} as Record<string, any>, {})).not.toThrow();
|
|
expect(() => send({ exception: { values: null } } as any, {})).not.toThrow();
|
|
});
|
|
});
|