Files
SnapOtter/tests/integration/tools/video/video-to-gif.test.ts
T
SnapOtterandGitHub d10d0f544f fix: release QA hardening across processing, media, security, and CI gates (#649)
A release-readiness QA pass over the whole product. The commits split into
defects a user would hit and gates that were reporting green while measuring
nothing.

## Fixes that change behaviour

Rate limiting was bypassable on every install: TRUST_PROXY defaulted to true, so
request.ip came from a client-set header and a forged X-Forwarded-For got past
the login limiter. The default is now a private-network trust list.

A transient Postgres outage stranded in-flight jobs, leaving finished output on
disk with no row pointing at it. A reconciler now resolves those rows and adopts
the bytes rather than dropping the work.

A Redis connection that moved to a new address wedged every read-blocked
consumer, so completions stopped signalling while health still answered 200.
Socket timeouts plus subscriber pings recover it.

Installing more than one AI bundle left the shared venv multi-versioned and
silently broke three tools. The installer now reconciles distributions to one
version each.

Converting an image to JXL at quality 1 through 4 returned a 500, because
libjxl 0.7 rejects the distance those values compute. The quality is floored at
what the encoder honours. A missing ffmpeg was also reported to the user as a
corrupt upload; it now says the engine is unavailable.

RAW uploads reached an unpatched LibRaw on arm64, so it is built from source at
0.22.2, and the release scan was split so it can fail on an unfixed critical
instead of hiding it behind ignore-unfixed.

## Gates that could not fail

Two mutation lanes ran zero mutants because Stryker crawled the gitignored docs
build; coverage discarded its whole report on any failing test; the lint gate
skipped root tests, scripts, and two workspaces; and several generated matrices
counted a host missing ffmpeg as a passing tool. Each now measures what it
claims.

Full evidence and the outstanding release items are tracked locally and are not
part of this branch.
2026-07-27 15:37:30 +08:00

119 lines
4.7 KiB
TypeScript

import { mkdtemp, readFile, rm } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { ffmpegAvailable } from "@snapotter/media-engine";
import sharp from "sharp";
import { afterAll, beforeAll, describe, expect, it } from "vitest";
import { InputValidationError } from "../../../../apps/api/src/modality/contract.js";
import { getToolConfig } from "../../../../apps/api/src/routes/tool-factory.js";
import { fixtures, readFixture } from "../../../fixtures/index.js";
import {
buildTestApp,
createMultipartPayload,
loginAsAdmin,
type TestApp,
} from "../../test-server.js";
const MP4 = readFixture(fixtures.video.tiny("mp4"));
let testApp: TestApp;
let adminToken: string;
beforeAll(async () => {
testApp = await buildTestApp();
adminToken = await loginAsAdmin(testApp.app);
}, 30_000);
afterAll(async () => {
await testApp.cleanup();
}, 10_000);
async function pollJob(jobId: string) {
const { db, schema } = await import("../../../../apps/api/src/db/index.js");
const { eq } = await import("drizzle-orm");
let row: { status: string; outputRefs: unknown } | undefined;
for (let i = 0; i < 120; i++) {
[row] = await db.select().from(schema.jobs).where(eq(schema.jobs.id, jobId));
if (row && ["completed", "failed", "canceled"].includes(row.status)) break;
await new Promise((r) => setTimeout(r, 500));
}
return row;
}
describe.skipIf(!ffmpegAvailable())("video-to-gif (requires ffmpeg)", () => {
it("normalizes sub-microsecond offsets instead of emitting exponential ffmpeg syntax", async () => {
const config = getToolConfig("video-to-gif");
if (!config?.processV2) throw new Error("video-to-gif processV2 must be registered");
const scratchDir = await mkdtemp(join(tmpdir(), "snapotter-video-to-gif-test-"));
try {
const result = await config.processV2({
inputs: [{ buffer: MP4, filename: "tiny.mp4", ref: "test/tiny.mp4" }],
settings: { fps: 1, width: 120, startS: Number.MIN_VALUE, durationS: 1 },
scratchDir,
signal: new AbortController().signal,
report: () => undefined,
});
if (!result.scratchPath) throw new Error("video-to-gif must return a scratch path");
const output = await readFile(result.scratchPath);
expect(output.subarray(0, 4).toString("ascii")).toBe("GIF8");
} finally {
await rm(scratchDir, { recursive: true, force: true });
}
});
it("rejects a start time beyond the video instead of running an empty encode", async () => {
const config = getToolConfig("video-to-gif");
if (!config?.processV2) throw new Error("video-to-gif processV2 must be registered");
const processV2 = config.processV2;
const scratchDir = await mkdtemp(join(tmpdir(), "snapotter-video-to-gif-test-"));
try {
await expect(
processV2({
inputs: [{ buffer: MP4, filename: "tiny.mp4", ref: "test/tiny.mp4" }],
settings: { fps: 1, width: 672, startS: 2, durationS: 1 },
scratchDir,
signal: new AbortController().signal,
report: () => undefined,
}),
).rejects.toBeInstanceOf(InputValidationError);
} finally {
await rm(scratchDir, { recursive: true, force: true });
}
});
it("returns 202 (long hint) and produces a GIF with GIF8 magic", async () => {
const { body, contentType } = createMultipartPayload([
{ name: "file", filename: "tiny.mp4", contentType: "video/mp4", content: MP4 },
{ name: "settings", content: JSON.stringify({ fps: 8, width: 120, durationS: 1 }) },
]);
const res = await testApp.app.inject({
method: "POST",
url: "/api/v1/tools/video/video-to-gif",
headers: { authorization: `Bearer ${adminToken}`, "content-type": contentType },
body,
});
expect(res.statusCode).toBe(202);
const { jobId } = JSON.parse(res.body);
const row = await pollJob(jobId);
expect(row?.status).toBe("completed");
const outputRefs = (row?.outputRefs ?? []) as string[];
const outName = outputRefs[0].split("/").pop() as string;
expect(outName.endsWith(".gif")).toBe(true);
const dl = await testApp.app.inject({
method: "GET",
url: `/api/v1/download/${jobId}/${encodeURIComponent(outName)}`,
});
expect(dl.statusCode).toBe(200);
// GIF files start with GIF8 magic bytes
const magic = dl.rawPayload.subarray(0, 4).toString("ascii");
expect(magic).toBe("GIF8");
// Decode the payload and confirm it is an animated GIF at the requested width.
const meta = await sharp(dl.rawPayload, { animated: true }).metadata();
expect(meta.format).toBe("gif");
expect(meta.width).toBe(120);
expect((meta.pages ?? 1) > 1).toBe(true);
}, 90_000);
});