mirror of
https://github.com/snapotter-hq/SnapOtter.git
synced 2026-08-03 07:46:42 +02:00
Editing a file from the library used to silently supersede it: the worker auto-saved every result as a new version and the leaf-only listing hid the original, which read as a destructive overwrite. Tool pages now show a per-edit choice for library-sourced files. The default saves the result as an independent new file and keeps the original; picking overwrite keeps the old superseding-version behavior. The client sends a saveMode multipart field next to fileId, validated with a 400 on unknown values, and autoSaveToLibrary branches on it. Every hand-written route that honors fileId parses the field the same way as the factory. The review panel shows where an auto-saved result went instead of offering a second, duplicate save. Tools whose route or submitter ignores fileId keep the selector hidden via a shared unsupported-tools set, and the choice resets to the non-destructive default whenever a new file is staged. Closes #495
100 lines
3.6 KiB
TypeScript
100 lines
3.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { cleanup, fireEvent, render, screen } from "@testing-library/react";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
vi.stubGlobal("URL", {
|
|
...globalThis.URL,
|
|
createObjectURL: vi.fn(() => "blob:fake-url"),
|
|
revokeObjectURL: vi.fn(),
|
|
});
|
|
|
|
vi.mock("@/lib/image-preview", () => ({
|
|
needsServerPreview: vi.fn(() => false),
|
|
fetchDecodedPreview: vi.fn(() => Promise.resolve(null)),
|
|
}));
|
|
|
|
vi.mock("@/lib/analytics", () => ({
|
|
track: vi.fn(),
|
|
}));
|
|
|
|
import { LibrarySaveModeSelector } from "@/components/common/library-save-mode-selector";
|
|
import { useFileStore } from "@/stores/file-store";
|
|
|
|
function makeFile(name: string): File {
|
|
return new File([new ArrayBuffer(64)], name, { type: "image/png" });
|
|
}
|
|
|
|
function stageLibraryFile() {
|
|
useFileStore.getState().setFiles([makeFile("photo.png")]);
|
|
useFileStore.getState().updateEntry(0, { serverFileId: "lib-1" });
|
|
}
|
|
|
|
describe("LibrarySaveModeSelector", () => {
|
|
beforeEach(() => {
|
|
useFileStore.getState().reset();
|
|
});
|
|
|
|
afterEach(() => {
|
|
cleanup();
|
|
});
|
|
|
|
it("renders nothing when the selected file is not from the library", () => {
|
|
useFileStore.getState().setFiles([makeFile("plain.png")]);
|
|
const { container } = render(<LibrarySaveModeSelector toolId="resize" />);
|
|
expect(container.innerHTML).toBe("");
|
|
});
|
|
|
|
it("shows both choices with 'save as new' selected by default", () => {
|
|
stageLibraryFile();
|
|
render(<LibrarySaveModeSelector toolId="resize" />);
|
|
|
|
const saveAsNew = screen.getByRole("radio", { name: /save result as a new file/i });
|
|
const overwrite = screen.getByRole("radio", { name: /overwrite the original/i });
|
|
expect((saveAsNew as HTMLInputElement).checked).toBe(true);
|
|
expect((overwrite as HTMLInputElement).checked).toBe(false);
|
|
});
|
|
|
|
it("updates the store when overwrite is chosen", () => {
|
|
stageLibraryFile();
|
|
render(<LibrarySaveModeSelector toolId="resize" />);
|
|
|
|
fireEvent.click(screen.getByRole("radio", { name: /overwrite the original/i }));
|
|
|
|
expect(useFileStore.getState().librarySaveMode).toBe("overwrite");
|
|
});
|
|
|
|
it("disables the choice while processing", () => {
|
|
stageLibraryFile();
|
|
useFileStore.getState().setProcessing(true);
|
|
render(<LibrarySaveModeSelector toolId="resize" />);
|
|
|
|
const saveAsNew = screen.getByRole("radio", { name: /save result as a new file/i });
|
|
const overwrite = screen.getByRole("radio", { name: /overwrite the original/i });
|
|
expect((saveAsNew as HTMLInputElement).disabled).toBe(true);
|
|
expect((overwrite as HTMLInputElement).disabled).toBe(true);
|
|
});
|
|
|
|
it("renders nothing for tools that do not honor the save mode", () => {
|
|
stageLibraryFile();
|
|
const { container } = render(<LibrarySaveModeSelector toolId="watermark-image" />);
|
|
expect(container.innerHTML).toBe("");
|
|
});
|
|
|
|
it("renders nothing when multiple files would go through the batch path", () => {
|
|
useFileStore.getState().setFiles([makeFile("a.png"), makeFile("b.png")]);
|
|
useFileStore.getState().updateEntry(0, { serverFileId: "lib-1" });
|
|
useFileStore.getState().updateEntry(1, { serverFileId: "lib-2" });
|
|
|
|
const { container } = render(<LibrarySaveModeSelector toolId="compress" />);
|
|
expect(container.innerHTML).toBe("");
|
|
});
|
|
|
|
it("still renders for multi-input tools that process all files in one run", () => {
|
|
useFileStore.getState().setFiles([makeFile("a.pdf"), makeFile("b.pdf")]);
|
|
useFileStore.getState().updateEntry(0, { serverFileId: "lib-1" });
|
|
|
|
render(<LibrarySaveModeSelector toolId="merge-pdf" />);
|
|
expect(screen.getByRole("radio", { name: /save result as a new file/i })).toBeDefined();
|
|
});
|
|
});
|