External/SnapOtter
1
0
Fork 0
mirror of https://github.com/snapotter-hq/SnapOtter.git synced 2026-08-03 07:46:42 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): narrow friendlyError matching to avoid collapsing valid messages

Browse Source 
The raw-dump detector matched broad content keywords ('conversion failed', 'pixel format', bare 'ffprobe') that appear in legitimate validation messages (e.g. 'SVG conversion failed'), which would wrongly collapse them to the generic error. Narrow it to the unambiguous 'ffmpeg/ffprobe exited N:' prefix, python tracebacks, and crashes; longer/multi-line raw dumps are still caught by the length/line-count check. Found during self-review.
This commit is contained in:
SnapOtter
2026-06-17 14:28:41 +08:00
parent e52e0bb3d5
commit 6220885e0c
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/api/src/lib/errors.ts
+7 -4
View File
@@ -15,12 +15,15 @@ export function stripInternalPaths(message: string): string {
}
/**
* Markers of a raw external-tool failure dump (ffmpeg/ffprobe/libvpx/x264/
* LibreOffice/ghostscript/qpdf/python traceback). These messages are meant for
* server logs, never for end users.
* Unambiguous markers of a raw external-tool failure dump: the
* `ffmpeg/ffprobe exited N:` prefix that media-engine throws, a Python
* traceback, or a crash. These are matched precisely (not by content
* keywords like "pixel format" or "conversion failed", which can appear in
* legitimate validation messages) -- longer or multi-line raw dumps are
* caught separately by the length/line-count check below.
*/
const RAW_TOOL_FAILURE =
/ffmpeg exited|ffprobe|conversion failed|libvpx|x26[45] \[|stream mapping|pixel format|could not open encoder|segmentation fault|core dump|traceback \(most recent|gs: |libreoffice|qpdf:/i;
/ff(?:mpeg|probe) exited \d|traceback \(most recent call|segmentation fault|core dumped/i;
/**
* Produce a user-safe error detail. Intentional validation messages (short,