Malin/domnitor
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Enforce user-specific data access for all users

Browse Source 
Refactored controllers and models to always filter data by user ID, removing admin bypass logic. This ensures all statistics, groups, domains, and tags are user-specific regardless of isolation mode, improving data isolation and security.
This commit is contained in:
Hosteroid
2025-10-20 18:03:16 +03:00
parent 011fab095e
commit c387e90a19
5 changed files with 22 additions and 41 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/Models/Domain.php
View File

@@ -25,8 +25,8 @@ class Domain extends Model
FROM domains d
LEFT JOIN notification_groups ng ON d.notification_group_id = ng.id";
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
$sql .= " WHERE d.user_id = ?";
if ($userId) {
$sql .= " WHERE d.user_id = ? ORDER BY d.status DESC, d.expiration_date ASC";
$stmt = $this->db->prepare($sql);
$stmt->execute([$userId]);
} else {
@@ -52,7 +52,7 @@ class Domain extends Model
$params = [$days];
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
if ($userId) {
$sql .= " AND d.user_id = ?";
$params[] = $userId;
}
@@ -76,7 +76,7 @@ class Domain extends Model
$params = [$status];
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
if ($userId) {
$sql .= " AND d.user_id = ?";
$params[] = $userId;
}
@@ -140,7 +140,7 @@ class Domain extends Model
$params = [];
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
if ($userId) {
$sql .= " AND d.user_id = ?";
$params[] = $userId;
}
@@ -170,7 +170,7 @@ class Domain extends Model
$whereClause = "WHERE is_active = 1";
$params = [];
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
if ($userId) {
$whereClause .= " AND user_id = ?";
$params[] = $userId;
}
@@ -191,7 +191,7 @@ class Domain extends Model
$inactiveWhereClause = "WHERE is_active = 0";
$inactiveParams = [];
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
if ($userId) {
$inactiveWhereClause .= " AND user_id = ?";
$inactiveParams[] = $userId;
}
@@ -372,7 +372,7 @@ class Domain extends Model
$params = ['%' . $query . '%', '%' . $query . '%', '%' . $query . '%'];
if ($userId && !$this->getUserModel()->isAdmin($userId)) {
if ($userId) {
$sql .= " AND d.user_id = ?";
$params[] = $userId;
}