Malin/DomGod
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: retry https on ConnectTimeout, not just ConnectError

Browse Source 
Port 80 is often firewalled (drops packets → ConnectTimeout) rather than
refused (ConnectError). Previously ConnectTimeout hit the generic except
branch and broke without trying https, marking everything dead.

Now ConnectError + RemoteProtocolError + ConnectTimeout all trigger an
https retry. ReadTimeout still marks dead (server responded on connect
but was too slow).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Malin
2026-04-20 19:42:10 +02:00
parent b53545b7dd
commit 54c781773d
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/validator.py
View File

@@ -152,14 +152,15 @@ async def _check_domain(domain: str) -> dict:
result["prescreen_status"] = "live" result["prescreen_status"] = "live"
return result return result
except (httpx.ConnectError, httpx.RemoteProtocolError) as e: except (httpx.ConnectError, httpx.RemoteProtocolError, httpx.ConnectTimeout) as e:
# Port refused or bad HTTP response → server may be https-only, try it # Port refused, wrong protocol, or port 80 firewalled/timed-out
# → server may be https-only, always retry on 443
if scheme == "http": if scheme == "http":
logger.debug("Validator %s: %s on http, trying https", domain, type(e).__name__) logger.debug("Validator %s: %s on http, trying https", domain, type(e).__name__)
continue continue
break break
except Exception as e: except Exception as e:
# Timeout or other error → https won't help, mark dead # ReadTimeout or other error — connected but server too slow; mark dead
logger.debug("Validator %s (%s): %s", domain, scheme, type(e).__name__) logger.debug("Validator %s (%s): %s", domain, scheme, type(e).__name__)
break break