External/wp-graphql-woocommerce
1
0
Fork 0
mirror of https://github.com/wp-graphql/wp-graphql-woocommerce.git synced 2026-08-14 12:53:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Sanitize ProductAttribute name to match VariationAttribute [#965] (#966)

Browse Source 
* fix: Sanitize ProductAttribute name to match VariationAttribute [#965]

* devops: add unit test for attribute name consistency between product and variation (#965)

* devops: fix phpcov merge by using .cov extension and pinning phpcov to v8

* chore: Lintercompliances met

* fix: update test expectation for sanitized local attribute name

---------

Co-authored-by: Geoff Taylor <geoff@axistaylor.com>
This commit is contained in:
Pascal Martineau
2026-03-26 20:10:08 -04:00
committed by GitHub
co-authored by Geoff Taylor
parent ef26bb2479
commit 974393aeeb
4 changed files with 92 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/continous-integration.yml
+11 -11
View File
@@ -62,7 +62,7 @@ jobs:
WP_VERSION: ${{ matrix.wordpress }}
PHP_VERSION: ${{ matrix.php }}
run: |
HPOS="${{ matrix.hpos }}" FILTER="acceptance --fail-fast ${{ matrix.coverage == true && '--coverage=acceptance.serialized' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
HPOS="${{ matrix.hpos }}" FILTER="acceptance --fail-fast ${{ matrix.coverage == true && '--coverage=acceptance.cov' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
- name: Retry on failure
id: retry
@@ -72,7 +72,7 @@ jobs:
WP_VERSION: ${{ matrix.wordpress }}
PHP_VERSION: ${{ matrix.php }}
run: |
HPOS="${{ matrix.hpos }}" FILTER="acceptance ${{ matrix.coverage == true && '--coverage=acceptance.serialized' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
HPOS="${{ matrix.hpos }}" FILTER="acceptance ${{ matrix.coverage == true && '--coverage=acceptance.cov' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
- name: Fail if both attempts failed
if: ${{ steps.tests.outcome == 'failure' && steps.retry.outcome == 'failure' }}
@@ -83,7 +83,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: coverage-acceptance
path: tests/_output/acceptance.serialized
path: tests/_output/acceptance.cov
if-no-files-found: ignore
functional:
@@ -133,7 +133,7 @@ jobs:
WP_VERSION: ${{ matrix.wordpress }}
PHP_VERSION: ${{ matrix.php }}
run: |
HPOS="${{ matrix.hpos }}" FILTER="functional --fail-fast ${{ matrix.coverage == true && '--coverage=functional.serialized' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
HPOS="${{ matrix.hpos }}" FILTER="functional --fail-fast ${{ matrix.coverage == true && '--coverage=functional.cov' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
- name: Retry on failure
id: retry
@@ -143,7 +143,7 @@ jobs:
WP_VERSION: ${{ matrix.wordpress }}
PHP_VERSION: ${{ matrix.php }}
run: |
HPOS="${{ matrix.hpos }}" FILTER="functional ${{ matrix.coverage == true && '--coverage=functional.serialized' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
HPOS="${{ matrix.hpos }}" FILTER="functional ${{ matrix.coverage == true && '--coverage=functional.cov' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
- name: Fail if both attempts failed
if: ${{ steps.tests.outcome == 'failure' && steps.retry.outcome == 'failure' }}
@@ -154,7 +154,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: coverage-functional
path: tests/_output/functional.serialized
path: tests/_output/functional.cov
if-no-files-found: ignore
wpunit:
@@ -204,7 +204,7 @@ jobs:
WP_VERSION: ${{ matrix.wordpress }}
PHP_VERSION: ${{ matrix.php }}
run: |
HPOS="${{ matrix.hpos }}" FILTER="wpunit --fail-fast ${{ matrix.coverage == true && '--coverage=wpunit.serialized' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
HPOS="${{ matrix.hpos }}" FILTER="wpunit --fail-fast ${{ matrix.coverage == true && '--coverage=wpunit.cov' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
- name: Retry on failure
id: retry
@@ -214,7 +214,7 @@ jobs:
WP_VERSION: ${{ matrix.wordpress }}
PHP_VERSION: ${{ matrix.php }}
run: |
HPOS="${{ matrix.hpos }}" FILTER="wpunit ${{ matrix.coverage == true && '--coverage=wpunit.serialized' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
HPOS="${{ matrix.hpos }}" FILTER="wpunit ${{ matrix.coverage == true && '--coverage=wpunit.cov' || '' }} ${{ matrix.debug }}" composer dRunTestStandalone
- name: Fail if both attempts failed
if: ${{ steps.tests.outcome == 'failure' && steps.retry.outcome == 'failure' }}
@@ -225,7 +225,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: coverage-wpunit
path: tests/_output/wpunit.serialized
path: tests/_output/wpunit.cov
if-no-files-found: ignore
coverage:
@@ -248,7 +248,7 @@ jobs:
- name: Install dependencies
run: |
composer global require phpunit/phpcov php-coveralls/php-coveralls
composer global require phpunit/phpcov:^8 php-coveralls/php-coveralls
- name: Download coverage artifacts
uses: actions/download-artifact@v4
@@ -262,7 +262,7 @@ jobs:
run: |
mkdir -p tests/_output
ls -la coverage-files/ 2>/dev/null || echo "No coverage files found"
if ls coverage-files/*.serialized 1>/dev/null 2>&1; then
if ls coverage-files/*.cov 1>/dev/null 2>&1; then
phpcov merge --clover=tests/_output/coverage.xml coverage-files
else
echo "No serialized coverage files to merge"