From 1a86fc7916c171dd7e70054d9e46f0fc98b797d2 Mon Sep 17 00:00:00 2001
From: Violin <violin@local>
Date: Fri, 17 Jul 2026 20:44:06 +0100
Subject: [PATCH] Fix release check in clean CI checkout

---
 plugins/violin_guard/release.py    | 10 +++++++++-
 tests/guard/guards/test_release.py | 19 +++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 tests/guard/guards/test_release.py

diff --git a/plugins/violin_guard/release.py b/plugins/violin_guard/release.py
index 362c11b..ecfdc83 100644
--- a/plugins/violin_guard/release.py
+++ b/plugins/violin_guard/release.py
@@ -53,6 +53,14 @@ def _plugin_root() -> Path:
     return Path(__file__).resolve().parent
 
 
+def _pytest_basetemp(repo_path: Path) -> str:
+    """Create pytest's private temp directory in the ignored engagement tree."""
+
+    engagement_root = repo_path / "engagements"
+    engagement_root.mkdir(parents=True, exist_ok=True)
+    return tempfile.mkdtemp(prefix=".pytest-release-", dir=engagement_root)
+
+
 def resolve_reference(source: Path, reference: str) -> Path:
     """Resolve a pentest skill reference from the skill package root."""
     source = source.resolve()
@@ -151,7 +159,7 @@ def check_release() -> ReleaseCheckResult:
         except FileNotFoundError:
             result.add_warning("ruff not installed; skipped")
         try:
-            basetemp = tempfile.mkdtemp(prefix=".pytest-release-", dir=repo_path / "engagements")
+            basetemp = _pytest_basetemp(repo_path)
             pytest = subprocess.run(
                 [
                     python,
diff --git a/tests/guard/guards/test_release.py b/tests/guard/guards/test_release.py
new file mode 100644
index 0000000..d3277da
--- /dev/null
+++ b/tests/guard/guards/test_release.py
@@ -0,0 +1,19 @@
+"""Regression coverage for release-gate setup in a clean checkout."""
+
+from __future__ import annotations
+
+from pathlib import Path
+
+from plugins.violin_guard.release import _pytest_basetemp
+
+
+def test_pytest_basetemp_creates_missing_engagement_root(tmp_path: Path) -> None:
+    engagement_root = tmp_path / "engagements"
+    assert not engagement_root.exists()
+
+    basetemp = Path(_pytest_basetemp(tmp_path))
+
+    assert engagement_root.is_dir()
+    assert basetemp.is_dir()
+    assert basetemp.parent == engagement_root
+    assert basetemp.name.startswith(".pytest-release-")