4 people 6136706ef3 fix(presets): coerce non-string catalog tags before joining (#3743) ...

* fix(presets): coerce non-string catalog tags before joining

Preset catalog payloads are user-editable YAML/JSON, so a `tags:` list
can legitimately contain non-strings (e.g. numeric tags). The preset
list/search/info display paths and the catalog search backend joined
tags with a raw `", ".join(...)` / used `t.lower()`, which raised
`TypeError: sequence item N: expected str instance, int found` (or
`AttributeError` on `.lower()`) and crashed the command.

Sibling command surfaces already guard this — extensions, integrations,
and workflows coerce with `str(t) for t in ...`. This aligns presets:

- `_commands.py`: `preset list`, `preset search`, and both `preset info`
  branches now join `str(t) for t in ...`.
- `__init__.py` `PresetCatalog.search`: tag filter uses `str(t).lower()`
  and the searchable-text join coerces tags to `str`.

Adds regression tests driving `preset search` and `preset info` through
CliRunner with numeric tags; both fail before the fix with the TypeError.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Potential fix for pull request finding

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

2026-07-27 14:14:59 -05:00

..

contract

fix(bundler): reject unsupported schema_version in _merge_config (align readers) (#3711)

2026-07-27 08:19:01 -05:00

extensions

fix(agent-context): apply default markers when config markers are blank (bash) (#3736)

2026-07-27 10:33:56 -05:00

hooks

chore: add pre-commit config and fix trailing whitespace/end-of-file (#3430)

2026-07-10 11:47:36 -05:00

integration

fix(bundler): InstallResult.changed counts uninstalled as a change (#3692)

2026-07-23 14:52:06 -05:00

integrations

fix: register extensions for the active integration only (#3459)

2026-07-27 14:09:40 -05:00

unit

fix(bundler): reject a top-level non-mapping bundle-catalogs.yml in _merge_config (#3659)

2026-07-23 11:15:14 -05:00

workflows

fix(workflows): preserve intra-overlay order for multiple insert_after edits (#3662)

2026-07-23 08:27:29 -05:00

__init__.py

…

auth_helpers.py

…

bundler_helpers.py

feat: add specify bundle command (#3070)

2026-06-19 17:07:20 -05:00

conftest.py

feat(cli): honor SPECIFY_INIT_DIR in the specify CLI project resolver (#3186)

2026-07-01 15:55:18 -05:00

http_helpers.py

harden: bound HTTP reads and enforce strict redirects (#3140)

2026-07-22 11:08:32 -05:00

parity_helpers.py

feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python (#3386)

2026-07-21 11:40:15 -05:00

self_upgrade_helpers.py

harden: bound HTTP reads and enforce strict redirects (#3140)

2026-07-22 11:08:32 -05:00

test_agent_config_consistency.py

feat: add Factory Droid CLI integration (#822) (#3587)

2026-07-22 07:49:48 -05:00

test_authentication.py

fix(auth): normalize whitespace in auth-config env-var/id references at store time (#3691)

2026-07-24 11:03:06 -05:00

test_branch_numbering.py

feat: make git extension opt-in and remove --no-git at v0.10.0 (#2873)

2026-06-09 06:13:07 -05:00

test_check_prerequisites_paths_only.py

fix: fall back to feature dir basename for empty CURRENT_BRANCH (#3026) (#3229)

2026-07-01 13:50:53 -05:00

test_check_prerequisites_python_parity.py

feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python (#3386)

2026-07-21 11:40:15 -05:00

test_check_tool.py

feat: add support for rovodev (#2539)

2026-06-04 11:34:05 -05:00

test_cli_version.py

…

test_command_template_py_scripts.py

feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python (#3386)

2026-07-21 11:40:15 -05:00

test_commands_package.py

feat(cli): add py script type & Python interpreter resolution (#3278) (#3285)

2026-07-01 16:34:46 -05:00

test_console_imports.py

chore(tests): fix ruff lint violations in tests/ (#2827)

2026-06-03 16:02:26 -05:00

test_create_new_feature_python_parity.py

fix: auto-correct conflicting feature prefixes (#1829)

2026-07-24 09:13:53 -05:00

test_download_security.py

fix: harden bounded reads and redirect validation (#3671)

2026-07-22 15:18:10 -05:00

test_extension_registration.py

chore: add pre-commit config and fix trailing whitespace/end-of-file (#3430)

2026-07-10 11:47:36 -05:00

test_extension_skills.py

fix: register extensions for the active integration only (#3459)

2026-07-27 14:09:40 -05:00

test_extension_update_hardening.py

chore: add pre-commit config and fix trailing whitespace/end-of-file (#3430)

2026-07-10 11:47:36 -05:00

test_extensions.py

fix: register extensions for the active integration only (#3459)

2026-07-27 14:09:40 -05:00

test_github_http.py

fix(github-http): return None on malformed host in resolve_github_release_asset_api_url (#3715)

2026-07-24 09:58:24 -05:00

test_github_workflows.py

Add community bundle submission automation (#3553)

2026-07-21 18:28:40 +01:00

test_init_dir_cli.py

feat(cli): honor SPECIFY_INIT_DIR in the specify CLI project resolver (#3186)

2026-07-01 15:55:18 -05:00

test_init_dir.py

feat(scripts): add SPECIFY_INIT_DIR to target a member project from the repo root (#2892)

2026-06-19 12:05:42 -05:00

test_live_transient_windows.py

fix: disable Rich Live transient mode on Windows to prevent PS 5.1 hang (#2938)

2026-06-17 06:48:42 -05:00

test_merge.py

chore: add pre-commit config and fix trailing whitespace/end-of-file (#3430)

2026-07-10 11:47:36 -05:00

test_post_process.py

fix(integrations): Cline overrides post_process_command_content (correct hook name) (#3657)

2026-07-22 16:26:24 -05:00

test_presets.py

fix(presets): coerce non-string catalog tags before joining (#3743)

2026-07-27 14:14:59 -05:00

test_ps1_encoding.py

…

test_registrar_path_traversal.py

Harden command registration path handling (#3088)

2026-06-22 10:25:29 -05:00

test_security_workflow.py

ci: add dependency audit workflow (#3138)

2026-07-22 05:20:55 -05:00

test_self_upgrade_detection.py

harden: bound HTTP reads and enforce strict redirects (#3140)

2026-07-22 11:08:32 -05:00

test_self_upgrade_execution.py

harden: bound HTTP reads and enforce strict redirects (#3140)

2026-07-22 11:08:32 -05:00

test_self_upgrade_guidance.py

fix: harden bounded reads and redirect validation (#3671)

2026-07-22 15:18:10 -05:00

test_self_upgrade_verification.py

harden: bound HTTP reads and enforce strict redirects (#3140)

2026-07-22 11:08:32 -05:00

test_setup_plan_feature_json.py

fix(scripts): fall through to grep/sed when python3 is a broken stub in feature.json parser (#3312)

2026-07-08 07:45:01 -05:00

test_setup_plan_no_overwrite.py

fix(scripts): route 'Plan template not found' per --json in setup-plan.ps1 (parity with bash) (#3241)

2026-06-29 16:37:40 -05:00

test_setup_plan_python_parity.py

feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python (#3386)

2026-07-21 11:40:15 -05:00

test_setup_tasks_python_parity.py

feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python (#3386)

2026-07-21 11:40:15 -05:00

test_setup_tasks.py

chore: add pre-commit config and fix trailing whitespace/end-of-file (#3430)

2026-07-10 11:47:36 -05:00

test_shared_infra_integrity.py

feat(extensions): verify catalog archive sha256 before install (#3080)

2026-06-24 14:52:24 -05:00

test_skill_placeholder_py.py

feat(scripts): port create-new-feature, setup-plan and setup-tasks to Python (#3386)

2026-07-21 11:40:15 -05:00

test_specify_template_numbering.py

Fix duplicate step numbering in specify command (#3647)

2026-07-22 18:06:59 +01:00

test_timestamp_branches.py

fix: auto-correct conflicting feature prefixes (#1829)

2026-07-24 09:13:53 -05:00

test_upgrade.py

fix: harden bounded reads and redirect validation (#3671)

2026-07-22 15:18:10 -05:00

test_utils_assets_imports.py

feat: make git extension opt-in and remove --no-git at v0.10.0 (#2873)

2026-06-09 06:13:07 -05:00

test_utils.py

harden: remove shell parameter from run_command() (#3716)

2026-07-24 09:46:36 -05:00

test_version_imports.py

chore(tests): fix ruff lint violations in tests/ (#2827)

2026-06-03 16:02:26 -05:00

test_workflow_run_without_project.py

fix(workflows): route run/resume errors to stderr under --json (#3352)

2026-07-07 14:52:36 -05:00

test_workflows.py

fix(workflows): escape remaining untrusted fields in workflow info (#3731)

2026-07-27 11:55:00 -05:00