mirror of
https://github.com/github/spec-kit.git
synced 2026-08-15 14:02:04 +02:00
e9ffc9d8e7
* feat: allow overriding default init integration via SPECKIT_INTEGRATION_DEFAULT Resolve the non-interactive/init default integration from the SPECKIT_INTEGRATION_DEFAULT environment variable, fitting the existing SPECKIT_INTEGRATION_* namespace. Falls back to the hardcoded "copilot" default when unset, and warns to stderr (rather than silently falling back) when the value is not a registered integration key. Wires the resolver into specify init (interactive prompt default and non-interactive fallback), the init workflow step, and the bundle init default. Adds unit and CLI tests and documents the variable. Closes #3939 Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eecda55f-fa13-42f7-99bf-bfb0bb8565a0 * test: cover env-var default wiring for picker, workflow step, and bundle Address PR review: add regression tests so each SPECKIT_INTEGRATION_DEFAULT wiring site cannot silently revert to the hardcoded constant. - init.py: interactive picker receives the resolved key as default_key. - workflow init step: no step/workflow default + env var drives output integration and argv. - bundle _resolve_init_integration: env-var default applies when unspecified, while explicit override and manifest-declared integration still win. Assisted-by: GitHub Copilot (model: claude-opus-4.8, autonomous) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eecda55f-fa13-42f7-99bf-bfb0bb8565a0 --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: eecda55f-fa13-42f7-99bf-bfb0bb8565a0
107 lines
3.5 KiB
Python
107 lines
3.5 KiB
Python
"""Install-time initialization and integration precedence (T049, T050).
|
|
|
|
``specify bundle install`` into an uninitialized directory must scaffold a Spec
|
|
Kit project first (FR-012), choosing the integration by precedence (FR-013):
|
|
explicit ``--integration`` override → bundle-declared integration → default.
|
|
The end-to-end test runs fully offline against bundled assets.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
|
|
import yaml
|
|
from typer.testing import CliRunner
|
|
|
|
from specify_cli import app
|
|
from specify_cli.bundler.models.manifest import BundleManifest
|
|
from specify_cli.commands.bundle import _resolve_init_integration
|
|
from specify_cli.bundler.services.packager import build_bundle
|
|
from tests.bundler_helpers import valid_manifest_dict
|
|
|
|
runner = CliRunner()
|
|
|
|
|
|
def _manifest(**overrides):
|
|
data = valid_manifest_dict(**overrides)
|
|
return BundleManifest.from_dict(data)
|
|
|
|
|
|
def test_precedence_override_wins():
|
|
manifest = _manifest(integration={"id": "claude"})
|
|
assert _resolve_init_integration("gemini", manifest) == "gemini"
|
|
|
|
|
|
def test_precedence_bundle_declared_when_no_override():
|
|
manifest = _manifest(integration={"id": "claude"})
|
|
assert _resolve_init_integration(None, manifest) == "claude"
|
|
|
|
|
|
def test_precedence_default_when_unspecified():
|
|
manifest = _manifest()
|
|
assert _resolve_init_integration(None, manifest) == "copilot"
|
|
assert _resolve_init_integration(None, None) == "copilot"
|
|
|
|
|
|
def test_precedence_default_honors_env_var(monkeypatch):
|
|
monkeypatch.setenv("SPECKIT_INTEGRATION_DEFAULT", "gemini")
|
|
# With no override and no bundle-declared integration, the env-var default
|
|
# applies instead of the hardcoded "copilot".
|
|
assert _resolve_init_integration(None, None) == "gemini"
|
|
assert _resolve_init_integration(None, _manifest()) == "gemini"
|
|
# Explicit override and bundle-declared integration still take precedence.
|
|
assert _resolve_init_integration("claude", None) == "claude"
|
|
assert (
|
|
_resolve_init_integration(None, _manifest(integration={"id": "claude"}))
|
|
== "claude"
|
|
)
|
|
|
|
|
|
def _build_mini(tmp_path: Path) -> Path:
|
|
bundle = tmp_path / "mini"
|
|
bundle.mkdir()
|
|
(bundle / "bundle.yml").write_text(
|
|
yaml.safe_dump(
|
|
{
|
|
"schema_version": "1.0",
|
|
"bundle": {
|
|
"id": "mini",
|
|
"name": "Mini",
|
|
"version": "1.0.0",
|
|
"role": "developer",
|
|
"description": "minimal",
|
|
"author": "tests",
|
|
"license": "MIT",
|
|
},
|
|
"requires": {"speckit_version": ">=0.1.0"},
|
|
"provides": {"extensions": [{"id": "agent-context", "version": "1.0.0"}]},
|
|
}
|
|
),
|
|
encoding="utf-8",
|
|
)
|
|
(bundle / "README.md").write_text("# Mini\n", encoding="utf-8")
|
|
return build_bundle(bundle).artifact_path
|
|
|
|
|
|
def test_install_initializes_uninitialized_project(tmp_path: Path):
|
|
project = tmp_path / "proj"
|
|
project.mkdir()
|
|
artifact = _build_mini(tmp_path)
|
|
|
|
previous = Path.cwd()
|
|
os.chdir(project)
|
|
try:
|
|
result = runner.invoke(
|
|
app, ["bundle", "install", str(artifact), "--offline"]
|
|
)
|
|
assert result.exit_code == 0, result.output
|
|
finally:
|
|
os.chdir(previous)
|
|
|
|
assert (project / ".specify").is_dir()
|
|
marker = project / ".specify" / "integration.json"
|
|
assert marker.exists()
|
|
data = json.loads(marker.read_text(encoding="utf-8"))
|
|
assert "copilot" in json.dumps(data)
|