mirror of
https://github.com/SigNoz/signoz.git
synced 2025-12-17 15:36:48 +00:00
1f33928bf9
### Summary
Integrate the new implementations of the alertmanager along with changes to the ruler. This change can be broadly categoried into 3 parts:
#### Frontend
- The earlier `/api/v1/alerts` api was double encoding the response in json and sending it to the frontend. This PR fixes the json response object.
For instance, we have gone from the response `{
"status": "success",
"data": "{\"status\":\"success\",\"data\":[{\"labels\":{\"alertname\":\"[platform][consumer] consumer is above 100% memory utilization\",\"bu\":\"platform\",\"......
}` to the response `{"status":"success","data":[{"labels":{"alertname":"[Metrics] Pod CP......`
- `msteams` has been changed to `msteamsv2` wherever applicable
#### Ruler
The following changes have been done in the ruler component:
- Removal of the old alertmanager and notifier
- The RuleDB methods `Create`, `Edit` and `Delete` have been made transactional
- Introduction of a new `testPrepareNotifyFunc` for sending test notifications
- Integration with the new alertmanager
#### Alertmanager
Although a huge chunk of the alertmanagers have been merged in previous PRs (the list can be found at https://github.com/SigNoz/platform-pod/issues/404), this PR takes care of changes needed in order to incorporate it with the ruler
- Addition of ruleId based matching
- Support for marshalling the global configuration directly from the upstream alertmanager
- Addition of orgId to the legacy alertmanager
- Support for always adding defaults to both routes and receivers while creating them
- Migration to create the required alertmanager tables
- Migration for msteams to msteamsv2 has been added. We will start using msteamv2 config for the new alertmanager and keep using msteams for the old one.
#### Related Issues / PR's
Closes https://github.com/SigNoz/platform-pod/issues/404
Closes https://github.com/SigNoz/platform-pod/issues/176
71 lines
1.4 KiB
Go
71 lines
1.4 KiB
Go
package factory
|
|
|
|
import (
|
|
"context"
|
|
"io"
|
|
"log/slog"
|
|
"sync"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
type tservice struct {
|
|
c chan struct{}
|
|
}
|
|
|
|
func newTestService(t *testing.T) *tservice {
|
|
t.Helper()
|
|
return &tservice{c: make(chan struct{})}
|
|
}
|
|
|
|
func (s *tservice) Start(_ context.Context) error {
|
|
<-s.c
|
|
return nil
|
|
}
|
|
|
|
func (s *tservice) Stop(_ context.Context) error {
|
|
close(s.c)
|
|
return nil
|
|
}
|
|
|
|
func TestRegistryWith2Services(t *testing.T) {
|
|
s1 := newTestService(t)
|
|
s2 := newTestService(t)
|
|
|
|
registry, err := NewRegistry(slog.New(slog.NewTextHandler(io.Discard, nil)), NewNamedService(MustNewName("s1"), s1), NewNamedService(MustNewName("s2"), s2))
|
|
require.NoError(t, err)
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
registry.Start(ctx)
|
|
require.NoError(t, registry.Wait(ctx))
|
|
require.NoError(t, registry.Stop(ctx))
|
|
}()
|
|
cancel()
|
|
|
|
wg.Wait()
|
|
}
|
|
|
|
func TestRegistryWith2ServicesWithoutWait(t *testing.T) {
|
|
s1 := newTestService(t)
|
|
s2 := newTestService(t)
|
|
|
|
registry, err := NewRegistry(slog.New(slog.NewTextHandler(io.Discard, nil)), NewNamedService(MustNewName("s1"), s1), NewNamedService(MustNewName("s2"), s2))
|
|
require.NoError(t, err)
|
|
|
|
ctx := context.Background()
|
|
var wg sync.WaitGroup
|
|
wg.Add(1)
|
|
go func() {
|
|
defer wg.Done()
|
|
registry.Start(ctx)
|
|
require.NoError(t, registry.Stop(ctx))
|
|
}()
|
|
|
|
wg.Wait()
|
|
}
|