External/signoz
1
0
Fork 0
mirror of https://github.com/SigNoz/signoz.git synced 2025-12-17 15:36:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: fix edit alerts page crashing (#9025)

Browse Source
This commit is contained in:
Amlan Kumar Nandy 2025-09-17 13:14:25 +07:00 committed by GitHub
parent e8035b7dd2
commit ff8ac96d37
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
frontend/src/container/QueryBuilder/filters/GroupByFilter/GroupByFilter.tsx
View File

@ -163,12 +163,11 @@ export const GroupByFilter = memo(function GroupByFilter({
}, []);
useEffect(() => {
const currentValues: SelectOption<string, string>[] = query.groupBy.map(
(item) => ({
const currentValues: SelectOption<string, string>[] =
query.groupBy?.map((item) => ({
label: `${item.key}`,
value: `${item.id}`,
}),
);
})) || [];
setLocalValues(currentValues);
}, [query]);
@ -191,7 +190,7 @@ export const GroupByFilter = memo(function GroupByFilter({
notFoundContent={isFetching ? <Spin size="small" /> : null}
onChange={handleChange}
data-testid="group-by"
placeholder={localValues.length === 0 ? 'Everything (no breakdown)' : ''}
placeholder={localValues?.length === 0 ? 'Everything (no breakdown)' : ''}
/>
);
});

10
frontend/src/utils/convertNewToOldQueryBuilder.ts
View File

@ -34,16 +34,18 @@ export const convertBuilderQueryToIBuilderQuery = (
queryName: builderQuery.name,
dataSource,
legend: builderQuery.legend,
groupBy: builderQuery.groupBy?.map((group) => ({
groupBy:
builderQuery.groupBy?.map((group) => ({
key: group?.name,
dataType: group?.fieldDataType,
type: group?.fieldContext,
id: `${group?.name}--${group?.fieldDataType}--${group?.fieldContext}`,
})),
orderBy: builderQuery.order?.map((order) => ({
})) || [],
orderBy:
builderQuery.order?.map((order) => ({
columnName: order?.key?.name,
order: order?.direction,
})),
})) || [],
} as unknown) as IBuilderQuery;
return result;