External/signoz
1
0
Fork 0
mirror of https://github.com/SigNoz/signoz.git synced 2025-12-17 23:47:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: open log details on clicking on empty column cell too (#8618)

Browse Source
This commit is contained in:
Yunus M 2025-07-29 14:06:13 +05:30 committed by GitHub
parent 498d398ea3
commit fa936a7e0d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
frontend/src/container/LogsExplorerList/InfinityTableView/TableRow.tsx
View File

@ -23,6 +23,7 @@ interface TableRowProps {
index: number; index: number;
log: Record<string, unknown>; log: Record<string, unknown>;
handleSetActiveContextLog: (log: ILog) => void; handleSetActiveContextLog: (log: ILog) => void;
onShowLogDetails: (log: ILog) => void;
logs: ILog[]; logs: ILog[];
hasActions: boolean; hasActions: boolean;
fontSize: FontSize; fontSize: FontSize;
@ -33,6 +34,7 @@ export default function TableRow({
index, index,
log, log,
handleSetActiveContextLog, handleSetActiveContextLog,
onShowLogDetails,
logs, logs,
hasActions, hasActions,
fontSize, fontSize,
@ -57,6 +59,11 @@ export default function TableRow({
[currentLog, handleSetActiveContextLog], [currentLog, handleSetActiveContextLog],
); );
const handleShowLogDetails = useCallback(() => {
if (!onShowLogDetails || !currentLog) return;
onShowLogDetails(currentLog);
}, [currentLog, onShowLogDetails]);
const hasSingleColumn = const hasSingleColumn =
tableColumns.filter((column) => column.key !== 'state-indicator').length === tableColumns.filter((column) => column.key !== 'state-indicator').length ===
1; 1;
@ -89,6 +96,7 @@ export default function TableRow({
key={column.key} key={column.key}
fontSize={fontSize} fontSize={fontSize}
columnKey={column.key as string} columnKey={column.key as string}
onClick={handleShowLogDetails}
> >
{cloneElement(children, props)} {cloneElement(children, props)}
</TableCellStyled> </TableCellStyled>

11
frontend/src/container/LogsExplorerList/InfinityTableView/index.tsx
View File

@ -108,6 +108,7 @@ const InfinityTable = forwardRef<TableVirtuosoHandle, InfinityTableProps>(
logs={tableViewProps.logs} logs={tableViewProps.logs}
hasActions hasActions
fontSize={tableViewProps.fontSize} fontSize={tableViewProps.fontSize}
onShowLogDetails={onSetActiveLog}
/> />
), ),
[ [
@ -115,6 +116,7 @@ const InfinityTable = forwardRef<TableVirtuosoHandle, InfinityTableProps>(
tableColumns, tableColumns,
tableViewProps.fontSize, tableViewProps.fontSize,
tableViewProps.logs, tableViewProps.logs,
onSetActiveLog,
], ],
); );
@ -146,12 +148,6 @@ const InfinityTable = forwardRef<TableVirtuosoHandle, InfinityTableProps>(
[tableColumns, isDarkMode, tableViewProps?.fontSize], [tableColumns, isDarkMode, tableViewProps?.fontSize],
); );
const handleClickExpand = (index: number): void => {
if (!onSetActiveLog) return;
onSetActiveLog(tableViewProps.logs[index]);
};
return ( return (
<> <>
<TableVirtuoso <TableVirtuoso
@ -183,9 +179,6 @@ const InfinityTable = forwardRef<TableVirtuosoHandle, InfinityTableProps>(
{...(infitiyTableProps?.onEndReached {...(infitiyTableProps?.onEndReached
? { endReached: infitiyTableProps.onEndReached } ? { endReached: infitiyTableProps.onEndReached }
: {})} : {})}
onClick={(event: any): void => {
handleClickExpand(event.target.parentElement.parentElement.dataset.index);
}}
/> />
{activeContextLog && ( {activeContextLog && (