From e000afeaeb45d3045de8b00eed77525f4bb47971 Mon Sep 17 00:00:00 2001
From: Yunus M <myounis.ar@live.com>
Date: Thu, 15 May 2025 13:27:53 +0530
Subject: [PATCH] feat: remove () from suggestions

---
 .../QueryAddOns/HavingFilter/HavingFilter.tsx | 20 ++-----------------
 1 file changed, 2 insertions(+), 18 deletions(-)

diff --git a/frontend/src/components/QueryBuilderV2/QueryAddOns/HavingFilter/HavingFilter.tsx b/frontend/src/components/QueryBuilderV2/QueryAddOns/HavingFilter/HavingFilter.tsx
index fb2f0027d21d..23657bf0962a 100644
--- a/frontend/src/components/QueryBuilderV2/QueryAddOns/HavingFilter/HavingFilter.tsx
+++ b/frontend/src/components/QueryBuilderV2/QueryAddOns/HavingFilter/HavingFilter.tsx
@@ -52,9 +52,6 @@ const conjunctions = [
 	{ label: 'OR', value: 'OR' },
 ];
 
-const openBrace = { label: '(', value: '(' };
-const closeBrace = { label: ')', value: ')' };
-
 function HavingFilter(): JSX.Element {
 	const { aggregationOptions } = useQueryBuilderV2Context();
 	const [input, setInput] = useState('');
@@ -89,24 +86,12 @@ function HavingFilter(): JSX.Element {
 		const isKeyOperator = (token: string): boolean =>
 			options.some((opt) => token.startsWith(opt.value));
 
-		// Helper to count standalone ( and ) for grouping
-		const countGroupingBraces = (
-			input: string,
-		): { openCount: number; closeCount: number } => {
-			// Remove aggregator function calls (e.g., sum(duration))
-			const withoutFuncs = input.replace(/\w+\([^)]*\)/g, '');
-			const openCount = (withoutFuncs.match(/\(/g) || []).length;
-			const closeCount = (withoutFuncs.match(/\)/g) || []).length;
-			return { openCount, closeCount };
-		};
-
 		return autocompletion({
 			override: [
 				(context: CompletionContext): CompletionResult | null => {
 					const text = context.state.sliceDoc(0, context.pos);
 					const trimmedText = text.trim();
 					const tokens = trimmedText.split(/\s+/).filter(Boolean);
-					const { openCount, closeCount } = countGroupingBraces(text);
 
 					// Suggest key/operator pairs and ( for grouping
 					if (
@@ -116,7 +101,7 @@ function HavingFilter(): JSX.Element {
 					) {
 						return {
 							from: context.pos,
-							options: [openBrace, ...options],
+							options,
 						};
 					}
 					if (isKeyOperator(tokens[tokens.length - 1])) {
@@ -133,8 +118,7 @@ function HavingFilter(): JSX.Element {
 					) {
 						return {
 							from: context.pos,
-							options:
-								openCount > closeCount ? [closeBrace, ...conjunctions] : conjunctions,
+							options: conjunctions,
 						};
 					}
 					// Suggest conjunctions after a closing parenthesis and a space