From cc2418c1602093af2a18969f23c4446f66e256ab Mon Sep 17 00:00:00 2001 From: Shivanshu Raj Shrivastava Date: Wed, 14 May 2025 11:48:22 +0530 Subject: [PATCH] fix: migration update Signed-off-by: Shivanshu Raj Shrivastava --- ...ce_funnels.go => 032_add_trace_funnels.go} | 55 ++++++++++--------- 1 file changed, 29 insertions(+), 26 deletions(-) rename pkg/sqlmigration/{030_add_trace_funnels.go => 032_add_trace_funnels.go} (76%) diff --git a/pkg/sqlmigration/030_add_trace_funnels.go b/pkg/sqlmigration/032_add_trace_funnels.go similarity index 76% rename from pkg/sqlmigration/030_add_trace_funnels.go rename to pkg/sqlmigration/032_add_trace_funnels.go index 12759bc0b620..1d8be2c34fff 100644 --- a/pkg/sqlmigration/030_add_trace_funnels.go +++ b/pkg/sqlmigration/032_add_trace_funnels.go @@ -54,19 +54,20 @@ func (migration *addTraceFunnels) Up(ctx context.Context, db *bun.DB) error { } // Add unique constraint for org_id and name - _, err = tx.NewRaw(` - CREATE UNIQUE INDEX IF NOT EXISTS idx_trace_funnel_org_id_name - ON trace_funnel (org_id, name) - `).Exec(ctx) - if err != nil { - return fmt.Errorf("failed to create unique constraint: %v", err) - } + //_, err = tx.NewRaw(` + // CREATE UNIQUE INDEX IF NOT EXISTS idx_trace_funnel_org_id_name + // ON trace_funnel (org_id, name) + //`).Exec(ctx) + //if err != nil { + // return fmt.Errorf("failed to create unique constraint: %v", err) + //} // Create indexes _, err = tx.NewCreateIndex(). Model((*traceFunnels.Funnel)(nil)). Index("idx_trace_funnel_org_id"). Column("org_id"). + IfNotExists(). Exec(ctx) if err != nil { return fmt.Errorf("failed to create org_id index: %v", err) @@ -75,7 +76,9 @@ func (migration *addTraceFunnels) Up(ctx context.Context, db *bun.DB) error { _, err = tx.NewCreateIndex(). Model((*traceFunnels.Funnel)(nil)). Index("idx_trace_funnel_created_at"). - Column("created_at").Exec(ctx) + Column("created_at"). + IfNotExists(). + Exec(ctx) if err != nil { return fmt.Errorf("failed to create created_at index: %v", err) } @@ -88,24 +91,24 @@ func (migration *addTraceFunnels) Up(ctx context.Context, db *bun.DB) error { } func (migration *addTraceFunnels) Down(ctx context.Context, db *bun.DB) error { - tx, err := db.BeginTx(ctx, nil) - if err != nil { - return err - } - defer tx.Rollback() - - // Drop trace_funnel table - _, err = tx.NewDropTable(). - Model((*traceFunnels.Funnel)(nil)). - IfExists(). - Exec(ctx) - if err != nil { - return fmt.Errorf("failed to drop trace_funnel table: %v", err) - } - - if err := tx.Commit(); err != nil { - return err - } + //tx, err := db.BeginTx(ctx, nil) + //if err != nil { + // return err + //} + //defer tx.Rollback() + // + //// Drop trace_funnel table + //_, err = tx.NewDropTable(). + // Model((*traceFunnels.Funnel)(nil)). + // IfExists(). + // Exec(ctx) + //if err != nil { + // return fmt.Errorf("failed to drop trace_funnel table: %v", err) + //} + // + //if err := tx.Commit(); err != nil { + // return err + //} return nil }